Skip to content

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Apr 17, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fix missing params for sinks

@nikvas0 nikvas0 requested a review from a team as a code owner April 17, 2025 11:53
@github-actions
Copy link

🟢 2025-04-17 11:56:15 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

2025-04-17 11:56:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9ae660f has started.
2025-04-17 11:57:13 UTC Artifacts will be uploaded here
2025-04-17 12:00:48 UTC ya make is running...
2025-04-17 12:28:08 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

2025-04-17 11:59:20 UTC Pre-commit check linux-x86_64-release-asan for 9ae660f has started.
2025-04-17 11:59:35 UTC Artifacts will be uploaded here
2025-04-17 12:02:31 UTC ya make is running...
2025-04-17 12:28:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

2025-04-17 12:43:46 UTC Pre-commit check linux-x86_64-release-asan for 1285b66 has started.
2025-04-17 12:44:02 UTC Artifacts will be uploaded here
2025-04-17 12:46:59 UTC ya make is running...
🟡 2025-04-17 14:06:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12441 12207 0 156 52 26

2025-04-17 14:07:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-17 14:21:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
296 (only retried tests) 211 0 44 17 24

2025-04-17 14:22:07 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-17 14:34:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 51 0 38 2 24

🟢 2025-04-17 14:34:48 UTC Build successful.
🟢 2025-04-17 14:35:20 UTC ydbd size 3.9 GiB changed* by +288 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6ff3ed merge: 1285b66 diff diff %
ydbd size 4 146 909 128 Bytes 4 146 909 416 Bytes +288 Bytes +0.000%
ydbd stripped size 1 431 776 184 Bytes 1 431 776 184 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 17, 2025

2025-04-17 12:43:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1285b66 has started.
2025-04-17 12:44:03 UTC Artifacts will be uploaded here
2025-04-17 12:46:58 UTC ya make is running...
🟡 2025-04-17 13:55:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20087 18706 0 3 1265 113

2025-04-17 13:57:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-17 14:11:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 78 0 0 0 97

🟢 2025-04-17 14:11:57 UTC Build successful.
🟢 2025-04-17 14:12:18 UTC ydbd size 2.2 GiB changed* by +80 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f6ff3ed merge: 1285b66 diff diff %
ydbd size 2 363 239 816 Bytes 2 363 239 896 Bytes +80 Bytes +0.000%
ydbd stripped size 493 831 456 Bytes 493 831 456 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) April 17, 2025 13:15
@nikvas0 nikvas0 requested a review from gridnevvvit April 17, 2025 13:15
@nikvas0 nikvas0 merged commit 5ce8784 into ydb-platform:main Apr 18, 2025
12 checks passed
nikvas0 added a commit to nikvas0/ydb that referenced this pull request May 7, 2025
@nikvas0 nikvas0 mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants