Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Apr 21, 2025

Changelog entry

fix output of optional structs, closes #17226

Changelog category

  • Bugfix

Description for reviewers

...

@adameat adameat added the area/ui UI/Embedded UI related issues label Apr 21, 2025
@adameat adameat self-assigned this Apr 21, 2025
@adameat adameat requested a review from a team as a code owner April 21, 2025 07:22
@github-actions
Copy link

🟢 2025-04-21 07:22:58 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 21, 2025

2025-04-21 07:26:26 UTC Pre-commit check linux-x86_64-release-asan for 6bba25d has started.
2025-04-21 07:26:41 UTC Artifacts will be uploaded here
2025-04-21 07:29:27 UTC ya make is running...
🟡 2025-04-21 09:00:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12208 12062 0 85 35 26

2025-04-21 09:01:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-21 09:14:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 117 0 35 16 21

2025-04-21 09:14:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-21 09:27:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
91 (only retried tests) 36 0 33 3 19

🟢 2025-04-21 09:27:47 UTC Build successful.
🟢 2025-04-21 09:28:21 UTC ydbd size 3.9 GiB changed* by -560 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c590a01 merge: 6bba25d diff diff %
ydbd size 4 148 273 440 Bytes 4 148 272 880 Bytes -560 Bytes -0.000%
ydbd stripped size 1 432 101 400 Bytes 1 432 101 016 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 21, 2025

2025-04-21 07:26:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6bba25d has started.
2025-04-21 07:26:58 UTC Artifacts will be uploaded here
2025-04-21 07:29:53 UTC ya make is running...
🟡 2025-04-21 08:33:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19644 18266 0 4 1266 108

2025-04-21 08:34:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-21 08:46:43 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 75 0 0 0 96

🟢 2025-04-21 08:46:50 UTC Build successful.
🟢 2025-04-21 08:47:13 UTC ydbd size 2.2 GiB changed* by -336 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c590a01 merge: 6bba25d diff diff %
ydbd size 2 363 960 776 Bytes 2 363 960 440 Bytes -336 Bytes -0.000%
ydbd stripped size 493 946 624 Bytes 493 946 432 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) April 22, 2025 03:44
@adameat adameat merged commit 01a07bc into ydb-platform:main Apr 22, 2025
17 of 19 checks passed
adameat added a commit to adameat/ydb that referenced this pull request Apr 29, 2025
adameat added a commit to adameat/ydb that referenced this pull request May 13, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui UI/Embedded UI related issues bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional<Struct> columns are always shown as NULLs in Embedded UI

3 participants