Skip to content

Fix nullable value in TKafkaRecord #17609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FloatingCrowbar merged 1 commit into from
Apr 23, 2025
Merged

Fix nullable value in TKafkaRecord #17609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kafka_proxy/kafka_records.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class TKafkaRecord: public TMessage {

static constexpr TKafkaVersions PresentVersions = VersionsAlways;
static constexpr TKafkaVersions TaggedVersions = VersionsNever;
static constexpr TKafkaVersions NullableVersions = VersionsNever;
static constexpr TKafkaVersions NullableVersions = VersionsAlways;
static constexpr TKafkaVersions FlexibleVersions = VersionsAlways;
};
ValueMeta::Type Value;
Expand Down
18 changes: 18 additions & 0 deletions ydb/core/kafka_proxy/ut/ut_protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,24 @@ Y_UNIT_TEST_SUITE(KafkaProtocol) {
AssertMessageMeta(readMessage, headerKey, headerValue);
}

// send empty produce message
{
TKafkaRecordBatch batch;
batch.BaseOffset = 3;
batch.BaseSequence = 5;
batch.Magic = 2; // Current supported
batch.Records.resize(1);
batch.Records[0].Key = TKafkaBytes{};
batch.Records[0].Value = TKafkaBytes{};

auto msg = client.Produce(topicName, 0, batch);

UNIT_ASSERT_VALUES_EQUAL(msg->Responses[0].Name, topicName);
UNIT_ASSERT_VALUES_EQUAL(msg->Responses[0].PartitionResponses[0].Index, 0);
UNIT_ASSERT_VALUES_EQUAL(msg->Responses[0].PartitionResponses[0].ErrorCode,
static_cast<TKafkaInt16>(EKafkaErrors::NONE_ERROR));
}

{
// Check short topic name

Expand Down
Loading