Skip to content

Sink: RW stats #17669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikvas0 merged 1 commit into from
Apr 25, 2025
Merged

Sink: RW stats #17669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ydb/core/kqp/counters/kqp_counters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,9 @@ TKqpCounters::TKqpCounters(const ::NMonitoring::TDynamicCounterPtr& counters, co
WriteActorImmediateWritesRetries = KqpGroup->GetCounter("SinkWrites/WriteActorImmediateWritesRetries", true);
WriteActorPrepareWrites = KqpGroup->GetCounter("SinkWrites/WriteActorPrepareWrites", true);

WriteActorWriteOnlyOperations = KqpGroup->GetCounter("SinkWrites/WriteActorWriteOnlyOperations", true);
WriteActorReadWriteOperations = KqpGroup->GetCounter("SinkWrites/WriteActorReadWriteOperations", true);

BufferActorFlushes = KqpGroup->GetCounter("SinkWrites/BufferActorFlushes", true);
BufferActorImmediateCommits = KqpGroup->GetCounter("SinkWrites/BufferActorImmediateCommits", true);
BufferActorDistributedCommits = KqpGroup->GetCounter("SinkWrites/BufferActorDistributedCommits", true);
Expand Down
3 changes: 3 additions & 0 deletions ydb/core/kqp/counters/kqp_counters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,9 @@ class TKqpCounters : public TKqpCountersBase, public NYql::NDq::TSpillingCounter
::NMonitoring::TDynamicCounters::TCounterPtr WriteActorImmediateWritesRetries;
::NMonitoring::TDynamicCounters::TCounterPtr WriteActorPrepareWrites;

::NMonitoring::TDynamicCounters::TCounterPtr WriteActorWriteOnlyOperations;
::NMonitoring::TDynamicCounters::TCounterPtr WriteActorReadWriteOperations;

::NMonitoring::TDynamicCounters::TCounterPtr BufferActorFlushes;
::NMonitoring::TDynamicCounters::TCounterPtr BufferActorImmediateCommits;
::NMonitoring::TDynamicCounters::TCounterPtr BufferActorDistributedCommits;
Expand Down
9 changes: 9 additions & 0 deletions ydb/core/kqp/runtime/kqp_write_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,15 @@ class TKqpTableWriteActor : public TActorBootstrapped<TKqpTableWriteActor> {
Counters->WriteActorWritesSizeHistogram->Collect(serializationResult.TotalDataSize);
Counters->WriteActorWritesOperationsHistogram->Collect(metadata->OperationsCount);

for (const auto& operation : evWrite->Record.GetOperations()) {
if (operation.GetType() == NKikimrDataEvents::TEvWrite::TOperation::OPERATION_INSERT
|| operation.GetType() == NKikimrDataEvents::TEvWrite::TOperation::OPERATION_UPDATE) {
Counters->WriteActorReadWriteOperations->Inc();
} else {
Counters->WriteActorWriteOnlyOperations->Inc();
}
}

SendTime[shardId] = TInstant::Now();
} else {
YQL_ENSURE(!isPrepare);
Expand Down
Loading