Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'FQ_CONNECTOR_ENDPOINT' env variable to local_ydb #1769

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Added 'FQ_CONNECTOR_ENDPOINT' env variable to local_ydb #1769

merged 2 commits into from
Feb 9, 2024

Conversation

vitalyisaev2
Copy link
Member

Changelog entry

Added 'FQ_CONNECTOR_ENDPOINT' env variable to local_ydb. It configures query_service_config section in order to enable YDB's Federated Query features. This option will be used by OSS YDB users for joint YDB + FQ Connector deployments.

Changelog category

  • New feature

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 12:26:18 UTC Pre-commit check for 6dcf459 has started.
⚪ 2024-02-09 12:26:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 12:27:42 UTC Build successful.
⚪ 2024-02-09 12:27:57 UTC Tests are running...
🔴 2024-02-09 13:59:01 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14739 14569 0 10 127 33

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 12:26:34 UTC Pre-commit check for 6dcf459 has started.
⚪ 2024-02-09 12:26:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 12:28:04 UTC Build successful.
⚪ 2024-02-09 12:28:17 UTC Tests are running...
🔴 2024-02-09 13:43:49 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67413 56486 0 1 10892 34

gridnevvvit
gridnevvvit previously approved these changes Feb 9, 2024
View reviewed changes
uzhastik
uzhastik reviewed Feb 9, 2024
View reviewed changes
ydb/public/tools/lib/cmds/__init__.py Outdated Show resolved Hide resolved
ydb/public/tools/lib/cmds/__init__.py Outdated Show resolved Hide resolved
ydb/tests/library/ut/kikimr_config.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 14:43:44 UTC Pre-commit check for 1823ba8 has started.
⚪ 2024-02-09 14:43:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 14:45:05 UTC Build successful.
⚪ 2024-02-09 14:45:17 UTC Tests are running...
🔴 2024-02-09 16:10:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67313 56386 0 2 10892 33

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 14:43:53 UTC Pre-commit check for 1823ba8 has started.
⚪ 2024-02-09 14:43:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 14:45:19 UTC Build successful.
⚪ 2024-02-09 14:45:32 UTC Tests are running...
🔴 2024-02-09 16:07:34 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14745 14550 0 24 136 35

uzhastik
uzhastik approved these changes Feb 9, 2024
View reviewed changes
ydb/public/tools/lib/cmds/__init__.py
cfg.Endpoint.port = parsed.port

if parsed.scheme == 'grpc':
cfg.UseSsl = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

сfg.UseSsl = (parsed.scheme == "grpcs")

@vitalyisaev2 vitalyisaev2 merged commit 767e5eb into ydb-platform:main Feb 9, 2024
2 of 4 checks passed
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
This was referenced Feb 21, 2024
Merged
Merged
Merged
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 5, 2024
@vitalyisaev2 @EgorkaZ
Added 'FQ_CONNECTOR_ENDPOINT' env variable to local_ydb (ydb-platfo…
e6c4f34 
…rm#1769)

* Add 'FQ_CONNECTOR_ENDPOINT' env parameter for `local_ydb`

* Handle scheme type in `FQ_CONNECTOR_ENDPOINT` env variable
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 8, 2024
@vitalyisaev2 @EgorkaZ
Added 'FQ_CONNECTOR_ENDPOINT' env variable to local_ydb (ydb-platfo…
6dfda2f 
…rm#1769)

* Add 'FQ_CONNECTOR_ENDPOINT' env parameter for `local_ydb`

* Handle scheme type in `FQ_CONNECTOR_ENDPOINT` env variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

@gridnevvvit gridnevvvit gridnevvvit left review comments

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitalyisaev2 @gridnevvvit @uzhastik