Handle PDisk stop event if PDisk is in error or init state #17780
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the PDisk stop event must be handled correctly even if the PDisk is in an error or uninitialized state. Key changes include:
- Extraction of PDisk stop handling into a dedicated function (OnPDiskStop).
- Addition of new unit tests to verify PDiskStop handling in both error and uninitialized states.
- Registration of TEvReadFormatResult to an error handler for improved error state management.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/core/blobstorage/pdisk/blobstorage_pdisk_ut.cpp | New tests added to validate PDiskStop handling under error/uninitialized conditions |
| ydb/core/blobstorage/pdisk/blobstorage_pdisk_actor.cpp | Refactored PDiskStop handling and adjusted error handler registration |
Comments suppressed due to low confidence (1)
ydb/core/blobstorage/pdisk/blobstorage_pdisk_actor.cpp:1524
- [nitpick] Ensure that there are dedicated unit tests covering the handling of TEvReadFormatResult in the error state to confirm the intended behavior when these events are received.
hFunc(NPDisk::TEvReadFormatResult, ErrorHandle);
|
🟢 |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Co-authored-by: Vlad Kuznetsov <va.kuznecov@physics.msu.ru>
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…orm#17780) (cherry picked from commit cfede7f)
3 participants
Changelog entry
Make PDisk handle
TEvYardControl::PDiskStopin Error and Init statesChangelog category
Description for reviewers
...
Issues:
#17953