Skip to content

Fix hasRead for sink #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikvas0 merged 2 commits into from
Apr 30, 2025
Merged

Fix hasRead for sink #17844

nikvas0 merged 2 commits into from
Apr 30, 2025

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Apr 29, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Fix hasRead for sink

@nikvas0 nikvas0 requested a review from a team as a code owner April 29, 2025 08:34
@github-actions
Copy link

github-actions bot commented Apr 29, 2025

🟢 2025-04-29 08:37:40 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 08:38:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for c247fb7 has started.
⚪ 2025-04-29 08:38:33 UTC Artifacts will be uploaded here
⚪ 2025-04-29 08:41:26 UTC ya make is running...
⚫ 2025-04-29 08:57:41 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 08:38:44 UTC Pre-commit check linux-x86_64-release-asan for c247fb7 has started.
⚪ 2025-04-29 08:38:59 UTC Artifacts will be uploaded here
⚪ 2025-04-29 08:41:46 UTC ya make is running...
⚫ 2025-04-29 08:58:00 UTC Check cancelled

@nikvas0 nikvas0 requested a review from a team as a code owner April 29, 2025 08:57
@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 09:04:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5d0cd83 has started.
⚪ 2025-04-29 09:04:42 UTC Artifacts will be uploaded here
⚪ 2025-04-29 09:07:39 UTC ya make is running...
🟡 2025-04-29 10:23:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20598 19235 0 4 1322 37

⚪ 2025-04-29 10:24:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 10:59:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 112 0 1 15 33

⚪ 2025-04-29 11:00:03 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-29 11:31:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 61 0 1 11 35

🟢 2025-04-29 11:31:56 UTC Build successful.
🟢 2025-04-29 11:32:20 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3e9820c merge: 5d0cd83 diff diff %
ydbd size 2 343 122 584 Bytes 2 343 122 584 Bytes 0 Bytes 0.000%
ydbd stripped size 492 681 984 Bytes 492 681 984 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 09:06:15 UTC Pre-commit check linux-x86_64-release-asan for 5d0cd83 has started.
⚪ 2025-04-29 09:06:30 UTC Artifacts will be uploaded here
⚪ 2025-04-29 09:09:17 UTC ya make is running...
🟡 2025-04-29 10:36:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12835 12656 0 105 51 23

⚪ 2025-04-29 10:37:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 11:06:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1113 (only retried tests) 1018 0 46 26 23

⚪ 2025-04-29 11:06:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-29 11:33:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
784 (only retried tests) 679 0 45 37 23

🟢 2025-04-29 11:33:14 UTC Build successful.
🟢 2025-04-29 11:33:48 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3e9820c merge: 5d0cd83 diff diff %
ydbd size 4 121 948 056 Bytes 4 121 947 960 Bytes -96 Bytes -0.000%
ydbd stripped size 1 428 821 016 Bytes 1 428 820 952 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 force-pushed the fix-has-read-sink branch from 4d143a2 to 91d464b Compare April 29, 2025 11:46
@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 11:49:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 796dfa6 has started.
⚪ 2025-04-29 11:50:01 UTC Artifacts will be uploaded here
⚪ 2025-04-29 11:52:46 UTC ya make is running...
🟡 2025-04-29 13:08:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20600 19222 0 9 1333 36

⚪ 2025-04-29 13:10:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 13:51:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 101 0 1 13 31

⚪ 2025-04-29 13:51:46 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-29 14:20:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 76 0 0 10 30

🟢 2025-04-29 14:20:09 UTC Build successful.
🟢 2025-04-29 14:20:33 UTC ydbd size 2.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 27683ed merge: 796dfa6 diff diff %
ydbd size 2 343 136 040 Bytes 2 343 136 040 Bytes 0 Bytes 0.000%
ydbd stripped size 492 684 672 Bytes 492 684 672 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 11:49:50 UTC Pre-commit check linux-x86_64-release-asan for 796dfa6 has started.
⚪ 2025-04-29 11:50:01 UTC Artifacts will be uploaded here
⚪ 2025-04-29 11:52:46 UTC ya make is running...
🟡 2025-04-29 13:17:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12837 12697 0 69 47 24

⚪ 2025-04-29 13:18:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 13:51:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
904 (only retried tests) 812 0 46 24 22

⚪ 2025-04-29 13:51:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-29 14:21:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
724 (only retried tests) 625 0 42 35 22

🟢 2025-04-29 14:21:31 UTC Build successful.
🟢 2025-04-29 14:22:04 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 27683ed merge: 796dfa6 diff diff %
ydbd size 4 121 974 424 Bytes 4 121 974 328 Bytes -96 Bytes -0.000%
ydbd stripped size 1 428 829 720 Bytes 1 428 829 656 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) April 29, 2025 16:01
@nikvas0 nikvas0 merged commit a1290ef into ydb-platform:main Apr 30, 2025
14 checks passed
nikvas0 added a commit to nikvas0/ydb that referenced this pull request May 7, 2025
@nikvas0
Fix hasRead for sink (ydb-platform#17844)
d9cf8c6
@nikvas0 nikvas0 mentioned this pull request May 12, 2025
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pnv1 pnv1 pnv1 approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikvas0 @pnv1 @gridnevvvit