Skip to content

Check locks before commit #17858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikvas0 merged 3 commits into from
Apr 30, 2025
Merged

Check locks before commit #17858

nikvas0 merged 3 commits into from
Apr 30, 2025

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Apr 29, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Check locks before commit

@nikvas0 nikvas0 requested a review from a team as a code owner April 29, 2025 11:43
@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 11:44:38 UTC Pre-commit check linux-x86_64-release-asan for 96137c6 has started.
⚪ 2025-04-29 11:44:48 UTC Artifacts will be uploaded here
⚪ 2025-04-29 11:47:37 UTC ya make is running...
🟡 2025-04-29 13:10:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12871 12672 0 112 62 25

⚪ 2025-04-29 13:11:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 13:38:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
952 (only retried tests) 842 0 66 20 24

⚪ 2025-04-29 13:38:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-29 14:04:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
752 (only retried tests) 646 0 62 22 22

🟢 2025-04-29 14:04:36 UTC Build successful.
🟢 2025-04-29 14:05:08 UTC ydbd size 3.8 GiB changed* by +9.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 27683ed merge: 96137c6 diff diff %
ydbd size 4 121 974 424 Bytes 4 121 983 848 Bytes +9.2 KiB +0.000%
ydbd stripped size 1 428 829 720 Bytes 1 428 832 152 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 11:44:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 96137c6 has started.
⚪ 2025-04-29 11:44:50 UTC Artifacts will be uploaded here
⚪ 2025-04-29 11:47:46 UTC ya make is running...
🟡 2025-04-29 12:58:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20630 19241 0 22 1328 39

⚪ 2025-04-29 13:00:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 13:30:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 116 0 20 0 35

⚪ 2025-04-29 13:30:10 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-29 13:49:24 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 90 0 19 4 32

🟢 2025-04-29 13:49:31 UTC Build successful.
🟢 2025-04-29 13:49:57 UTC ydbd size 2.2 GiB changed* by +5.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 27683ed merge: 96137c6 diff diff %
ydbd size 2 343 136 040 Bytes 2 343 141 240 Bytes +5.1 KiB +0.000%
ydbd stripped size 492 684 672 Bytes 492 685 632 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

🟢 2025-04-29 14:41:19 UTC The validation of the Pull Request description is successful.

@nikvas0 nikvas0 changed the title Add asserts for locks Add check locks before commit Apr 29, 2025
@nikvas0 nikvas0 changed the title Add check locks before commit Check locks before commit Apr 29, 2025
@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 14:12:27 UTC Pre-commit check linux-x86_64-release-asan for 4f226ad has started.
⚪ 2025-04-29 14:12:38 UTC Artifacts will be uploaded here
⚪ 2025-04-29 14:15:22 UTC ya make is running...
🟡 2025-04-29 15:36:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12870 12618 0 185 44 23

⚪ 2025-04-29 15:37:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 16:02:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
985 (only retried tests) 874 0 65 24 22

⚪ 2025-04-29 16:02:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-29 16:33:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
682 (only retried tests) 571 0 61 28 22

🟢 2025-04-29 16:33:53 UTC Build successful.
🟢 2025-04-29 16:34:23 UTC ydbd size 3.8 GiB changed* by +22.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5c0d6ac merge: 4f226ad diff diff %
ydbd size 4 121 989 840 Bytes 4 122 012 392 Bytes +22.0 KiB +0.001%
ydbd stripped size 1 428 835 032 Bytes 1 428 841 208 Bytes +6.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

⚪ 2025-04-29 14:12:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4f226ad has started.
⚪ 2025-04-29 14:12:50 UTC Artifacts will be uploaded here
⚪ 2025-04-29 14:15:42 UTC ya make is running...
🟡 2025-04-29 15:20:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20631 19085 0 22 1486 38

⚪ 2025-04-29 15:21:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-29 15:49:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
383 (only retried tests) 258 0 19 76 30

⚪ 2025-04-29 15:49:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-29 16:14:36 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 79 0 19 6 31

🟢 2025-04-29 16:14:43 UTC Build successful.
🟢 2025-04-29 16:15:03 UTC ydbd size 2.2 GiB changed* by +12.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5c0d6ac merge: 4f226ad diff diff %
ydbd size 2 343 142 952 Bytes 2 343 155 272 Bytes +12.0 KiB +0.001%
ydbd stripped size 492 686 400 Bytes 492 688 704 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

⚪ 2025-04-30 09:29:55 UTC Pre-commit check linux-x86_64-release-asan for 7ce8191 has started.
⚪ 2025-04-30 09:30:06 UTC Artifacts will be uploaded here
⚪ 2025-04-30 09:33:03 UTC ya make is running...
🟡 2025-04-30 11:22:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12874 12701 0 109 43 21

⚪ 2025-04-30 11:23:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-30 11:50:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1168 (only retried tests) 1068 0 53 27 20

⚪ 2025-04-30 11:50:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-30 12:16:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
769 (only retried tests) 650 0 70 28 21

🟢 2025-04-30 12:16:59 UTC Build successful.
🟡 2025-04-30 12:17:34 UTC ydbd size 3.8 GiB changed* by +184.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fdc10e3 merge: 7ce8191 diff diff %
ydbd size 4 122 034 096 Bytes 4 122 222 920 Bytes +184.4 KiB +0.005%
ydbd stripped size 1 428 848 600 Bytes 1 428 909 240 Bytes +59.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

⚪ 2025-04-30 09:47:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ce8191 has started.
⚪ 2025-04-30 09:47:46 UTC Artifacts will be uploaded here
⚪ 2025-04-30 09:50:30 UTC ya make is running...
🟡 2025-04-30 11:28:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20634 19271 0 2 1322 39

⚪ 2025-04-30 11:29:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-30 11:44:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 97 0 1 0 30

⚪ 2025-04-30 11:44:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-30 12:09:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 81 0 0 0 28

🟢 2025-04-30 12:09:13 UTC Build successful.
🟢 2025-04-30 12:09:42 UTC ydbd size 2.2 GiB changed* by +94.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fdc10e3 merge: 7ce8191 diff diff %
ydbd size 2 343 152 640 Bytes 2 343 248 856 Bytes +94.0 KiB +0.004%
ydbd stripped size 492 687 552 Bytes 492 710 976 Bytes +22.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit d6c53af into ydb-platform:main Apr 30, 2025
14 checks passed
@snaury snaury mentioned this pull request May 6, 2025
Closed
nikvas0 added a commit to nikvas0/ydb that referenced this pull request May 7, 2025
@nikvas0
Check locks before commit (ydb-platform#17858)
b24b071
@nikvas0 nikvas0 mentioned this pull request May 12, 2025
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikvas0 @gridnevvvit