Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Apr 30, 2025

Changelog entry

Issue #17915

The PQ tablet forgets about the transaction only after it receives a TEvReadSetAck from all participants. Another shard may be deleted before the PQ completes the transaction (for example, due to a split table). As a result, transactions are executed, but remain in the WAIT_RS_ACKS state.

If the PQ tablet sends a TEvReadSet to a tablet that has already been deleted, it receives a TEvClientConnected with the Dead flag in response. In this case, we consider that we have received a TEvReadSetAck.

Changelog category

  • Bugfix

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner April 30, 2025 12:16
@Alek5andr-Kotov Alek5andr-Kotov requested a review from qyryq April 30, 2025 12:16
@github-actions github-actions bot added bugfix and removed bugfix labels Apr 30, 2025
@Alek5andr-Kotov Alek5andr-Kotov changed the title LOGBROKER-9650 Don't wait for TEvReadSetAck from non-existent tablets Apr 30, 2025
@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) April 30, 2025 12:25
@github-actions github-actions bot added bugfix and removed bugfix labels Apr 30, 2025
@github-actions
Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 12:26:42 UTC Pre-commit check linux-x86_64-release-asan for 92ecb54 has started.
2025-04-30 12:27:10 UTC Artifacts will be uploaded here
2025-04-30 12:30:35 UTC ya make is running...
🟡 2025-04-30 13:56:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12844 12706 0 77 38 23

2025-04-30 13:57:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-30 14:26:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
979 (only retried tests) 870 0 52 35 22

2025-04-30 14:26:40 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-30 14:53:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
796 (only retried tests) 700 0 49 27 20

🟢 2025-04-30 14:53:33 UTC Build successful.
🟢 2025-04-30 14:54:02 UTC ydbd size 3.8 GiB changed* by +20.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9c0e538 merge: 92ecb54 diff diff %
ydbd size 4 122 199 576 Bytes 4 122 220 104 Bytes +20.0 KiB +0.000%
ydbd stripped size 1 428 899 736 Bytes 1 428 909 464 Bytes +9.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

🟢 2025-04-30 12:35:03 UTC The validation of the Pull Request description is successful.

@github-actions github-actions bot added bugfix and removed bugfix labels Apr 30, 2025
@github-actions
Copy link

github-actions bot commented Apr 30, 2025

2025-05-05 07:49:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 92ecb54 has started.
2025-05-05 07:49:51 UTC Artifacts will be uploaded here
2025-05-05 07:53:30 UTC ya make is running...
🟡 2025-05-05 08:56:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20609 19245 0 7 1324 33

2025-05-05 08:57:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-05 09:32:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 92 0 0 8 30

🟢 2025-05-05 09:32:23 UTC Build successful.
🟢 2025-05-05 09:32:41 UTC ydbd size 2.2 GiB changed* by +9.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7e2dece merge: 92ecb54 diff diff %
ydbd size 2 343 243 016 Bytes 2 343 252 208 Bytes +9.0 KiB +0.000%
ydbd stripped size 492 710 528 Bytes 492 713 152 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 06defc0 into ydb-platform:main May 5, 2025
31 of 33 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request May 5, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request May 5, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request May 5, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request May 5, 2025
Alek5andr-Kotov added a commit that referenced this pull request May 5, 2025
Don't wait for TEvReadSetAck from non-existent tablets (#17913)
Alek5andr-Kotov added a commit that referenced this pull request May 5, 2025
Don't wait for TEvReadSetAck from non-existent tablets (#17913)
Alek5andr-Kotov added a commit that referenced this pull request May 5, 2025
Don't wait for TEvReadSetAck from non-existent tablets (#17913)
Alek5andr-Kotov added a commit that referenced this pull request May 5, 2025
Don't wait for TEvReadSetAck from non-existent tablets (#17913)
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants