Skip to content

Add BSController settings to config.yaml #17957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SammyVimes merged 6 commits into from
May 16, 2025
Merged

Add BSController settings to config.yaml #17957

SammyVimes merged 6 commits into from
May 16, 2025

Conversation

@SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented May 1, 2025 •
edited
Loading

Changelog entry

This PR adds BS Controller settings to config.yaml
Example:

blob_storage_config:
  bsc_settings:
    enable_self_heal: false

Changelog category

  • Experimental feature

Description for reviewers

...

@SammyVimes SammyVimes requested a review from Copilot May 1, 2025 20:45

This comment was marked as outdated.

Sign in to view

@github-actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

🟢 2025-05-13 12:11:25 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

⚪ 2025-05-01 20:48:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 96ce919 has started.
⚪ 2025-05-01 20:49:02 UTC Artifacts will be uploaded here
⚪ 2025-05-01 20:51:47 UTC ya make is running...
🟡 2025-05-01 21:57:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21004 19633 0 5 1324 42

⚪ 2025-05-01 21:59:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-01 22:11:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
262 (only retried tests) 229 0 1 0 32

⚪ 2025-05-01 22:11:58 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-01 22:35:26 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
157 (only retried tests) 118 0 1 8 30

🟢 2025-05-01 22:35:33 UTC Build successful.
🟢 2025-05-01 22:35:56 UTC ydbd size 2.2 GiB changed* by +75.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: aee1801 merge: 96ce919 diff diff %
ydbd size 2 343 424 792 Bytes 2 343 502 328 Bytes +75.7 KiB +0.003%
ydbd stripped size 492 747 328 Bytes 492 758 208 Bytes +10.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

⚪ 2025-05-01 20:49:15 UTC Pre-commit check linux-x86_64-release-asan for 96ce919 has started.
⚪ 2025-05-01 20:49:26 UTC Artifacts will be uploaded here
⚪ 2025-05-01 20:52:16 UTC ya make is running...
🟡 2025-05-01 22:20:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13213 12986 0 160 43 24

⚪ 2025-05-01 22:21:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-01 22:48:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1039 (only retried tests) 927 0 53 35 24

⚪ 2025-05-01 22:48:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-01 23:15:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
795 (only retried tests) 700 0 50 21 24

🟢 2025-05-01 23:15:35 UTC Build successful.
🟡 2025-05-01 23:16:09 UTC ydbd size 3.8 GiB changed* by +129.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: aee1801 merge: 96ce919 diff diff %
ydbd size 4 122 518 920 Bytes 4 122 651 808 Bytes +129.8 KiB +0.003%
ydbd stripped size 1 429 003 480 Bytes 1 429 059 128 Bytes +54.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydb-platform ydb-platform deleted a comment from Copilot AI May 2, 2025
@ydb-platform ydb-platform deleted a comment from Copilot AI May 2, 2025
@ydb-platform ydb-platform deleted a comment from Copilot AI May 2, 2025
@github-actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

⚪ 2025-05-02 09:28:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3fa7a1d has started.
⚪ 2025-05-02 09:28:16 UTC Artifacts will be uploaded here
⚪ 2025-05-02 09:31:12 UTC ya make is running...
🟡 2025-05-02 10:42:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21004 19638 0 4 1324 38

⚪ 2025-05-02 10:43:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-02 11:14:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 100 0 2 0 29

⚪ 2025-05-02 11:14:50 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-02 11:38:13 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 85 0 1 0 31

🟢 2025-05-02 11:38:20 UTC Build successful.
🟢 2025-05-02 11:38:41 UTC ydbd size 2.2 GiB changed* by +86.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: aee1801 merge: 3fa7a1d diff diff %
ydbd size 2 343 424 792 Bytes 2 343 513 456 Bytes +86.6 KiB +0.004%
ydbd stripped size 492 747 328 Bytes 492 761 984 Bytes +14.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

⚪ 2025-05-02 09:28:19 UTC Pre-commit check linux-x86_64-release-asan for 3fa7a1d has started.
⚪ 2025-05-02 09:28:33 UTC Artifacts will be uploaded here
⚪ 2025-05-02 09:31:27 UTC ya make is running...
🟡 2025-05-02 10:57:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13213 13032 0 108 47 26

⚪ 2025-05-02 10:58:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-02 11:29:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1030 (only retried tests) 915 0 64 28 23

⚪ 2025-05-02 11:29:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-02 11:55:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
845 (only retried tests) 745 0 52 24 24

🟢 2025-05-02 11:55:45 UTC Build successful.
🟡 2025-05-02 11:56:20 UTC ydbd size 3.8 GiB changed* by +135.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: aee1801 merge: 3fa7a1d diff diff %
ydbd size 4 122 518 920 Bytes 4 122 657 312 Bytes +135.1 KiB +0.003%
ydbd stripped size 1 429 003 480 Bytes 1 429 060 472 Bytes +55.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

⚪ 2025-05-13 12:07:51 UTC Pre-commit check linux-x86_64-release-asan for ddbb227 has started.
⚪ 2025-05-13 12:08:19 UTC Artifacts will be uploaded here
⚪ 2025-05-13 12:12:09 UTC ya make is running...
🟡 2025-05-13 14:21:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14795 14621 0 98 45 31

⚪ 2025-05-13 14:22:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-13 14:58:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1575 (only retried tests) 1441 0 76 30 28

⚪ 2025-05-13 14:59:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-13 15:34:01 UTC ydbd size 3.9 GiB changed* by +209.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 34fb4f1 merge: ddbb227 diff diff %
ydbd size 4 138 092 352 Bytes 4 138 306 408 Bytes +209.0 KiB +0.005%
ydbd stripped size 1 435 960 160 Bytes 1 436 035 520 Bytes +73.6 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

⚪ 2025-05-13 12:08:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for ddbb227 has started.
⚪ 2025-05-13 12:08:54 UTC Artifacts will be uploaded here
⚪ 2025-05-13 12:12:09 UTC ya make is running...
🟡 2025-05-13 14:08:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29817 27134 0 4 2633 46

⚪ 2025-05-13 14:11:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-13 14:36:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
712 (only retried tests) 679 0 1 0 32

⚪ 2025-05-13 14:37:10 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-13 15:01:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 94 0 0 2 33

🟢 2025-05-13 15:01:19 UTC Build successful.
🟡 2025-05-13 15:01:43 UTC ydbd size 2.2 GiB changed* by +223.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f91acf5 merge: ddbb227 diff diff %
ydbd size 2 351 863 296 Bytes 2 352 092 104 Bytes +223.4 KiB +0.010%
ydbd stripped size 494 229 328 Bytes 494 275 696 Bytes +45.3 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@SammyVimes SammyVimes changed the title Add BSController settings to ephemeral part of config.yaml Add BSController settings to config.yaml May 13, 2025
@github-actions
Copy link

github-actions bot commented May 15, 2025 •
edited
Loading

⚪ 2025-05-15 14:05:43 UTC Pre-commit check linux-x86_64-release-asan for 057f7d2 has started.
⚪ 2025-05-15 14:06:13 UTC Artifacts will be uploaded here
⚪ 2025-05-15 14:10:07 UTC ya make is running...
🔴 2025-05-15 14:52:43 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented May 15, 2025 •
edited
Loading

⚪ 2025-05-15 15:33:48 UTC Pre-commit check linux-x86_64-release-asan for 92aca01 has started.
⚪ 2025-05-15 15:34:17 UTC Artifacts will be uploaded here
⚪ 2025-05-15 15:37:51 UTC ya make is running...
🟡 2025-05-15 17:03:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14854 14699 0 94 33 28

⚪ 2025-05-15 17:04:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-15 17:40:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1534 (only retried tests) 1378 0 79 50 27

⚪ 2025-05-15 17:40:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-15 18:10:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1279 (only retried tests) 1127 0 74 54 24

🟢 2025-05-15 18:11:03 UTC Build successful.
🟡 2025-05-15 18:11:38 UTC ydbd size 3.9 GiB changed* by +296.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 386cc57 merge: 92aca01 diff diff %
ydbd size 4 139 063 240 Bytes 4 139 366 944 Bytes +296.6 KiB +0.007%
ydbd stripped size 1 436 932 696 Bytes 1 437 051 448 Bytes +116.0 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 15, 2025 •
edited
Loading

⚪ 2025-05-15 16:40:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 92aca01 has started.
⚪ 2025-05-15 16:41:12 UTC Artifacts will be uploaded here
⚪ 2025-05-15 16:44:26 UTC ya make is running...
🟡 2025-05-15 18:41:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29909 27228 0 5 2640 36

⚪ 2025-05-15 18:43:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-15 19:10:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
263 (only retried tests) 228 0 0 2 33

🟢 2025-05-15 19:10:41 UTC Build successful.
🟡 2025-05-15 19:11:03 UTC ydbd size 2.2 GiB changed* by +133.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 64ff474 merge: 92aca01 diff diff %
ydbd size 2 352 548 368 Bytes 2 352 685 184 Bytes +133.6 KiB +0.006%
ydbd stripped size 494 527 744 Bytes 494 564 608 Bytes +36.0 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@SammyVimes SammyVimes requested a review from alexvru May 16, 2025 11:45
va-kuznecov
va-kuznecov reviewed May 16, 2025
View reviewed changes
Copy link
Member

@va-kuznecov va-kuznecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SammyVimes SammyVimes merged commit fce269a into ydb-platform:main May 16, 2025
13 checks passed
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 20, 2025
@SammyVimes @nshestakov
Add BSController settings to config.yaml (ydb-platform#17957)
83d2561
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@SammyVimes
Add BSController settings to config.yaml (ydb-platform#17957)
4371641
UgnineSirdis pushed a commit that referenced this pull request Jun 8, 2025
@SammyVimes @UgnineSirdis
Add BSController settings to config.yaml (#17957)
5cba89a 
(cherry picked from commit fce269a)
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@va-kuznecov va-kuznecov va-kuznecov left review comments

Copilot code review Copilot Copilot left review comments

@alexvru alexvru alexvru approved these changes

Assignees

No one assigned

Labels

experimental-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SammyVimes @va-kuznecov @alexvru