Skip to content

KIKIMR-21403: add followers support for secondary indexes #17965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azevaykin merged 9 commits into from
May 6, 2025
Merged

KIKIMR-21403: add followers support for secondary indexes #17965

azevaykin merged 9 commits into from
May 6, 2025

Conversation

@raydzast
Copy link
Contributor

@raydzast raydzast commented May 2, 2025 •
edited
Loading

Changelog entry

Add ability to enable followers (read replicas) for secondary indexes

Changelog category

  • New feature

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented May 2, 2025

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@github-actions
Copy link

github-actions bot commented May 2, 2025 •
edited
Loading

🟢 2025-05-02 20:56:38 UTC The validation of the Pull Request description is successful.

@azevaykin azevaykin marked this pull request as ready for review May 3, 2025 08:54
@azevaykin azevaykin requested review from a team as code owners May 3, 2025 08:54
@azevaykin azevaykin requested review from gridnevvvit, ijon and pnv1 May 3, 2025 08:54
@azevaykin azevaykin added the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 3, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 3, 2025
@github-actions
Copy link

github-actions bot commented May 3, 2025 •
edited
Loading

⚪ 2025-05-03 08:58:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 627a9d3 has started.
⚪ 2025-05-03 08:59:00 UTC Artifacts will be uploaded here
⚪ 2025-05-03 09:02:20 UTC ya make is running...
🟡 2025-05-03 10:52:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30232 27550 0 6 2641 35

⚪ 2025-05-03 10:55:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-03 11:18:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
149 (only retried tests) 116 0 1 2 30

⚪ 2025-05-03 11:18:24 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-03 11:33:33 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 79 0 2 0 28

🟢 2025-05-03 11:33:40 UTC Build successful.
🟡 2025-05-03 11:34:01 UTC ydbd size 2.2 GiB changed* by +146.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 726e4fe merge: 627a9d3 diff diff %
ydbd size 2 343 427 480 Bytes 2 343 577 272 Bytes +146.3 KiB +0.006%
ydbd stripped size 492 746 560 Bytes 492 754 432 Bytes +7.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 3, 2025 •
edited
Loading

⚪ 2025-05-03 08:59:09 UTC Pre-commit check linux-x86_64-release-asan for 627a9d3 has started.
⚪ 2025-05-03 08:59:20 UTC Artifacts will be uploaded here
⚪ 2025-05-03 09:02:32 UTC ya make is running...
🟡 2025-05-03 11:03:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15406 15226 0 109 44 27

⚪ 2025-05-03 11:04:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-03 11:29:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
907 (only retried tests) 810 0 51 23 23

⚪ 2025-05-03 11:29:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-03 11:56:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
837 (only retried tests) 736 0 47 33 21

🟢 2025-05-03 11:56:41 UTC Build successful.
🟡 2025-05-03 11:57:11 UTC ydbd size 3.8 GiB changed* by +222.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 726e4fe merge: 627a9d3 diff diff %
ydbd size 4 122 527 288 Bytes 4 122 754 712 Bytes +222.1 KiB +0.006%
ydbd stripped size 1 429 008 088 Bytes 1 429 038 488 Bytes +29.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin added the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 3, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 3, 2025
@github-actions
Copy link

github-actions bot commented May 3, 2025 •
edited
Loading

⚪ 2025-05-03 13:14:03 UTC Pre-commit check linux-x86_64-release-asan for 01455c2 has started.
⚪ 2025-05-03 13:14:13 UTC Artifacts will be uploaded here
⚪ 2025-05-03 13:17:31 UTC ya make is running...
🟡 2025-05-03 14:43:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15406 15288 0 61 34 23

⚪ 2025-05-03 14:44:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-03 15:14:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
958 (only retried tests) 853 0 46 37 22

⚪ 2025-05-03 15:14:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-03 15:41:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
728 (only retried tests) 639 0 46 22 21

🟢 2025-05-03 15:41:36 UTC Build successful.
🟡 2025-05-03 15:42:05 UTC ydbd size 3.8 GiB changed* by +222.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 726e4fe merge: 01455c2 diff diff %
ydbd size 4 122 527 288 Bytes 4 122 754 712 Bytes +222.1 KiB +0.006%
ydbd stripped size 1 429 008 088 Bytes 1 429 038 488 Bytes +29.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 3, 2025 •
edited
Loading

⚪ 2025-05-03 13:14:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 01455c2 has started.
⚪ 2025-05-03 13:14:19 UTC Artifacts will be uploaded here
⚪ 2025-05-03 13:17:43 UTC ya make is running...
🟡 2025-05-03 14:28:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30232 27561 0 3 2631 37

⚪ 2025-05-03 14:30:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-03 14:54:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 101 0 0 0 35

🟢 2025-05-03 14:54:46 UTC Build successful.
🟡 2025-05-03 14:55:07 UTC ydbd size 2.2 GiB changed* by +146.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 726e4fe merge: 01455c2 diff diff %
ydbd size 2 343 427 480 Bytes 2 343 577 272 Bytes +146.3 KiB +0.006%
ydbd stripped size 492 746 560 Bytes 492 754 432 Bytes +7.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

pnv1
pnv1 previously approved these changes May 5, 2025
View reviewed changes
@azevaykin azevaykin self-assigned this May 5, 2025
ijon
ijon previously approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator

@ijon ijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schemeshard ok

gridnevvvit
gridnevvvit reviewed May 5, 2025
View reviewed changes
@raydzast raydzast dismissed stale reviews from ijon and pnv1 via 6fb7d19 May 5, 2025 11:25
@azevaykin azevaykin added the rebase-and-check Rebase PR with the current base branch and check label May 5, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 5, 2025
@naspirato naspirato added the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 5, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 5, 2025
@github-actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

⚪ 2025-05-05 14:38:31 UTC Pre-commit check linux-x86_64-release-asan for 103f40c has started.
⚪ 2025-05-05 14:38:42 UTC Artifacts will be uploaded here
⚪ 2025-05-05 14:42:05 UTC ya make is running...
🟡 2025-05-05 16:48:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15406 15217 0 117 44 28

⚪ 2025-05-05 16:49:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 17:19:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
895 (only retried tests) 796 0 48 24 27

⚪ 2025-05-05 17:20:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-05 17:46:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
835 (only retried tests) 737 0 48 24 26

🟢 2025-05-05 17:47:00 UTC Build successful.
🟢 2025-05-05 17:47:33 UTC ydbd size 3.8 GiB changed* by +34.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b42804d merge: 103f40c diff diff %
ydbd size 4 126 493 152 Bytes 4 126 528 080 Bytes +34.1 KiB +0.001%
ydbd stripped size 1 433 271 064 Bytes 1 433 279 192 Bytes +7.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

⚪ 2025-05-05 14:38:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 103f40c has started.
⚪ 2025-05-05 14:38:44 UTC Artifacts will be uploaded here
⚪ 2025-05-05 14:41:59 UTC ya make is running...
🟡 2025-05-05 16:33:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30235 27535 0 6 2652 42

⚪ 2025-05-05 16:35:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-05 17:01:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1003 (only retried tests) 968 0 0 2 33

🟢 2025-05-05 17:01:52 UTC Build successful.
🟢 2025-05-05 17:02:13 UTC ydbd size 2.2 GiB changed* by +17.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b42804d merge: 103f40c diff diff %
ydbd size 2 343 360 000 Bytes 2 343 378 088 Bytes +17.7 KiB +0.001%
ydbd stripped size 493 066 240 Bytes 493 068 480 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit 0f55ef2 into ydb-platform:main May 6, 2025
27 checks passed
@azevaykin azevaykin mentioned this pull request May 22, 2025
Closed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Jun 4, 2025
@raydzast @azevaykin
Followers support for secondary indexes (ydb-platform#17965)
7435c72
azevaykin added a commit that referenced this pull request Jun 5, 2025
@azevaykin
25-1: add followers support for secondary indexes (#17965) (#19310)
ab10810
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
@liruoko liruoko added the release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn" label Oct 13, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijon ijon ijon approved these changes

@pnv1 pnv1 pnv1 approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

@azevaykin azevaykin

Labels

changelog/f25-3 PR участвует в списке изменений external new-feature release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@raydzast @ijon @pnv1 @gridnevvvit @liruoko @naspirato @azevaykin