Skip to content

Conversation

@a-serebryanskiy
Copy link
Collaborator

@a-serebryanskiy a-serebryanskiy commented May 7, 2025

Changelog entry

Moved changes from: #18079

Issue: #18116

This PR fixes optimisation in NKikimr::NRawSocket::TBufferedWriter, that wrote the entire message directly to socket if message was larger than available space in buffer. When we wrote more than 6mb to socket with SSL enabled, it every time returned -11 (WAGAIN).
As a quick fix, we replace sending of an entire message to socket with cutting this message into 1mb chunks and sending them to socket one by one.

Changelog category

  • Bugfix

Description for reviewers

...

Co-authored-by: Nikolay Shestakov <n.shestakov@gmail.com>
@a-serebryanskiy a-serebryanskiy requested a review from a team as a code owner May 7, 2025 08:48
@github-actions
Copy link

github-actions bot commented May 7, 2025

🟢 2025-05-07 09:38:48 UTC The validation of the Pull Request description is successful.

@a-serebryanskiy a-serebryanskiy changed the title fix sending big messages (#18079) Fix reading big messages in Kafka Proxy (from #18079) May 7, 2025
maximyurchuk
maximyurchuk previously approved these changes May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

2025-05-07 12:09:50 UTC Pre-commit check linux-x86_64-release-asan for c702696 has started.
2025-05-07 12:10:23 UTC Artifacts will be uploaded here
2025-05-07 12:13:51 UTC ya make is running...
🟡 2025-05-07 13:27:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13696 13531 0 61 70 34

2025-05-07 13:28:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-07 13:48:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 119 0 7 48 32

2025-05-07 13:48:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-07 14:09:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 33 0 7 41 33

🟢 2025-05-07 14:09:21 UTC Build successful.
🟢 2025-05-07 14:09:51 UTC ydbd size 3.6 GiB changed* by -17.8 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 1523d35 merge: c702696 diff diff %
ydbd size 3 911 204 256 Bytes 3 911 186 080 Bytes -17.8 KiB -0.000%
ydbd stripped size 1 368 049 104 Bytes 1 368 052 048 Bytes +2.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@a-serebryanskiy a-serebryanskiy enabled auto-merge May 7, 2025 12:16
@github-actions
Copy link

github-actions bot commented May 7, 2025

2025-05-07 12:20:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for c702696 has started.
2025-05-07 12:20:31 UTC Artifacts will be uploaded here
2025-05-07 12:23:21 UTC ya make is running...
🟡 2025-05-07 13:24:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20735 19456 0 3 1212 64

2025-05-07 13:26:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-07 13:46:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
132 (only retried tests) 68 0 0 6 58

🟢 2025-05-07 13:46:50 UTC Build successful.
🟢 2025-05-07 13:47:10 UTC ydbd size 2.1 GiB changed* by -17.9 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 1523d35 merge: c702696 diff diff %
ydbd size 2 248 485 552 Bytes 2 248 467 256 Bytes -17.9 KiB -0.001%
ydbd stripped size 475 855 800 Bytes 475 854 456 Bytes -1.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@a-serebryanskiy a-serebryanskiy merged commit d9cb943 into ydb-platform:stable-25-1 May 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants