Skip to content

Conversation

@serbel324
Copy link
Collaborator

@serbel324 serbel324 commented May 14, 2025

Changelog entry

Previously replication didn't handle StatusFlags from PDisk properly and didn't stop when available space was running low. Because of this, space was consumed until VDisk and corresponding storage group became read-only. With this change, replication will postpone on YELLOW_STOP color flag and resume after a certain delay if enough space is available. (#17418)

#13608

Changelog category

  • Bugfix

@serbel324 serbel324 requested a review from a team as a code owner May 14, 2025 10:58
@github-actions
Copy link

github-actions bot commented May 14, 2025

🟢 2025-05-15 09:25:32 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:31:03 UTC Pre-commit check linux-x86_64-release-asan for c1180ff has started.
2025-05-14 11:31:35 UTC Artifacts will be uploaded here
2025-05-14 11:35:07 UTC ya make is running...
🟡 2025-05-14 12:49:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12607 12434 0 82 56 35

2025-05-14 12:50:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 13:11:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 134 0 8 44 32

2025-05-14 13:11:18 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-14 13:31:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 42 0 7 32 31

🟢 2025-05-14 13:31:53 UTC Build successful.
🟡 2025-05-14 13:32:22 UTC ydbd size 3.6 GiB changed* by +178.3 KiB, which is >= 100.0 KiB vs stable-25-1: Warning

ydbd size dash stable-25-1: fd5ab83 merge: c1180ff diff diff %
ydbd size 3 912 237 872 Bytes 3 912 420 440 Bytes +178.3 KiB +0.005%
ydbd stripped size 1 368 326 000 Bytes 1 368 385 136 Bytes +57.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 12:08:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for c1180ff has started.
2025-05-14 12:08:49 UTC Artifacts will be uploaded here
2025-05-14 12:12:34 UTC ya make is running...
🟡 2025-05-14 13:19:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19638 18345 0 3 1220 70

2025-05-14 13:21:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 13:41:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
139 (only retried tests) 80 0 1 1 57

2025-05-14 13:42:00 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-14 14:02:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 55 0 0 0 56

🟢 2025-05-14 14:02:29 UTC Build successful.
🟢 2025-05-14 14:02:49 UTC ydbd size 2.1 GiB changed* by +94.4 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: fd5ab83 merge: c1180ff diff diff %
ydbd size 2 248 979 944 Bytes 2 249 076 648 Bytes +94.4 KiB +0.004%
ydbd stripped size 475 951 480 Bytes 475 973 496 Bytes +21.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 changed the title Don't allow replication to overconsume space on PDisk Don't allow replication to overconsume space on PDisk (#17418) May 15, 2025
@serbel324 serbel324 merged commit a3e836e into ydb-platform:stable-25-1 May 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants