Skip to content

Conversation

@serbel324
Copy link
Collaborator

@serbel324 serbel324 commented May 14, 2025

Changelog entry

Don't allow SelfHeal actor to create more than 1 active ReassignerActor. This change will prevent SelfHeal from overloading BSC with ReassignItem requests thus causing DoS. (#17618)

Changelog category

  • Improvement

@serbel324 serbel324 requested a review from a team as a code owner May 14, 2025 11:11
@github-actions
Copy link

github-actions bot commented May 14, 2025

🟢 2025-05-15 09:26:00 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 11:48:24 UTC Pre-commit check linux-x86_64-release-asan for fb5b943 has started.
2025-05-14 11:48:36 UTC Artifacts will be uploaded here
2025-05-14 11:51:27 UTC ya make is running...
🟡 2025-05-14 13:04:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12134 12013 0 39 49 33

2025-05-14 13:05:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 13:25:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
164 (only retried tests) 84 0 8 41 31

2025-05-14 13:25:47 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-14 13:46:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 29 0 8 38 31

🟢 2025-05-14 13:46:25 UTC Build successful.
🟢 2025-05-14 13:46:53 UTC ydbd size 3.6 GiB changed* by +38.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: fd5ab83 merge: fb5b943 diff diff %
ydbd size 3 912 237 872 Bytes 3 912 277 280 Bytes +38.5 KiB +0.001%
ydbd stripped size 1 368 326 000 Bytes 1 368 342 192 Bytes +15.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 12:28:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for fb5b943 has started.
2025-05-14 12:28:56 UTC Artifacts will be uploaded here
2025-05-14 12:31:46 UTC ya make is running...
🟡 2025-05-14 13:26:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19165 17883 0 5 1212 65

2025-05-14 13:28:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 13:49:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 64 0 1 6 57

2025-05-14 13:49:22 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-14 14:10:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 60 0 0 0 56

🟢 2025-05-14 14:10:29 UTC Build successful.
🟢 2025-05-14 14:10:50 UTC ydbd size 2.1 GiB changed* by +26.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: fd5ab83 merge: fb5b943 diff diff %
ydbd size 2 248 979 944 Bytes 2 249 006 704 Bytes +26.1 KiB +0.001%
ydbd stripped size 475 951 480 Bytes 475 959 992 Bytes +8.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 changed the title Limit SelfHeal reassign requests in-flight Limit SelfHeal reassign requests in-flight (#17618) May 15, 2025
@serbel324 serbel324 merged commit a05a0b9 into ydb-platform:stable-25-1 May 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants