Skip to content

Conversation

@nshestakov
Copy link
Collaborator

…the transfer

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nshestakov nshestakov requested a review from a team as a code owner May 14, 2025 12:44
alexnick88
alexnick88 previously approved these changes May 14, 2025
@github-actions
Copy link

🟢 2025-05-14 12:51:10 UTC The validation of the Pull Request description is successful.

CyberROFL
CyberROFL previously approved these changes May 14, 2025
@nshestakov nshestakov enabled auto-merge (squash) May 14, 2025 12:59
@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 13:53:35 UTC Pre-commit check linux-x86_64-release-asan for fc497a1 has started.
2025-05-14 13:54:02 UTC Artifacts will be uploaded here
2025-05-14 13:57:36 UTC ya make is running...
🟡 2025-05-14 15:24:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12767 12531 0 173 36 27

2025-05-14 15:26:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 16:02:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1486 (only retried tests) 1364 0 72 24 26

2025-05-14 16:03:13 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-14 16:37:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1429 (only retried tests) 1278 0 74 53 24

🟢 2025-05-14 16:37:31 UTC Build successful.
🟢 2025-05-14 16:38:06 UTC ydbd size 3.9 GiB changed* by -1.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f43ac6d merge: fc497a1 diff diff %
ydbd size 4 140 076 984 Bytes 4 138 616 456 Bytes -1.4 MiB -0.035%
ydbd stripped size 1 437 128 664 Bytes 1 436 738 616 Bytes -380.9 KiB -0.027%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 14:56:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc497a1 has started.
2025-05-14 14:57:38 UTC Artifacts will be uploaded here
2025-05-14 15:00:56 UTC ya make is running...
🟡 2025-05-14 15:55:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20775 19398 0 7 1335 35

2025-05-14 15:57:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 16:21:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
557 (only retried tests) 525 0 4 0 28

2025-05-14 16:21:23 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-14 16:33:37 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 73 0 4 0 25

🟢 2025-05-14 16:33:44 UTC Build successful.
🟢 2025-05-14 16:34:04 UTC ydbd size 2.2 GiB changed* by -456.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5939f67 merge: fc497a1 diff diff %
ydbd size 2 352 842 088 Bytes 2 352 374 296 Bytes -456.8 KiB -0.020%
ydbd stripped size 494 546 432 Bytes 494 477 920 Bytes -66.9 KiB -0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov dismissed stale reviews from CyberROFL and alexnick88 via 3eb82b1 May 14, 2025 17:32
@nshestakov nshestakov requested a review from a team as a code owner May 14, 2025 17:32
@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 17:34:04 UTC Pre-commit check linux-x86_64-release-asan for 31971fd has started.
2025-05-14 17:34:15 UTC Artifacts will be uploaded here
2025-05-14 17:37:03 UTC ya make is running...
🟡 2025-05-14 19:03:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12772 12608 0 93 42 29

2025-05-14 19:04:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-14 19:39:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1607 (only retried tests) 1474 0 86 19 28

2025-05-14 19:39:47 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-14 20:09:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1194 (only retried tests) 1081 0 69 20 24

🟢 2025-05-14 20:10:09 UTC Build successful.
🟢 2025-05-14 20:10:50 UTC ydbd size 3.9 GiB changed* by -2.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f43ac6d merge: 31971fd diff diff %
ydbd size 4 140 076 984 Bytes 4 137 880 656 Bytes -2.1 MiB -0.053%
ydbd stripped size 1 437 128 664 Bytes 1 436 577 752 Bytes -538.0 KiB -0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 14, 2025

2025-05-14 17:41:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 31971fd has started.
2025-05-14 17:41:37 UTC Artifacts will be uploaded here
2025-05-14 17:44:28 UTC ya make is running...
🟢 2025-05-14 19:00:03 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20785 19394 0 0 1337 54

🟢 2025-05-14 19:01:48 UTC Build successful.
🟢 2025-05-14 19:02:07 UTC ydbd size 2.2 GiB changed* by -910.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9044fce merge: 31971fd diff diff %
ydbd size 2 352 842 152 Bytes 2 351 910 168 Bytes -910.1 KiB -0.040%
ydbd stripped size 494 546 432 Bytes 494 420 928 Bytes -122.6 KiB -0.025%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested a review from CyberROFL May 15, 2025 03:44
const auto result = session.ExecuteSchemeQuery(query).GetValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::GENERIC_ERROR, result.GetIssues().ToString());
UNIT_ASSERT_STRING_CONTAINS(result.GetIssues().ToOneLineString(), "The transfer destination path '/Root/table_not_exists' not found");
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SCHEME_ERROR, result.GetIssues().ToString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На уровне самого трансфера теперь права проверять не надо?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мы это еще не продумали до конца. Просто оказалось, что в облаке не заработает проверка прав в самом трансфере т.к. там нет токена, и как быстрофикс решили сделать пока проверку прав при создании трансфера.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно, наверно, issue завести и прилинковать, что права сейчас проверяются в двух местах. По-любому забудем же.

@nshestakov nshestakov merged commit 91d4a59 into ydb-platform:main May 15, 2025
13 checks passed
@nshestakov nshestakov deleted the TR-permissions-2 branch May 15, 2025 11:31
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants