-
Notifications
You must be signed in to change notification settings - Fork 743
improve vdisk evict swagger and parameters handling #18345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the vdisk evict handling by updating error responses, constructor initialization, and API (Swagger) documentation for parameter handling. Key changes include:
- Replacing legacy error response calls with TBase::ReplyAndPassAway.
- Updating parameter handling by switching from direct params to the member Params.
- Revising the Swagger documentation to mark “vdisk_id” as required and adding the “force” parameter.
Comments suppressed due to low confidence (2)
ydb/core/viewer/vdisk_evict.h:87
- This line appears immediately after a 'return TBase::ReplyAndPassAway(...)', rendering it unreachable. It is recommended to remove the redundant return statement.
return PassAway();
ydb/core/viewer/vdisk_evict.h:169
- The Swagger documentation update marks 'vdisk_id' as required and removes definitions for parameters such as group_id, group_generation_id, fail_realm_idx, fail_domain_idx, and vdisk_idx, which are still expected by the code. Please update the Swagger block to document all required parameters or adjust the code accordingly.
- required: false
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...