Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented May 15, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@adameat adameat requested a review from a team as a code owner May 15, 2025 10:33
@adameat adameat self-assigned this May 15, 2025
@adameat adameat requested a review from Copilot May 15, 2025 10:45
@github-actions
Copy link

🟢 2025-05-15 10:45:30 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the vdisk evict handling by updating error responses, constructor initialization, and API (Swagger) documentation for parameter handling. Key changes include:

  • Replacing legacy error response calls with TBase::ReplyAndPassAway.
  • Updating parameter handling by switching from direct params to the member Params.
  • Revising the Swagger documentation to mark “vdisk_id” as required and adding the “force” parameter.
Comments suppressed due to low confidence (2)

ydb/core/viewer/vdisk_evict.h:87

  • This line appears immediately after a 'return TBase::ReplyAndPassAway(...)', rendering it unreachable. It is recommended to remove the redundant return statement.
return PassAway();

ydb/core/viewer/vdisk_evict.h:169

  • The Swagger documentation update marks 'vdisk_id' as required and removes definitions for parameters such as group_id, group_generation_id, fail_realm_idx, fail_domain_idx, and vdisk_idx, which are still expected by the code. Please update the Swagger block to document all required parameters or adjust the code accordingly.
-                required: false

@adameat adameat enabled auto-merge (squash) May 15, 2025 11:06
@github-actions
Copy link

github-actions bot commented May 15, 2025

2025-05-15 11:39:01 UTC Pre-commit check linux-x86_64-release-asan for 1af63e4 has started.
2025-05-15 11:39:07 UTC Artifacts will be uploaded here
2025-05-15 11:41:59 UTC ya make is running...
🟡 2025-05-15 13:05:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12469 12312 0 97 34 26

2025-05-15 13:06:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-15 13:40:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1318 (only retried tests) 1184 0 84 25 25

2025-05-15 13:41:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-15 14:11:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1268 (only retried tests) 1162 0 62 20 24

🟢 2025-05-15 14:11:56 UTC Build successful.
🟢 2025-05-15 14:12:28 UTC ydbd size 3.9 GiB changed* by -14.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 386cc57 merge: 1af63e4 diff diff %
ydbd size 4 139 063 240 Bytes 4 139 048 280 Bytes -14.6 KiB -0.000%
ydbd stripped size 1 436 932 696 Bytes 1 436 930 360 Bytes -2.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 15, 2025

2025-05-15 12:03:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1af63e4 has started.
2025-05-15 12:03:25 UTC Artifacts will be uploaded here
2025-05-15 12:06:34 UTC ya make is running...
🟡 2025-05-15 13:21:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20257 18880 0 5 1329 43

2025-05-15 13:23:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-15 13:46:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
836 (only retried tests) 795 0 1 5 35

2025-05-15 13:46:35 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-15 14:07:32 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
341 (only retried tests) 301 0 2 3 35

🟢 2025-05-15 14:07:41 UTC Build successful.
🟢 2025-05-15 14:08:20 UTC ydbd size 2.2 GiB changed* by -12.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 386cc57 merge: 1af63e4 diff diff %
ydbd size 2 352 540 536 Bytes 2 352 527 816 Bytes -12.4 KiB -0.001%
ydbd stripped size 494 527 744 Bytes 494 525 376 Bytes -2.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label May 16, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 16, 2025
@github-actions
Copy link

github-actions bot commented May 16, 2025

2025-05-16 05:31:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 399d853 has started.
2025-05-16 05:31:24 UTC Artifacts will be uploaded here
2025-05-16 05:34:15 UTC ya make is running...
🟡 2025-05-16 06:50:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20414 19044 0 5 1326 39

2025-05-16 06:52:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-16 07:15:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
548 (only retried tests) 512 0 0 2 34

🟢 2025-05-16 07:16:07 UTC Build successful.
🟢 2025-05-16 07:16:29 UTC ydbd size 2.2 GiB changed* by -8.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f895e52 merge: 399d853 diff diff %
ydbd size 2 353 165 248 Bytes 2 353 156 872 Bytes -8.2 KiB -0.000%
ydbd stripped size 494 609 544 Bytes 494 604 040 Bytes -5.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 16, 2025

2025-05-16 05:31:17 UTC Pre-commit check linux-x86_64-release-asan for 399d853 has started.
2025-05-16 05:31:27 UTC Artifacts will be uploaded here
2025-05-16 05:34:14 UTC ya make is running...
🟡 2025-05-16 06:58:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12730 12562 0 97 44 27

2025-05-16 06:59:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-16 07:37:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1663 (only retried tests) 1574 0 57 8 24

2025-05-16 07:37:44 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-16 08:05:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1192 (only retried tests) 1095 0 53 20 24

🟢 2025-05-16 08:05:16 UTC Build successful.
🟢 2025-05-16 08:05:47 UTC ydbd size 3.9 GiB changed* by -10.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f895e52 merge: 399d853 diff diff %
ydbd size 4 140 278 592 Bytes 4 140 267 776 Bytes -10.6 KiB -0.000%
ydbd stripped size 1 437 303 288 Bytes 1 437 298 872 Bytes -4.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit 4a8f76c into ydb-platform:main May 16, 2025
19 of 20 checks passed
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants