Skip to content

Conversation

@lex007in
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Retry failed GC requests logic

Without this retries DataCleanup can stuck forever in case of some rare BlobStorage errors

@github-actions
Copy link

github-actions bot commented May 16, 2025

2025-05-16 06:17:33 UTC Pre-commit check linux-x86_64-release-asan for 1b2d193 has started.
2025-05-16 06:18:13 UTC Artifacts will be uploaded here
2025-05-16 06:21:34 UTC ya make is running...
🟡 2025-05-16 07:46:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13925 13805 0 21 65 34

2025-05-16 07:47:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-16 08:07:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 95 0 4 21 33

2025-05-16 08:07:44 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-16 08:27:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
86 (only retried tests) 32 0 4 17 33

🟢 2025-05-16 08:27:48 UTC Build successful.
🟢 2025-05-16 08:28:17 UTC ydbd size 3.6 GiB changed* by +22.5 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 952f40f merge: 1b2d193 diff diff %
ydbd size 3 912 791 248 Bytes 3 912 814 248 Bytes +22.5 KiB +0.001%
ydbd stripped size 1 368 517 168 Bytes 1 368 527 856 Bytes +10.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-05-16 06:19:03 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 16, 2025

2025-05-16 06:19:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1b2d193 has started.
2025-05-16 06:19:30 UTC Artifacts will be uploaded here
2025-05-16 06:22:32 UTC ya make is running...
🟡 2025-05-16 07:43:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27846 25313 0 3 2468 62

2025-05-16 07:45:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-16 08:06:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
138 (only retried tests) 74 0 0 6 58

🟢 2025-05-16 08:06:29 UTC Build successful.
🟢 2025-05-16 08:06:47 UTC ydbd size 2.1 GiB changed* by +10.8 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 952f40f merge: 1b2d193 diff diff %
ydbd size 2 249 269 512 Bytes 2 249 280 608 Bytes +10.8 KiB +0.000%
ydbd stripped size 476 015 672 Bytes 476 017 976 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lex007in lex007in marked this pull request as ready for review May 16, 2025 06:20
@lex007in lex007in requested a review from a team as a code owner May 16, 2025 06:20
@lex007in lex007in enabled auto-merge May 16, 2025 07:03
@lex007in lex007in merged commit 4c383db into ydb-platform:stable-25-1 May 16, 2025
13 checks passed
@lex007in lex007in deleted the gc_retries branch May 16, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants