Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This is the first stage of #10468
I allowed (under a feature flag) alters that add unique index.
KQP gets information about tables and a new code checks if there are unique index in the table that is under construction.
If KQP sees that query modifies such a table, then it fails query compilation.

@github-actions
Copy link

github-actions bot commented May 22, 2025

2025-05-22 11:53:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 67232e7 has started.
2025-05-22 11:54:07 UTC Artifacts will be uploaded here
2025-05-22 11:57:31 UTC ya make is running...
🟡 2025-05-22 13:53:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30348 27668 0 2 2643 35

2025-05-22 13:56:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-22 14:18:43 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 119 0 0 2 32

🟢 2025-05-22 14:18:52 UTC Build successful.
🟢 2025-05-22 14:19:14 UTC ydbd size 2.2 GiB changed* by +13.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d3642d7 merge: 67232e7 diff diff %
ydbd size 2 357 307 584 Bytes 2 357 321 704 Bytes +13.8 KiB +0.001%
ydbd stripped size 495 232 840 Bytes 495 234 248 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 22, 2025

2025-05-22 11:54:41 UTC Pre-commit check linux-x86_64-release-asan for 67232e7 has started.
2025-05-22 11:54:52 UTC Artifacts will be uploaded here
2025-05-22 11:58:05 UTC ya make is running...
🟡 2025-05-22 13:59:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15371 15244 0 66 39 22

2025-05-22 14:00:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-22 14:31:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1190 (only retried tests) 1108 0 43 16 23

2025-05-22 14:31:27 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-22 15:00:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1046 (only retried tests) 948 0 45 32 21

🟢 2025-05-22 15:00:17 UTC Build successful.
🟢 2025-05-22 15:00:57 UTC ydbd size 3.9 GiB changed* by +21.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d3642d7 merge: 67232e7 diff diff %
ydbd size 4 145 614 480 Bytes 4 145 636 728 Bytes +21.7 KiB +0.001%
ydbd stripped size 1 439 221 944 Bytes 1 439 226 680 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 22, 2025

🟢 2025-05-22 12:18:23 UTC The validation of the Pull Request description is successful.

@UgnineSirdis UgnineSirdis changed the title Disable write to unique index Disable write to unique index under construction May 22, 2025
@nikvas0 nikvas0 requested review from azevaykin and removed request for azevaykin May 22, 2025 12:57
@UgnineSirdis UgnineSirdis force-pushed the disable-write-to-unique-index branch from 07e0fb3 to 9248b6f Compare May 26, 2025 22:20
@github-actions
Copy link

github-actions bot commented May 26, 2025

2025-05-26 22:21:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 77e371d has started.
2025-05-26 22:21:54 UTC Artifacts will be uploaded here
2025-05-26 22:25:15 UTC ya make is running...
🟡 2025-05-27 00:17:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30540 27850 0 1 2651 38

2025-05-27 00:19:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-27 00:59:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
602 (only retried tests) 556 0 0 12 34

🟢 2025-05-27 00:59:12 UTC Build successful.
🟡 2025-05-27 00:59:34 UTC ydbd size 2.2 GiB changed* by +956.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 77e371d diff diff %
ydbd size 2 358 248 400 Bytes 2 359 228 064 Bytes +956.7 KiB +0.042%
ydbd stripped size 495 390 920 Bytes 495 581 224 Bytes +185.8 KiB +0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 26, 2025

2025-05-26 22:21:43 UTC Pre-commit check linux-x86_64-release-asan for 77e371d has started.
2025-05-26 22:21:55 UTC Artifacts will be uploaded here
2025-05-26 22:25:17 UTC ya make is running...
🟡 2025-05-27 00:41:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15523 15309 0 105 81 28

2025-05-27 00:42:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-27 01:16:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1576 (only retried tests) 1486 0 46 21 23

2025-05-27 01:16:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-27 01:52:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1085 (only retried tests) 960 0 91 11 23

🟢 2025-05-27 01:53:02 UTC Build successful.
🟡 2025-05-27 01:53:32 UTC ydbd size 3.9 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 77e371d diff diff %
ydbd size 4 147 273 176 Bytes 4 149 057 648 Bytes +1.7 MiB +0.043%
ydbd stripped size 1 440 065 016 Bytes 1 440 571 640 Bytes +494.8 KiB +0.035%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 12:49:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 414e3b5 has started.
2025-05-27 12:49:27 UTC Artifacts will be uploaded here
2025-05-27 12:52:43 UTC ya make is running...
🟡 2025-05-27 14:07:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30540 27842 0 4 2655 39

2025-05-27 14:10:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-27 14:45:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
703 (only retried tests) 674 0 0 0 29

🟢 2025-05-27 14:45:35 UTC Build successful.
🟡 2025-05-27 14:45:51 UTC ydbd size 2.2 GiB changed* by +973.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 414e3b5 diff diff %
ydbd size 2 358 248 400 Bytes 2 359 245 056 Bytes +973.3 KiB +0.042%
ydbd stripped size 495 390 920 Bytes 495 581 480 Bytes +186.1 KiB +0.038%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 09:04:43 UTC Pre-commit check linux-x86_64-release-asan for 414e3b5 has started.
2025-05-27 09:04:49 UTC Artifacts will be uploaded here
2025-05-27 09:08:01 UTC ya make is running...
🟡 2025-05-27 10:54:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15523 15315 0 140 46 22

2025-05-27 10:56:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-27 11:31:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1913 (only retried tests) 1824 0 58 7 24

2025-05-27 11:31:42 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-27 12:01:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1206 (only retried tests) 1107 0 59 19 21

🟢 2025-05-27 12:01:33 UTC Build successful.
🟡 2025-05-27 12:02:17 UTC ydbd size 3.9 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 414e3b5 diff diff %
ydbd size 4 147 273 176 Bytes 4 149 052 296 Bytes +1.7 MiB +0.043%
ydbd stripped size 1 440 065 016 Bytes 1 440 561 048 Bytes +484.4 KiB +0.034%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

NYql::NDq::SetYqlLogLevels(NActors::NLog::PRI_TRACE);
}

GetTestServer().GetRuntime()->SetObserverFunc([this](TAutoPtr<IEventHandle>& event) -> NActors::TTestActorRuntimeBase::EEventAction {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На будущее, у нас есть более удобный способ перехвата сообщений:

class TBlockEvents : public std::deque<typename TEvType::TPtr> {

@UgnineSirdis UgnineSirdis enabled auto-merge (squash) May 27, 2025 11:58
@UgnineSirdis UgnineSirdis merged commit 8fa236d into ydb-platform:main May 27, 2025
16 of 17 checks passed
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@UgnineSirdis UgnineSirdis deleted the disable-write-to-unique-index branch June 29, 2025 09:35
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 22, 2025
UgnineSirdis added a commit that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants