Skip to content

Make Datetime UDF backward compatible for incremental upgrade #18920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igormunkin merged 5 commits into from
Jun 2, 2025
Merged

Make Datetime UDF backward compatible for incremental upgrade #18920

igormunkin merged 5 commits into from
Jun 2, 2025

Conversation

@igormunkin
Copy link
Collaborator

@igormunkin igormunkin commented May 27, 2025 •
edited
Loading

Changelog entry

Temporarily tweak DeclareSignature for Datetime::Format and several typeaware UDFs for the incremental upgrade.

Changelog category

  • Bugfix

Description for reviewers

Relates to #18487

@igormunkin igormunkin self-assigned this May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

⚪ 2025-05-27 16:51:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for bddab19 has started.
⚪ 2025-05-27 16:51:51 UTC Artifacts will be uploaded here
⚪ 2025-05-27 16:54:28 UTC ya make is running...
🔴 2025-05-27 16:57:17 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

⚪ 2025-05-27 16:51:40 UTC Pre-commit check linux-x86_64-release-asan for bddab19 has started.
⚪ 2025-05-27 16:51:51 UTC Artifacts will be uploaded here
⚪ 2025-05-27 16:54:23 UTC ya make is running...
🔴 2025-05-27 16:56:23 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

🟢 2025-05-30 16:18:26 UTC The validation of the Pull Request description is successful.

@igormunkin igormunkin force-pushed the imun/stable-25-1/make-datetime-signatures-compatible-with-24-4 branch from 02cff26 to 68ee1ea Compare May 28, 2025 13:17
@igormunkin igormunkin requested a review from vitstn May 28, 2025 13:19
@github-actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

⚪ 2025-05-28 13:20:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 71a6914 has started.
⚪ 2025-05-28 13:21:09 UTC Artifacts will be uploaded here
⚪ 2025-05-28 13:24:11 UTC ya make is running...
🟡 2025-05-28 14:13:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19177 16672 0 2 2452 51

⚪ 2025-05-28 14:15:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-28 14:35:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 49 0 0 1 51

🟢 2025-05-28 14:35:19 UTC Build successful.
🟢 2025-05-28 14:35:36 UTC ydbd size 2.1 GiB changed* by -6.4 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 8b86cdb merge: 71a6914 diff diff %
ydbd size 2 249 320 056 Bytes 2 249 313 544 Bytes -6.4 KiB -0.000%
ydbd stripped size 476 028 280 Bytes 476 032 440 Bytes +4.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

⚪ 2025-05-28 13:21:08 UTC Pre-commit check linux-x86_64-release-asan for 71a6914 has started.
⚪ 2025-05-28 13:21:19 UTC Artifacts will be uploaded here
⚪ 2025-05-28 13:23:57 UTC ya make is running...
🟡 2025-05-28 14:17:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6145 6042 0 26 50 27

⚪ 2025-05-28 14:18:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-28 14:38:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 59 0 7 39 26

⚪ 2025-05-28 14:38:30 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-28 14:57:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 37 0 7 22 26

🟢 2025-05-28 14:58:01 UTC Build successful.
🟢 2025-05-28 14:58:26 UTC ydbd size 3.6 GiB changed* by -18.3 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: 8b86cdb merge: 71a6914 diff diff %
ydbd size 3 912 905 384 Bytes 3 912 886 664 Bytes -18.3 KiB -0.000%
ydbd stripped size 1 368 555 792 Bytes 1 368 554 192 Bytes -1.6 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin force-pushed the imun/stable-25-1/make-datetime-signatures-compatible-with-24-4 branch from 68ee1ea to 13746c6 Compare May 30, 2025 15:16
@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 15:34:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6ff2ad8 has started.
⚪ 2025-05-30 15:34:28 UTC Artifacts will be uploaded here
⚪ 2025-05-30 15:38:03 UTC ya make is running...
⚫ 2025-05-30 16:09:53 UTC Check cancelled

@igormunkin igormunkin changed the title Tweak DeclareSignature for TFormat class Make Datetime UDF backward compatible May 30, 2025
@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 15:50:46 UTC Pre-commit check linux-x86_64-release-asan for 6ff2ad8 has started.
⚪ 2025-05-30 15:50:59 UTC Artifacts will be uploaded here
⚪ 2025-05-30 15:54:03 UTC ya make is running...
⚫ 2025-05-30 16:09:59 UTC Check cancelled

@igormunkin igormunkin changed the title Make Datetime UDF backward compatible Make Datetime UDF backward compatible for incremental upgrade May 30, 2025
@igormunkin igormunkin force-pushed the imun/stable-25-1/make-datetime-signatures-compatible-with-24-4 branch from b976266 to 32d508b Compare May 30, 2025 16:10
@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 16:16:43 UTC Pre-commit check linux-x86_64-release-asan for 94a2dff has started.
⚪ 2025-05-30 16:17:25 UTC Artifacts will be uploaded here
⚪ 2025-05-30 16:20:51 UTC ya make is running...
⚫ 2025-05-30 16:24:45 UTC Check cancelled

@igormunkin igormunkin force-pushed the imun/stable-25-1/make-datetime-signatures-compatible-with-24-4 branch from 32d508b to ac47d74 Compare May 30, 2025 16:24
@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 16:30:48 UTC Pre-commit check linux-x86_64-release-asan for 3a22695 has started.
⚪ 2025-05-30 16:31:14 UTC Artifacts will be uploaded here
⚪ 2025-05-30 16:34:49 UTC ya make is running...
🟡 2025-05-30 17:48:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12724 12565 0 74 48 37

⚪ 2025-05-30 17:49:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 18:10:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 123 0 13 38 34

⚪ 2025-05-30 18:10:36 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-30 18:31:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 44 0 11 26 32

🟢 2025-05-30 18:31:15 UTC Build successful.
🟡 2025-05-30 18:31:47 UTC ydbd size 3.6 GiB changed* by +148.8 KiB, which is >= 100.0 KiB vs stable-25-1: Warning

ydbd size dash stable-25-1: 75b1be1 merge: 3a22695 diff diff %
ydbd size 3 915 694 240 Bytes 3 915 846 648 Bytes +148.8 KiB +0.004%
ydbd stripped size 1 369 461 232 Bytes 1 369 506 672 Bytes +44.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 17:03:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3a22695 has started.
⚪ 2025-05-30 17:04:13 UTC Artifacts will be uploaded here
⚪ 2025-05-30 17:07:31 UTC ya make is running...
🟡 2025-05-30 18:08:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26662 24143 0 2 2458 59

⚪ 2025-05-30 18:10:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 18:27:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 56 0 1 7 59

⚪ 2025-05-30 18:27:39 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-30 18:47:21 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 56 0 1 6 58

🟢 2025-05-30 18:47:28 UTC Build successful.
🟢 2025-05-30 18:47:47 UTC ydbd size 2.1 GiB changed* by +54.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 75b1be1 merge: 3a22695 diff diff %
ydbd size 2 250 809 696 Bytes 2 250 865 056 Bytes +54.1 KiB +0.002%
ydbd stripped size 476 285 112 Bytes 476 297 592 Bytes +12.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll mentioned this pull request Jun 2, 2025
Merged
@lll-phill-lll lll-phill-lll added the rebase-and-check Rebase PR with the current base branch and check label Jun 2, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

⚪ 2025-06-02 08:36:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ebf9ed has started.
⚪ 2025-06-02 08:36:14 UTC Artifacts will be uploaded here
⚪ 2025-06-02 08:39:15 UTC ya make is running...
⚫ 2025-06-02 08:39:48 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

⚪ 2025-06-02 08:38:38 UTC Pre-commit check linux-x86_64-release-asan for 8ebf9ed has started.
⚪ 2025-06-02 08:38:49 UTC Artifacts will be uploaded here
⚫ 2025-06-02 08:39:46 UTC Check cancelled

@lll-phill-lll lll-phill-lll added the rebase-and-check Rebase PR with the current base branch and check label Jun 2, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

⚪ 2025-06-02 08:41:00 UTC Pre-commit check linux-x86_64-release-asan for 189485d has started.
⚪ 2025-06-02 08:41:04 UTC Artifacts will be uploaded here
⚪ 2025-06-02 08:43:57 UTC ya make is running...
🟡 2025-06-02 09:59:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12726 12542 0 82 66 36

⚪ 2025-06-02 10:00:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-02 10:20:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
241 (only retried tests) 147 0 8 53 33

⚪ 2025-06-02 10:20:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-02 10:40:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
122 (only retried tests) 42 0 7 40 33

🟢 2025-06-02 10:40:57 UTC Build successful.
🟡 2025-06-02 10:41:25 UTC ydbd size 3.6 GiB changed* by +214.3 KiB, which is >= 100.0 KiB vs stable-25-1: Warning

ydbd size dash stable-25-1: 76514f2 merge: 189485d diff diff %
ydbd size 3 915 691 784 Bytes 3 915 911 216 Bytes +214.3 KiB +0.006%
ydbd stripped size 1 369 460 272 Bytes 1 369 541 104 Bytes +78.9 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

⚪ 2025-06-02 08:41:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 189485d has started.
⚪ 2025-06-02 08:41:20 UTC Artifacts will be uploaded here
⚪ 2025-06-02 08:44:20 UTC ya make is running...
🟡 2025-06-02 09:51:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26664 24135 0 4 2464 61

⚪ 2025-06-02 09:53:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-02 10:14:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 76 0 1 2 57

⚪ 2025-06-02 10:14:37 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-02 10:35:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 54 0 0 1 57

🟢 2025-06-02 10:35:21 UTC Build successful.
🟢 2025-06-02 10:35:44 UTC ydbd size 2.1 GiB changed* by +58.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: d0bb904 merge: 189485d diff diff %
ydbd size 2 250 846 400 Bytes 2 250 905 848 Bytes +58.1 KiB +0.003%
ydbd stripped size 476 298 488 Bytes 476 315 064 Bytes +16.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin marked this pull request as ready for review June 2, 2025 08:53
@igormunkin igormunkin requested a review from a team as a code owner June 2, 2025 08:53
@igormunkin igormunkin merged commit 1cf95a5 into ydb-platform:stable-25-1 Jun 2, 2025
21 of 24 checks passed
@igormunkin igormunkin mentioned this pull request Jun 2, 2025
Merged
@igormunkin igormunkin deleted the imun/stable-25-1/make-datetime-signatures-compatible-with-24-4 branch June 2, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitstn vitstn vitstn approved these changes

@maximyurchuk maximyurchuk maximyurchuk approved these changes

@lll-phill-lll lll-phill-lll lll-phill-lll approved these changes

Assignees

@igormunkin igormunkin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igormunkin @vitstn @maximyurchuk @lll-phill-lll