Skip to content

Conversation

@SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented May 27, 2025

Changelog entry

Fixes race condition between YardInit and Slay, removing "phantom vdisks" from pdisks

Changelog category

  • Bugfix

Description for reviewers

...

Fixes #18923

@SammyVimes SammyVimes requested a review from alexvru May 27, 2025 19:12
@github-actions
Copy link

github-actions bot commented May 27, 2025

🟢 2025-05-27 19:33:59 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 19:20:59 UTC Pre-commit check linux-x86_64-release-asan for 8808a85 has started.
2025-05-27 19:21:10 UTC Artifacts will be uploaded here
2025-05-27 19:24:08 UTC ya make is running...
🟡 2025-05-27 21:00:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14150 13971 0 85 71 23

2025-05-27 21:01:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-27 21:34:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1270 (only retried tests) 1109 0 72 70 19

2025-05-27 21:34:50 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-27 22:03:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1127 (only retried tests) 1005 0 65 35 22

🟢 2025-05-27 22:03:27 UTC Build successful.
🔴 2025-05-27 22:03:58 UTC ydbd size 3.9 GiB changed* by +2.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 8808a85 diff diff %
ydbd size 4 147 273 176 Bytes 4 150 125 264 Bytes +2.7 MiB +0.069%
ydbd stripped size 1 440 065 016 Bytes 1 440 801 720 Bytes +719.4 KiB +0.051%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 19:42:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8808a85 has started.
2025-05-27 19:42:55 UTC Artifacts will be uploaded here
2025-05-27 19:45:49 UTC ya make is running...
🟡 2025-05-27 20:55:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22131 20737 0 8 1345 41

2025-05-27 20:57:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-27 21:27:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
347 (only retried tests) 315 0 1 0 31

2025-05-27 21:27:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-27 22:15:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 116 0 0 0 30

🟢 2025-05-27 22:16:01 UTC Build successful.
🟡 2025-05-27 22:16:22 UTC ydbd size 2.2 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d617cc1 merge: 8808a85 diff diff %
ydbd size 2 358 248 400 Bytes 2 359 654 112 Bytes +1.3 MiB +0.060%
ydbd stripped size 495 390 920 Bytes 495 633 704 Bytes +237.1 KiB +0.049%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@SammyVimes SammyVimes merged commit 500541d into ydb-platform:main May 28, 2025
19 of 22 checks passed
SammyVimes added a commit to SammyVimes/ydb that referenced this pull request May 28, 2025
SammyVimes added a commit to SammyVimes/ydb that referenced this pull request May 28, 2025
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
UgnineSirdis pushed a commit that referenced this pull request Jun 8, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition between YardInit and Slay

4 participants