Fix vector_index_build reboots test (#18900) #18953

vitalif · 2025-05-28T13:57:33Z

Changelog category

Not for changelog (changelog entry is not required)

Description for reviewers

The test had multiple problems:

Incorrect data format in the test table
Missing restarts on KMeans**Responses due to killOnCommit == false in the test
Hang when killOnCommit == true on TEvTablet::TEvCommitResult

After fixing these, issues #18236 and #18278 start to be reproduced by this test if you roll back the fixes

github-actions · 2025-05-28T14:00:06Z

🟢 2025-05-28 14:06:50 UTC The validation of the Pull Request description is successful.

github-actions · 2025-05-28T14:00:15Z

⚪ 2025-05-28 14:00:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6c616db has started.
⚪ 2025-05-28 14:00:25 UTC Artifacts will be uploaded here
⚪ 2025-05-28 14:02:47 UTC ya make is running...
🟡 2025-05-28 14:19:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3049	3048	0	1	0	0

⚪ 2025-05-28 14:19:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-28 14:26:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
221 (only retried tests)	221	0	0	0	0

🟢 2025-05-28 14:26:19 UTC Build successful.

github-actions · 2025-05-28T14:00:17Z

⚪ 2025-05-28 14:00:16 UTC Pre-commit check linux-x86_64-release-asan for 6c616db has started.
⚪ 2025-05-28 14:00:28 UTC Artifacts will be uploaded here
⚪ 2025-05-28 14:03:03 UTC ya make is running...
🟡 2025-05-28 14:23:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2060	2035	0	22	3	0

⚪ 2025-05-28 14:23:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-28 14:36:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
367 (only retried tests)	362	0	5	0	0

⚪ 2025-05-28 14:37:00 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-28 14:49:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
226 (only retried tests)	221	0	5	0	0

🟢 2025-05-28 14:50:06 UTC Build successful.

ydb/core/tx/schemeshard/ut_helpers/test_with_reboots.h

CyberROFL · 2025-05-28T16:59:14Z

ydb/core/tx/schemeshard/ut_vector_index_build_reboots/ut_vector_index_build_reboots.cpp

-                    UNIT_ASSERT_VALUES_EQUAL(err, "");
-
-                    //                                   V -- here the null key
-                    NKqp::CompareYson(R"([[[[[["101000"];#];[["100000"];["1000"]];[["100001"];["1001"]];[["100002"];["1002"]];[["100003"];["1003"]];[["100004"];["1004"]];[["100005"];["1005"]];[["100006"];["1006"]];[["100007"];["1007"]];[["100008"];["1008"]];[["100009"];["1009"]];[["101000"];["2000"]];[["101001"];["2001"]];[["101002"];["2002"]];[["101003"];["2003"]];[["101004"];["2004"]];[["101005"];["2005"]];[["101006"];["2006"]];[["101007"];["2007"]];[["101008"];["2008"]];[["101009"];["2009"]]];%false]]])", result);


Почему это стало ненужным?

А это мне кажется и было ненужным. Это какая-то конкретная копипаста из ut_index_build_reboots.cpp, прям дословно взятый кусок кода был (кстати, как и само наполнение таблицы тоже было копипастой). Проверять null не нужно потому, что этого null-а там больше нет - до этого он в minikql writeQuery явным образом вставлялся. Для проверки векторного индекса он не нужен. Ну и в целом не понятно, зачем проверять только что вручную вставленные данные...

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

github-actions · 2025-05-28T17:46:45Z

⚪ 2025-05-28 17:46:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for eba8ba9 has started.
⚪ 2025-05-28 17:46:56 UTC Artifacts will be uploaded here
⚪ 2025-05-28 17:49:21 UTC ya make is running...
🟢 2025-05-28 18:03:39 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3049	3049	0	0	0	0

🟢 2025-05-28 18:04:02 UTC Build successful.

github-actions · 2025-05-28T17:46:45Z

⚪ 2025-05-28 17:46:45 UTC Pre-commit check linux-x86_64-release-asan for eba8ba9 has started.
⚪ 2025-05-28 17:46:56 UTC Artifacts will be uploaded here
⚪ 2025-05-28 17:49:21 UTC ya make is running...
🟡 2025-05-28 18:07:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2060	2021	0	36	3	0

⚪ 2025-05-28 18:08:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-28 18:21:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
257 (only retried tests)	252	0	5	0	0

⚪ 2025-05-28 18:21:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-28 18:34:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
226 (only retried tests)	219	0	7	0	0

🟢 2025-05-28 18:34:11 UTC Build successful.

…m#18953)

Fix vector_index_build reboots test (ydb-platform#18900)

1ab5dd3

vitalif requested a review from a team as a code owner May 28, 2025 13:57

github-actions bot added not-for-changelog and removed not-for-changelog labels May 28, 2025

vitalif linked an issue May 28, 2025 that may be closed by this pull request

Check/fix ut_vector_index_build_reboots test #18900

Closed

vitalif requested a review from kungasc May 28, 2025 14:02

github-actions bot added not-for-changelog and removed not-for-changelog labels May 28, 2025

kungasc previously approved these changes May 28, 2025

View reviewed changes

vitalif requested a review from snaury May 28, 2025 16:15

vitalif enabled auto-merge (squash) May 28, 2025 16:15

CyberROFL reviewed May 28, 2025

View reviewed changes

Update ydb/core/tx/schemeshard/ut_helpers/test_with_reboots.h

eaeec80

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

vitalif dismissed kungasc’s stale review via eaeec80 May 28, 2025 17:45

Update ydb/core/tx/schemeshard/ut_helpers/test_with_reboots.h

be97b28

Co-authored-by: Ilnaz Nizametdinov <i.nizametdinov@gmail.com>

CyberROFL approved these changes May 28, 2025

View reviewed changes

vitalif merged commit d2cfdc8 into ydb-platform:main May 28, 2025
11 checks passed

vitalif removed the request for review from snaury May 29, 2025 11:39

xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025

Fix vector_index_build reboots test (ydb-platform#18900) (ydb-platfor…

083a552

…m#18953)

azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Jun 5, 2025

Fix vector_index_build reboots test (ydb-platform#18900) (ydb-platfor…

30de5db

…m#18953)

StekPerepolnen mentioned this pull request Sep 15, 2025

audit fault stream nb 25 1 #24990

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix vector_index_build reboots test (#18900) #18953

Fix vector_index_build reboots test (#18900) #18953

Uh oh!

vitalif commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

CyberROFL May 28, 2025

Uh oh!

vitalif May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix vector_index_build reboots test (#18900) #18953

Fix vector_index_build reboots test (#18900) #18953

Uh oh!

Conversation

vitalif commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category

Description for reviewers

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CyberROFL May 28, 2025

Choose a reason for hiding this comment

Uh oh!

vitalif May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vitalif commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading

vitalif May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading