Skip to content

Fixed possible crash when commited to recreated topic reader #18978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nshestakov merged 1 commit into from
May 30, 2025
Merged

Fixed possible crash when commited to recreated topic reader #18978

nshestakov merged 1 commit into from
May 30, 2025

Conversation

@nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented May 29, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

#18972

@nshestakov nshestakov requested a review from a team as a code owner May 29, 2025 05:59
@nshestakov nshestakov requested a review from vporyadke May 29, 2025 05:59
@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 06:04:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 357eeba has started.
⚪ 2025-05-29 06:05:19 UTC Artifacts will be uploaded here
⚪ 2025-05-29 06:08:43 UTC ya make is running...
🟡 2025-05-29 07:24:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21704 20328 0 4 1337 35

⚪ 2025-05-29 07:26:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 08:08:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
389 (only retried tests) 355 0 4 0 30

⚪ 2025-05-29 08:08:54 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-29 08:50:37 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
346 (only retried tests) 316 0 3 0 27

🟢 2025-05-29 08:50:45 UTC Build successful.
🔴 2025-05-29 08:51:06 UTC ydbd size 2.2 GiB changed* by +3.9 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 357eeba diff diff %
ydbd size 2 358 248 400 Bytes 2 362 340 456 Bytes +3.9 MiB +0.174%
ydbd stripped size 495 390 920 Bytes 496 017 960 Bytes +612.3 KiB +0.127%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 06:05:19 UTC Pre-commit check linux-x86_64-release-asan for 357eeba has started.
⚪ 2025-05-29 06:05:31 UTC Artifacts will be uploaded here
⚪ 2025-05-29 06:08:29 UTC ya make is running...
🟡 2025-05-29 07:44:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13729 13473 0 158 77 21

⚪ 2025-05-29 07:45:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 08:15:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1298 (only retried tests) 1156 0 65 58 19

⚪ 2025-05-29 08:16:14 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 08:46:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1369 (only retried tests) 1269 0 57 24 19

🟢 2025-05-29 08:46:24 UTC Build successful.
🔴 2025-05-29 08:46:55 UTC ydbd size 3.9 GiB changed* by +7.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 357eeba diff diff %
ydbd size 4 147 273 176 Bytes 4 154 579 848 Bytes +7.0 MiB +0.176%
ydbd stripped size 1 440 065 016 Bytes 1 442 070 712 Bytes +1.9 MiB +0.139%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

🟢 2025-05-29 06:26:30 UTC The validation of the Pull Request description is successful.

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label May 29, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 29, 2025
@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 09:35:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2bb13c9 has started.
⚪ 2025-05-29 09:35:46 UTC Artifacts will be uploaded here
⚪ 2025-05-29 09:38:50 UTC ya make is running...
🟡 2025-05-29 10:46:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21706 20330 0 4 1339 33

⚪ 2025-05-29 10:48:44 UTC ya make is running... (failed tests rerun, try 2)
🔴 2025-05-29 11:25:00 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 2bb13c9 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 413 864 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 024 872 Bytes +619.1 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 09:35:36 UTC Pre-commit check linux-x86_64-release-asan for 2bb13c9 has started.
⚪ 2025-05-29 09:35:47 UTC Artifacts will be uploaded here
⚪ 2025-05-29 09:38:51 UTC ya make is running...
🔴 2025-05-29 11:14:57 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 2bb13c9 diff diff %
ydbd size 4 147 273 176 Bytes 4 154 917 032 Bytes +7.3 MiB +0.184%
ydbd stripped size 1 440 065 016 Bytes 1 442 217 752 Bytes +2.1 MiB +0.149%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label May 30, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 30, 2025
@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 03:36:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 818aa92 has started.
⚪ 2025-05-30 03:36:31 UTC Artifacts will be uploaded here
⚪ 2025-05-30 03:39:30 UTC ya make is running...
🟡 2025-05-30 05:01:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21714 20168 0 8 1496 42

⚪ 2025-05-30 05:02:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 05:31:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1170 (only retried tests) 1055 0 4 76 35

⚪ 2025-05-30 05:31:47 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-30 06:10:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
765 (only retried tests) 735 0 0 0 30

🟢 2025-05-30 06:10:35 UTC Build successful.
🔴 2025-05-30 06:10:58 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 818aa92 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 426 696 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 026 664 Bytes +620.8 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 03:36:25 UTC Pre-commit check linux-x86_64-release-asan for 818aa92 has started.
⚪ 2025-05-30 03:36:35 UTC Artifacts will be uploaded here
⚪ 2025-05-30 03:39:33 UTC ya make is running...
🟡 2025-05-30 05:16:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13738 13513 0 119 83 23

⚪ 2025-05-30 05:17:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 05:50:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2060 (only retried tests) 1970 0 55 12 23

⚪ 2025-05-30 06:05:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-30 06:34:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1363 (only retried tests) 1282 0 49 10 22

🟢 2025-05-30 06:34:44 UTC Build successful.
🔴 2025-05-30 06:35:17 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 818aa92 diff diff %
ydbd size 4 147 273 176 Bytes 4 154 935 120 Bytes +7.3 MiB +0.185%
ydbd stripped size 1 440 065 016 Bytes 1 442 225 176 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov requested a review from CyberROFL May 30, 2025 06:34
@nshestakov nshestakov enabled auto-merge (squash) May 30, 2025 06:45
@CyberROFL CyberROFL removed the request for review from vporyadke May 30, 2025 10:09
CyberROFL
CyberROFL reviewed May 30, 2025
View reviewed changes
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тест на это можно написать?

@nshestakov
Copy link
Collaborator Author

nshestakov commented May 30, 2025

А тест на это можно написать?

Тут тест можно написать только на моках, но он будет тогда абсолютно бессмысленным.

@nshestakov nshestakov requested a review from CyberROFL May 30, 2025 10:40
@nshestakov nshestakov merged commit 30591de into ydb-platform:main May 30, 2025
23 of 26 checks passed
@nshestakov nshestakov deleted the TR-bug-fix branch May 30, 2025 11:55
nshestakov added a commit to nshestakov/ydb that referenced this pull request May 30, 2025
@nshestakov
Fixed possible crash when commited to recreated topic reader (ydb-pla…
d6d0e6b 
…tform#18978)
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@nshestakov
Fixed possible crash when commited to recreated topic reader (ydb-pla…
b25b2b3 
…tform#18978)
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshestakov @CyberROFL