Skip to content

If there are no commitTxIds we should clear AwaitingDecisions #18997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azevaykin merged 2 commits into from
May 30, 2025
Merged

If there are no commitTxIds we should clear AwaitingDecisions #18997

azevaykin merged 2 commits into from
May 30, 2025

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented May 29, 2025 •
edited
Loading

Changelog entry

Fixed a bug where AwaitingDecisions remained non-empty even when there were no commitTxIds present.

Changelog category

  • Bugfix

Description for reviewers

...

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 09:59:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 612e1e3 has started.
⚪ 2025-05-29 09:59:58 UTC Artifacts will be uploaded here
⚪ 2025-05-29 10:02:21 UTC ya make is running...
🟡 2025-05-29 10:15:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 156 0 2 0 0

⚪ 2025-05-29 10:15:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 10:26:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 156 0 2 0 0

⚪ 2025-05-29 10:26:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-29 10:37:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 156 0 2 0 0

🟢 2025-05-29 10:37:26 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 09:59:47 UTC Pre-commit check linux-x86_64-release-asan for 612e1e3 has started.
⚪ 2025-05-29 09:59:57 UTC Artifacts will be uploaded here
⚪ 2025-05-29 10:02:18 UTC ya make is running...
🟡 2025-05-29 10:15:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 156 0 2 0 0

⚪ 2025-05-29 10:15:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 10:26:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 156 0 2 0 0

⚪ 2025-05-29 10:26:36 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 10:37:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 156 0 2 0 0

🟢 2025-05-29 10:37:42 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

🔴 2025-05-29 13:48:45 UTC The validation of the Pull Request description has failed. Please update the description.

Bugfix requires a linked issue in the changelog entry

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 10:58:30 UTC Pre-commit check linux-x86_64-release-asan for d727c26 has started.
⚪ 2025-05-29 10:58:48 UTC Artifacts will be uploaded here
⚪ 2025-05-29 11:01:12 UTC ya make is running...

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 10:58:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for d727c26 has started.
⚪ 2025-05-29 10:59:03 UTC Artifacts will be uploaded here
⚪ 2025-05-29 11:01:22 UTC ya make is running...

@azevaykin azevaykin changed the title Drop table fails If there are no commitTxIds we should clear AwaitingDecisions May 29, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels May 29, 2025
@azevaykin azevaykin marked this pull request as ready for review May 29, 2025 13:47
@azevaykin azevaykin requested a review from a team as a code owner May 29, 2025 13:47
snaury
snaury previously approved these changes May 29, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 13:48:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 93322c6 has started.
⚪ 2025-05-29 13:48:38 UTC Artifacts will be uploaded here
⚪ 2025-05-29 13:51:30 UTC ya make is running...
⚫ 2025-05-29 13:55:33 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 13:49:58 UTC Pre-commit check linux-x86_64-release-asan for 93322c6 has started.
⚪ 2025-05-29 13:50:10 UTC Artifacts will be uploaded here
⚪ 2025-05-29 13:53:06 UTC ya make is running...
⚫ 2025-05-29 13:55:23 UTC Check cancelled

nikvas0
nikvas0 previously approved these changes May 29, 2025
View reviewed changes
@azevaykin azevaykin linked an issue May 29, 2025 that may be closed by this pull request
DROP table hangs after empty update #18811
Closed
@azevaykin azevaykin dismissed stale reviews from nikvas0 and snaury via e62f518 May 29, 2025 13:55
@azevaykin azevaykin requested review from nikvas0 and snaury May 29, 2025 13:55
@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 13:57:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 79eeb7a has started.
⚪ 2025-05-29 13:57:18 UTC Artifacts will be uploaded here
⚪ 2025-05-29 14:00:18 UTC ya make is running...
🟡 2025-05-29 15:23:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21708 20332 0 4 1338 34

⚪ 2025-05-29 15:25:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 16:01:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
361 (only retried tests) 331 0 1 0 29

⚪ 2025-05-29 16:01:16 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-29 16:43:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
309 (only retried tests) 284 0 0 0 25

🟢 2025-05-29 16:43:09 UTC Build successful.
🔴 2025-05-29 16:43:29 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 79eeb7a diff diff %
ydbd size 2 358 248 400 Bytes 2 362 413 240 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 024 680 Bytes +618.9 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 14:00:09 UTC Pre-commit check linux-x86_64-release-asan for 79eeb7a has started.
⚪ 2025-05-29 14:00:43 UTC Artifacts will be uploaded here
⚪ 2025-05-29 14:04:13 UTC ya make is running...
🟡 2025-05-29 15:41:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13733 13500 0 132 77 24

⚪ 2025-05-29 15:42:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 16:17:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1692 (only retried tests) 1550 0 55 67 20

⚪ 2025-05-29 16:18:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 16:52:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1412 (only retried tests) 1336 0 49 7 20

🟢 2025-05-29 16:53:09 UTC Build successful.
🔴 2025-05-29 16:53:42 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 79eeb7a diff diff %
ydbd size 4 147 273 176 Bytes 4 154 916 952 Bytes +7.3 MiB +0.184%
ydbd stripped size 1 440 065 016 Bytes 1 442 217 432 Bytes +2.1 MiB +0.149%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin enabled auto-merge (squash) May 30, 2025 06:09
@azevaykin azevaykin merged commit cf59ad4 into ydb-platform:main May 30, 2025
12 checks passed
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@azevaykin
If there are no commitTxIds we should clear AwaitingDecisions (ydb-pl…
4ca4c3d 
…atform#18997)
nikvas0 pushed a commit to nikvas0/ydb that referenced this pull request Jun 6, 2025
@azevaykin @nikvas0
If there are no commitTxIds we should clear AwaitingDecisions (ydb-pl…
20ba22b 
…atform#18997)
@nikvas0 nikvas0 mentioned this pull request Jun 6, 2025
Merged
@azevaykin azevaykin deleted the DropTableFails branch June 24, 2025 08:10
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

@nikvas0 nikvas0 nikvas0 approved these changes

Assignees

No one assigned

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DROP table hangs after empty update

4 participants

@azevaykin @snaury @nikvas0 @liruoko