Rewritten sampling and throttling controls to share limits and implement scoping #1902

domwst · 2024-02-13T18:30:47Z

Rewritten sampling and throttling controls to share limits and implem…

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-02-13T18:32:20Z

⚪ 2024-02-13 18:32:20 UTC Pre-commit check for baf26dc has started.
⚪ 2024-02-13 18:32:21 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-13 18:37:11 UTC Build failed. see the build logs.
⚪ 2024-02-13 18:37:21 UTC Tests are running...
🔴 2024-02-13 18:46:10 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
6048	5765	0	260	12	11

github-actions · 2024-02-13T18:33:54Z

⚪ 2024-02-13 18:33:54 UTC Pre-commit check for baf26dc has started.
⚪ 2024-02-13 18:33:56 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-13 18:39:01 UTC Build failed. see the build logs.
⚪ 2024-02-13 18:39:13 UTC Tests are running...
🔴 2024-02-13 19:03:41 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58556	47391	0	275	10876	14

github-actions · 2024-02-14T11:23:38Z

⚪ 2024-02-14 11:23:38 UTC Pre-commit check for 8055263 has started.
⚪ 2024-02-14 11:23:40 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-14 11:28:18 UTC Build failed. see the build logs.
⚪ 2024-02-14 11:28:28 UTC Tests are running...
🔴 2024-02-14 11:37:24 UTC Test run completed, no test results found for commit 5b3e088. Please check build logs.
⚫ 2024-02-14 11:37:26 UTC Check cancelled

github-actions · 2024-02-14T11:25:27Z

⚪ 2024-02-14 11:25:27 UTC Pre-commit check for 8055263 has started.
⚪ 2024-02-14 11:25:29 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-14 11:30:36 UTC Build failed. see the build logs.
⚪ 2024-02-14 11:30:47 UTC Tests are running...
🔴 2024-02-14 11:37:23 UTC Test run completed, no test results found for commit 5b3e088. Please check build logs.
⚫ 2024-02-14 11:37:25 UTC Check cancelled

github-actions · 2024-02-14T11:47:16Z

⚪ 2024-02-14 11:47:16 UTC Pre-commit check for adc323a has started.
⚪ 2024-02-14 11:47:17 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-14 11:49:18 UTC Build failed. see the build logs.
⚪ 2024-02-14 11:49:27 UTC Tests are running...
🔴 2024-02-14 12:04:50 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58567	47403	0	274	10876	14

github-actions · 2024-02-14T11:58:48Z

⚪ 2024-02-14 11:58:47 UTC Pre-commit check for adc323a has started.
⚪ 2024-02-14 11:58:49 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-14 12:00:45 UTC Build failed. see the build logs.
⚪ 2024-02-14 12:01:01 UTC Tests are running...
🔴 2024-02-14 12:06:03 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
6058	5787	0	257	3	11

github-actions · 2024-02-16T09:17:18Z

⚪ 2024-02-16 09:17:17 UTC Pre-commit check for 8031b7f has started.
⚪ 2024-02-16 09:17:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-16 09:57:24 UTC Build successful.
⚪ 2024-02-16 09:57:37 UTC Tests are running...
🔴 2024-02-16 11:51:21 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14667	13862	0	479	162	164

github-actions · 2024-02-16T09:17:22Z

⚪ 2024-02-16 09:17:22 UTC Pre-commit check for 8031b7f has started.
⚪ 2024-02-16 09:17:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-16 09:57:16 UTC Build successful.
⚪ 2024-02-16 09:57:32 UTC Tests are running...
🔴 2024-02-16 11:28:57 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67420	56393	0	21	10975	31

github-actions · 2024-02-18T17:41:34Z

⚪ 2024-02-18 17:41:34 UTC Pre-commit check for 121cbc9 has started.
⚪ 2024-02-18 17:41:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-18 18:59:34 UTC Build successful.
⚪ 2024-02-18 18:59:54 UTC Tests are running...
🔴 2024-02-18 20:59:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14665	13890	0	469	140	166

github-actions · 2024-02-18T17:42:10Z

⚪ 2024-02-18 17:42:09 UTC Pre-commit check for 121cbc9 has started.
⚪ 2024-02-18 17:42:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-18 18:57:41 UTC Build successful.
⚪ 2024-02-18 18:57:57 UTC Tests are running...
🔴 2024-02-18 20:50:40 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67467	56429	0	25	10981	32

github-actions · 2024-02-19T07:45:48Z

⚪ 2024-02-19 07:45:48 UTC Pre-commit check for 6de7406 has started.
⚪ 2024-02-19 07:45:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-19 07:47:26 UTC Build successful.
⚪ 2024-02-19 07:47:39 UTC Tests are running...
🔴 2024-02-19 09:37:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14669	13904	0	469	133	163

github-actions · 2024-02-19T07:45:51Z

⚪ 2024-02-19 07:45:51 UTC Pre-commit check for 6de7406 has started.
⚪ 2024-02-19 07:45:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-19 07:47:39 UTC Build successful.
⚪ 2024-02-19 07:47:52 UTC Tests are running...
🔴 2024-02-19 09:05:54 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67461	56423	0	21	10982	35

github-actions · 2024-02-20T04:58:14Z

⚪ 2024-02-20 04:58:13 UTC Pre-commit check for 24ad483 has started.
⚪ 2024-02-20 04:58:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 05:37:41 UTC Build successful.
⚪ 2024-02-20 05:37:55 UTC Tests are running...
🔴 2024-02-20 07:10:03 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67694	56685	0	13	10944	52

github-actions · 2024-02-20T04:58:15Z

⚪ 2024-02-20 04:58:15 UTC Pre-commit check for 24ad483 has started.
⚪ 2024-02-20 04:58:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 05:38:06 UTC Build successful.
⚪ 2024-02-20 05:38:18 UTC Tests are running...
🔴 2024-02-20 07:37:27 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14688	13883	0	484	153	168

github-actions · 2024-02-20T13:51:25Z

⚪ 2024-02-20 13:51:25 UTC Pre-commit check for 011a0c3 has started.
⚪ 2024-02-20 13:51:28 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-20 14:19:26 UTC Check cancelled

github-actions · 2024-02-20T13:53:52Z

⚪ 2024-02-20 13:53:52 UTC Pre-commit check for 011a0c3 has started.
⚪ 2024-02-20 13:53:54 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-20 14:19:25 UTC Check cancelled

…ent scoping

github-actions · 2024-02-20T14:19:58Z

⚪ 2024-02-20 14:19:58 UTC Pre-commit check for 512daf0 has started.
⚪ 2024-02-20 14:20:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 15:00:06 UTC Build successful.
⚪ 2024-02-20 15:00:15 UTC Tests are running...
🔴 2024-02-20 16:10:33 UTC Test run completed, no test results found for commit c06073d. Please check build logs.
⚫ 2024-02-20 16:10:37 UTC Check cancelled

github-actions · 2024-02-20T14:20:41Z

⚪ 2024-02-20 14:20:41 UTC Pre-commit check for 512daf0 has started.
⚪ 2024-02-20 14:20:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 14:57:19 UTC Build successful.
⚪ 2024-02-20 14:57:36 UTC Tests are running...
🔴 2024-02-20 16:10:33 UTC Test run completed, no test results found for commit c06073d. Please check build logs.
⚫ 2024-02-20 16:10:39 UTC Check cancelled

ydb/core/jaeger_tracing/throttler.h

ydb/core/jaeger_tracing/sampling_throttling_control.h

ydb/core/jaeger_tracing/sampling_throttling_control.cpp

…to throttler.cpp

github-actions · 2024-02-20T16:11:51Z

⚪ 2024-02-20 16:11:51 UTC Pre-commit check for cb0a071 has started.
⚪ 2024-02-20 16:11:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 16:48:38 UTC Build successful.
⚪ 2024-02-20 16:48:49 UTC Tests are running...
🔴 2024-02-20 18:20:46 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67706	56705	0	16	10947	38

github-actions · 2024-02-20T16:13:44Z

⚪ 2024-02-20 16:13:44 UTC Pre-commit check for cb0a071 has started.
⚪ 2024-02-20 16:13:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 16:55:02 UTC Build successful.
⚪ 2024-02-20 16:55:16 UTC Tests are running...
🔴 2024-02-20 18:37:34 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14698	14450	0	45	160	43

github-actions · 2024-02-21T04:17:02Z

⚪ 2024-02-21 04:17:01 UTC Pre-commit check for afd1812 has started.
⚪ 2024-02-21 04:17:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-21 04:27:00 UTC Build successful.
⚪ 2024-02-21 04:27:14 UTC Tests are running...
🔴 2024-02-21 06:03:08 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67780	56773	0	14	10956	37

github-actions · 2024-02-21T04:17:34Z

⚪ 2024-02-21 04:17:34 UTC Pre-commit check for afd1812 has started.
⚪ 2024-02-21 04:17:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-21 04:26:53 UTC Build successful.
⚪ 2024-02-21 04:27:09 UTC Tests are running...
🔴 2024-02-21 06:01:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14691	14480	0	29	145	37

…ent scoping (ydb-platform#1902)

…ent scoping (#1902)

…ent scoping (ydb-platform#1902)

github-actions bot added the not-for-changelog label Feb 13, 2024

domwst force-pushed the sampling-throttling-controls-rewrite branch from 0592900 to e333164 Compare February 19, 2024 07:42

domwst force-pushed the sampling-throttling-controls-rewrite branch from e333164 to ba2eb51 Compare February 20, 2024 04:55

domwst linked an issue Feb 20, 2024 that may be closed by this pull request

Enchance tracing controls to allow for per-type request filtering and shared limits between grpc request proxies #2007

Closed

domwst added 8 commits February 20, 2024 14:18

Rewritten sampling and throttling controls to share limits and implem…

f626a74

…ent scoping

Made jaeger_tracing compilable

958e1e9

Removed obsolete code, fixed failing tests

5791041

Implemented JaegerTracingConfigurator

4ad0196

Implemented but not tested

1a6e6fb

Fixed several issues

c3797bb

Allowing external traces by default

23854b3

Added request type to configuration generators

c06073d

domwst force-pushed the sampling-throttling-controls-rewrite branch from 32f11e5 to c06073d Compare February 20, 2024 14:19

kruall requested changes Feb 20, 2024

View reviewed changes

ydb/core/jaeger_tracing/throttler.h Outdated Show resolved Hide resolved

ydb/core/jaeger_tracing/sampling_throttling_control.h Show resolved Hide resolved

ydb/core/jaeger_tracing/sampling_throttling_control.cpp Outdated Show resolved Hide resolved

Fixed memory leak, resolved comments, moved throttler implementation …

8a09888

…to throttler.cpp

Fixed compilation issue when no builtins are present

3d8d326

kruall approved these changes Feb 21, 2024

View reviewed changes

kruall merged commit 11c1356 into ydb-platform:main Feb 21, 2024
2 of 4 checks passed

domwst added a commit to domwst/ydb that referenced this pull request Feb 21, 2024

Rewritten sampling and throttling controls to share limits and implem…

c2a1b6a

…ent scoping (ydb-platform#1902)

GrigoriyPA mentioned this pull request Feb 21, 2024

YQ-2786 partly unmute tests fq s3 #2143

Merged

StekPerepolnen mentioned this pull request Feb 22, 2024

YDB-1453 added CORS headers to healthcheck handler #2174

Merged

GrigoriyPA mentioned this pull request Feb 26, 2024

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

domwst added a commit to domwst/ydb that referenced this pull request Feb 28, 2024

Rewritten sampling and throttling controls to share limits and implem…

4e57a5e

…ent scoping (ydb-platform#1902)

GrigoriyPA mentioned this pull request Mar 7, 2024

YQ-2737 add TOKEN auth for YT datasource #2561

Merged

domwst added a commit to domwst/ydb that referenced this pull request Mar 11, 2024

Rewritten sampling and throttling controls to share limits and implem…

fa23b68

…ent scoping (ydb-platform#1902)

domwst added a commit to domwst/ydb that referenced this pull request Mar 12, 2024

Rewritten sampling and throttling controls to share limits and implem…

6c4f460

…ent scoping (ydb-platform#1902)

GrigoriyPA mentioned this pull request Mar 13, 2024

YQ-2957 fix error in s3 stream read actor #2702

Merged

domwst added a commit to domwst/ydb that referenced this pull request Mar 19, 2024

Rewritten sampling and throttling controls to share limits and implem…

6b90402

…ent scoping (ydb-platform#1902)

This was referenced Mar 19, 2024

Fixed error due to empty token #2966

Merged

YQ-2738 add integration tests for YT in KQP #3150

Merged

domwst added a commit to domwst/ydb that referenced this pull request Apr 3, 2024

Rewritten sampling and throttling controls to share limits and implem…

256a10e

…ent scoping (ydb-platform#1902)

SammyVimes pushed a commit that referenced this pull request Apr 4, 2024

Rewritten sampling and throttling controls to share limits and implem…

02a1d61

…ent scoping (#1902)

serbel324 mentioned this pull request Jun 11, 2024

Merge tracing fixes to 24-1 #5458

Merged

serbel324 pushed a commit to serbel324/ydb that referenced this pull request Jun 11, 2024

Rewritten sampling and throttling controls to share limits and implem…

3f32ce5

…ent scoping (ydb-platform#1902)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewritten sampling and throttling controls to share limits and implement scoping #1902

Rewritten sampling and throttling controls to share limits and implement scoping #1902

domwst commented Feb 13, 2024

github-actions bot commented Feb 13, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

Rewritten sampling and throttling controls to share limits and implement scoping #1902

Rewritten sampling and throttling controls to share limits and implement scoping #1902

Conversation

domwst commented Feb 13, 2024