Skip to content

Show node name in start logs only when it is appropriate #19040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented May 29, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Делает логи старта менее вербозными при обычной работе

@pixcc pixcc requested a review from CyberROFL May 29, 2025 20:31
@pixcc pixcc requested a review from a team as a code owner May 29, 2025 20:31
Copy link

github-actions bot commented May 29, 2025

2025-05-29 20:31:48 UTC Pre-commit check linux-x86_64-release-asan for 988aa0a has started.
2025-05-29 20:31:52 UTC Artifacts will be uploaded here
2025-05-29 20:34:49 UTC ya make is running...
🟡 2025-05-29 22:10:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13615 13374 0 132 85 24

2025-05-29 22:11:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 22:46:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1711 (only retried tests) 1617 0 60 9 25

2025-05-29 22:47:04 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 23:18:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1407 (only retried tests) 1277 0 52 55 23

🟢 2025-05-29 23:18:15 UTC Build successful.
🔴 2025-05-29 23:18:49 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 988aa0a diff diff %
ydbd size 4 147 273 176 Bytes 4 154 935 472 Bytes +7.3 MiB +0.185%
ydbd stripped size 1 440 065 016 Bytes 1 442 225 496 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 29, 2025

2025-05-29 20:32:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 988aa0a has started.
2025-05-29 20:32:53 UTC Artifacts will be uploaded here
2025-05-29 20:35:47 UTC ya make is running...
🟡 2025-05-29 21:47:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21362 19984 0 2 1337 39

2025-05-29 21:49:33 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-29 22:24:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
749 (only retried tests) 718 0 0 0 31

🟢 2025-05-29 22:24:36 UTC Build successful.
🔴 2025-05-29 22:24:55 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 988aa0a diff diff %
ydbd size 2 358 248 400 Bytes 2 362 426 696 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 026 728 Bytes +620.9 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 29, 2025

🟢 2025-05-29 20:34:56 UTC The validation of the Pull Request description is successful.

@pixcc pixcc requested a review from CyberROFL May 30, 2025 09:50
Copy link

github-actions bot commented May 30, 2025

2025-05-30 09:51:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0bcf13d has started.
2025-05-30 09:51:50 UTC Artifacts will be uploaded here
2025-05-30 09:54:42 UTC ya make is running...
🟡 2025-05-30 11:04:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21364 19988 0 4 1337 35

2025-05-30 11:06:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-30 11:42:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
536 (only retried tests) 510 0 0 0 26

🟢 2025-05-30 11:42:50 UTC Build successful.
🔴 2025-05-30 11:43:09 UTC ydbd size 2.2 GiB changed* by +4.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 0bcf13d diff diff %
ydbd size 2 358 248 400 Bytes 2 362 594 560 Bytes +4.1 MiB +0.184%
ydbd stripped size 495 390 920 Bytes 496 063 848 Bytes +657.2 KiB +0.136%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 30, 2025

2025-05-30 09:51:38 UTC Pre-commit check linux-x86_64-release-asan for 0bcf13d has started.
2025-05-30 09:51:50 UTC Artifacts will be uploaded here
2025-05-30 09:54:48 UTC ya make is running...
🟡 2025-05-30 11:34:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13617 13373 0 137 83 24

2025-05-30 11:36:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 12:16:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1917 (only retried tests) 1720 0 103 72 22

2025-05-30 12:16:42 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-30 12:55:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1604 (only retried tests) 1426 0 87 67 24

🟢 2025-05-30 12:55:33 UTC Build successful.
🔴 2025-05-30 12:56:10 UTC ydbd size 3.9 GiB changed* by +7.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 0bcf13d diff diff %
ydbd size 4 147 273 176 Bytes 4 155 152 648 Bytes +7.5 MiB +0.190%
ydbd stripped size 1 440 065 016 Bytes 1 442 317 336 Bytes +2.1 MiB +0.156%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc enabled auto-merge (squash) May 30, 2025 10:14
@pixcc pixcc merged commit fdaa9ab into ydb-platform:main May 30, 2025
12 checks passed
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants