Skip to content

Refactor index write checks #19052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikvas0 merged 2 commits into from
May 30, 2025
Merged

Refactor index write checks #19052

nikvas0 merged 2 commits into from
May 30, 2025

Conversation

@nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented May 30, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Refactor index write checks

@github-actions
Copy link

github-actions bot commented May 30, 2025

🟢 2025-05-30 09:14:43 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 09:16:53 UTC Pre-commit check linux-x86_64-release-asan for 80295c1 has started.
⚪ 2025-05-30 09:17:04 UTC Artifacts will be uploaded here
⚪ 2025-05-30 09:19:57 UTC ya make is running...
🟡 2025-05-30 10:54:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13594 13395 0 98 76 25

⚪ 2025-05-30 10:55:38 UTC ya make is running... (failed tests rerun, try 2)
🔴 2025-05-30 11:02:35 UTC ydbd size 3.9 GiB changed* by +7.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 80295c1 diff diff %
ydbd size 4 147 273 176 Bytes 4 155 178 800 Bytes +7.5 MiB +0.191%
ydbd stripped size 1 440 065 016 Bytes 1 442 330 392 Bytes +2.2 MiB +0.157%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-05-30 11:02:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 09:17:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 80295c1 has started.
⚪ 2025-05-30 09:17:19 UTC Artifacts will be uploaded here
⚪ 2025-05-30 09:20:18 UTC ya make is running...
🟡 2025-05-30 10:33:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21341 19962 0 7 1337 35

⚪ 2025-05-30 10:35:32 UTC ya make is running... (failed tests rerun, try 2)
🔴 2025-05-30 11:03:39 UTC ydbd size 2.2 GiB changed* by +4.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 80295c1 diff diff %
ydbd size 2 358 248 400 Bytes 2 362 576 768 Bytes +4.1 MiB +0.184%
ydbd stripped size 495 390 920 Bytes 496 064 680 Bytes +658.0 KiB +0.136%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-05-30 11:03:40 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 11:07:47 UTC Pre-commit check linux-x86_64-release-asan for 87afcbe has started.
⚪ 2025-05-30 11:07:58 UTC Artifacts will be uploaded here
⚪ 2025-05-30 11:10:49 UTC ya make is running...
🟡 2025-05-30 12:42:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13595 13375 0 103 93 24

⚪ 2025-05-30 12:43:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 13:15:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1519 (only retried tests) 1441 0 49 7 22

⚪ 2025-05-30 13:15:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-30 13:42:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1206 (only retried tests) 1083 0 92 10 21

🟢 2025-05-30 13:43:07 UTC Build successful.
🔴 2025-05-30 13:43:38 UTC ydbd size 3.9 GiB changed* by +7.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 87afcbe diff diff %
ydbd size 4 147 273 176 Bytes 4 155 206 616 Bytes +7.6 MiB +0.191%
ydbd stripped size 1 440 065 016 Bytes 1 442 337 496 Bytes +2.2 MiB +0.158%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 30, 2025 •
edited
Loading

⚪ 2025-05-30 11:10:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 87afcbe has started.
⚪ 2025-05-30 11:10:21 UTC Artifacts will be uploaded here
⚪ 2025-05-30 11:13:12 UTC ya make is running...
🟡 2025-05-30 12:32:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21346 19929 0 48 1337 32

⚪ 2025-05-30 12:34:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 13:14:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
421 (only retried tests) 389 0 1 0 31

⚪ 2025-05-30 13:14:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-30 13:39:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
410 (only retried tests) 386 0 0 0 24

🟢 2025-05-30 13:39:08 UTC Build successful.
🔴 2025-05-30 13:39:30 UTC ydbd size 2.2 GiB changed* by +4.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 87afcbe diff diff %
ydbd size 2 358 248 400 Bytes 2 362 597 736 Bytes +4.1 MiB +0.184%
ydbd stripped size 495 390 920 Bytes 496 066 984 Bytes +660.2 KiB +0.136%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 marked this pull request as ready for review May 30, 2025 13:32
@nikvas0 nikvas0 requested a review from a team as a code owner May 30, 2025 13:32
@nikvas0 nikvas0 enabled auto-merge (squash) May 30, 2025 13:51
@nikvas0 nikvas0 merged commit 3d4b815 into ydb-platform:main May 30, 2025
11 checks passed
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@nikvas0
Refactor index write checks (ydb-platform#19052)
52b2c00
@naspirato naspirato mentioned this pull request Jun 10, 2025
Closed
UgnineSirdis pushed a commit to UgnineSirdis/ydb that referenced this pull request Aug 25, 2025
@nikvas0 @UgnineSirdis
Refactor index write checks (ydb-platform#19052)
8afc8aa 
(cherry picked from commit 3d4b815)
UgnineSirdis pushed a commit that referenced this pull request Aug 26, 2025
@nikvas0 @UgnineSirdis
Refactor index write checks (#19052)
236afc9 
(cherry picked from commit 3d4b815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikvas0 @gridnevvvit