Handle unhandled exceptions during build index SchemeShard init #19312
Conversation
|
🟢 |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| TString uid = row.template GetValue<Schema::IndexBuild::Uid>(); | ||
|
|
||
| TIndexBuildInfo::TPtr indexInfo = new TIndexBuildInfo(id, uid); | ||
| // note: essential fields go first to be filled if an error occurs |
There was a problem hiding this comment.
дифф ниже просто переупорядочевание
|
В целом по-моему нормально, единственно может быть на будущее стоило бы подумать про то, чтобы ограничить спектр перехватываемого, типа например перехватывать только то, что кидает Y_ENSURE, или сделать какой-то свой ENSURE... Но может быть и нет т.к. справедливый ответ, что например .at() и out_of_range тоже хотим поймать. В общем наверное пусть так и будет пока. |
3 participants
Changelog entry
...
Changelog category
Description for reviewers
Part of #18648