Skip to content

Fixes for BATCH operations for tables with index and empty result rows #19463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dahbka-lis merged 4 commits into from
Jun 7, 2025
Merged

Fixes for BATCH operations for tables with index and empty result rows #19463

dahbka-lis merged 4 commits into from
Jun 7, 2025

Conversation

@dahbka-lis
Copy link
Member

@dahbka-lis dahbka-lis commented Jun 7, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dahbka-lis dahbka-lis requested a review from a team as a code owner June 7, 2025 12:48
@dahbka-lis dahbka-lis linked an issue Jun 7, 2025 that may be closed by this pull request
KqpTableSinkSettings.IsBatch() == false for the BATCH UPDATE query #19394
Closed
@github-actions
Copy link

github-actions bot commented Jun 7, 2025

🟢 2025-06-07 12:50:15 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 12:52:10 UTC Pre-commit check linux-x86_64-release-asan for 2450e34 has started.
⚪ 2025-06-07 12:52:21 UTC Artifacts will be uploaded here
⚪ 2025-06-07 12:55:26 UTC ya make is running...
⚫ 2025-06-07 13:11:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 12:52:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2450e34 has started.
⚪ 2025-06-07 12:52:36 UTC Artifacts will be uploaded here
⚪ 2025-06-07 12:55:48 UTC ya make is running...
⚫ 2025-06-07 13:11:36 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 13:15:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 57665e1 has started.
⚪ 2025-06-07 13:15:46 UTC Artifacts will be uploaded here
⚪ 2025-06-07 13:18:53 UTC ya make is running...
🟡 2025-06-07 14:17:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21582 20198 0 3 1340 41

⚪ 2025-06-07 14:19:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-07 14:35:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
848 (only retried tests) 822 0 1 0 25

⚪ 2025-06-07 14:35:31 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-07 14:49:21 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
855 (only retried tests) 830 0 1 0 24

🟢 2025-06-07 14:49:31 UTC Build successful.
🟢 2025-06-07 14:49:51 UTC ydbd size 2.2 GiB changed* by +38.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4065db2 merge: 57665e1 diff diff %
ydbd size 2 370 216 976 Bytes 2 370 255 968 Bytes +38.1 KiB +0.002%
ydbd stripped size 497 242 024 Bytes 497 246 120 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 13:15:44 UTC Pre-commit check linux-x86_64-release-asan for 57665e1 has started.
⚪ 2025-06-07 13:15:54 UTC Artifacts will be uploaded here
⚪ 2025-06-07 13:18:50 UTC ya make is running...
🟡 2025-06-07 14:55:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13670 13487 0 81 77 25

⚪ 2025-06-07 14:56:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-07 15:28:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1439 (only retried tests) 1322 0 84 5 28

⚪ 2025-06-07 15:28:42 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-07 16:00:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1283 (only retried tests) 1188 0 68 5 22

🟢 2025-06-07 16:00:44 UTC Build successful.
🟢 2025-06-07 16:01:16 UTC ydbd size 3.9 GiB changed* by -20.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4065db2 merge: 57665e1 diff diff %
ydbd size 4 168 732 552 Bytes 4 168 711 896 Bytes -20.2 KiB -0.000%
ydbd stripped size 1 446 051 384 Bytes 1 446 052 856 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 18:33:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 683d908 has started.
⚪ 2025-06-07 18:33:49 UTC Artifacts will be uploaded here
⚪ 2025-06-07 18:36:49 UTC ya make is running...
🟡 2025-06-07 19:42:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21582 20196 0 4 1352 30

⚪ 2025-06-07 19:44:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-07 19:52:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
317 (only retried tests) 296 0 0 0 21

🟢 2025-06-07 19:52:38 UTC Build successful.
🟢 2025-06-07 19:52:56 UTC ydbd size 2.2 GiB changed* by +38.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4065db2 merge: 683d908 diff diff %
ydbd size 2 370 216 976 Bytes 2 370 255 968 Bytes +38.1 KiB +0.002%
ydbd stripped size 497 242 024 Bytes 497 246 120 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jun 7, 2025 •
edited
Loading

⚪ 2025-06-07 18:33:39 UTC Pre-commit check linux-x86_64-release-asan for 683d908 has started.
⚪ 2025-06-07 18:33:50 UTC Artifacts will be uploaded here
⚪ 2025-06-07 18:36:56 UTC ya make is running...
🟡 2025-06-07 20:18:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13670 13389 0 145 114 22

⚪ 2025-06-07 20:19:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-07 20:58:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1745 (only retried tests) 1602 0 62 59 22

⚪ 2025-06-07 20:58:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-07 21:33:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1526 (only retried tests) 1420 0 79 5 22

🟢 2025-06-07 21:33:58 UTC Build successful.
🟢 2025-06-07 21:34:30 UTC ydbd size 3.9 GiB changed* by -20.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4065db2 merge: 683d908 diff diff %
ydbd size 4 168 732 552 Bytes 4 168 711 896 Bytes -20.2 KiB -0.000%
ydbd stripped size 1 446 051 384 Bytes 1 446 052 856 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dahbka-lis dahbka-lis enabled auto-merge (squash) June 7, 2025 20:30
@dahbka-lis dahbka-lis merged commit 81ee194 into ydb-platform:main Jun 7, 2025
11 checks passed
dahbka-lis added a commit to dahbka-lis/ydb that referenced this pull request Jun 7, 2025
@dahbka-lis
Fixes for BATCH operations for tables with index and empty result rows (
7af636e 
ydb-platform#19463)
@dahbka-lis dahbka-lis mentioned this pull request Jun 7, 2025
Merged
@dahbka-lis dahbka-lis mentioned this pull request Jul 17, 2025
Open
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KqpTableSinkSettings.IsBatch() == false for the BATCH UPDATE query

2 participants

@dahbka-lis @gridnevvvit