Skip to content

Added missing settings to query_service_config in local_ydb #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitalyisaev2 merged 1 commit into from
Feb 16, 2024
Merged

Added missing settings to query_service_config in local_ydb #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/public/tools/lib/cmds/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def generic_connector_config():

valid_schemes = ['grpc', 'grpcs']
if parsed.scheme not in valid_schemes:
raise ValueError("Invalid schema '{}' in FQ_CONNECTOR_ENDPOINT (possible: {})".format(parsed.schema, valid_schemes))
raise ValueError("Invalid schema '{}' in FQ_CONNECTOR_ENDPOINT (possible: {})".format(parsed.scheme, valid_schemes))

cfg = TGenericConnectorConfig()
cfg.Endpoint.host = parsed.hostname
Expand Down
12 changes: 11 additions & 1 deletion ydb/tests/library/harness/kikimr_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,17 @@ def __init__(
"port": generic_connector_config.Endpoint.port,
},
"use_ssl": generic_connector_config.UseSsl
}
},
"default_settings": [
{
"name": "DateTimeFormat",
"value": "string"
},
{
"name": "UsePredicatePushdown",
"value": "true"
}
]
}

self.yaml_config["feature_flags"]["enable_external_data_sources"] = True
Expand Down
4 changes: 4 additions & 0 deletions ydb/tests/library/ut/kikimr_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,9 @@ def test_kikimr_config_generator_generic_connector_config():
assert yaml_config["query_service_config"]["generic"]["connector"]["endpoint"]["host"] == generic_connector_config.Endpoint.host
assert yaml_config["query_service_config"]["generic"]["connector"]["endpoint"]["port"] == generic_connector_config.Endpoint.port
assert yaml_config["query_service_config"]["generic"]["connector"]["use_ssl"] == generic_connector_config.UseSsl
assert yaml_config["query_service_config"]["generic"]["default_settings"] == [
{"name": "DateTimeFormat", "value": "string"},
{"name": "UsePredicatePushdown", "value": "true"},
]
assert yaml_config["feature_flags"]["enable_external_data_sources"] is True
assert yaml_config["feature_flags"]["enable_script_execution_operations"] is True