Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

The new Nebius scheme for checking permissions for cluster root container worked only for http requests (because TEvRequestAuthAndCheck works only in case of http requests). This PR fixes grpc methods (like getting/setting cluster config), if we use AdministrationAllowedSIDs together with folder_id cluster attribute.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

🟢 2025-07-07 16:05:30 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 16:10:25 UTC Pre-commit check linux-x86_64-release-asan for 1415b1c has started.
2025-07-07 16:10:37 UTC Artifacts will be uploaded here
2025-07-07 16:13:49 UTC ya make is running...
2025-07-07 16:48:38 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 16:11:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1415b1c has started.
2025-07-07 16:11:59 UTC Artifacts will be uploaded here
2025-07-07 16:15:23 UTC ya make is running...
2025-07-07 16:48:25 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 16:56:19 UTC Pre-commit check linux-x86_64-release-asan for 0cac154 has started.
2025-07-07 16:56:46 UTC Artifacts will be uploaded here
2025-07-07 17:00:42 UTC ya make is running...
🟡 2025-07-07 18:42:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14300 13934 0 129 207 30

🟢 2025-07-07 18:43:49 UTC Build successful.
🟢 2025-07-07 18:44:16 UTC ydbd size 3.9 GiB changed* by +21.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fff1a83 merge: 0cac154 diff diff %
ydbd size 4 200 367 888 Bytes 4 200 390 248 Bytes +21.8 KiB +0.001%
ydbd stripped size 1 455 387 032 Bytes 1 455 391 384 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

2025-07-07 17:15:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0cac154 has started.
2025-07-07 17:15:54 UTC Artifacts will be uploaded here
2025-07-07 17:19:11 UTC ya make is running...
🟡 2025-07-07 18:29:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29689 28272 0 1 1368 48

2025-07-07 18:31:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-07-07 18:43:33 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
394 (only retried tests) 347 0 0 9 38

🟢 2025-07-07 18:43:44 UTC Build successful.
🟢 2025-07-07 18:44:04 UTC ydbd size 2.2 GiB changed* by +16.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fff1a83 merge: 0cac154 diff diff %
ydbd size 2 388 089 616 Bytes 2 388 106 024 Bytes +16.0 KiB +0.001%
ydbd stripped size 499 675 880 Bytes 499 678 504 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis enabled auto-merge (squash) July 7, 2025 17:20
@UgnineSirdis UgnineSirdis merged commit 65bc867 into ydb-platform:main Jul 7, 2025
13 checks passed
@UgnineSirdis UgnineSirdis deleted the fix-cluster-permissions-under-grpc branch July 7, 2025 19:21
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 8, 2025
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 8, 2025
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Jul 30, 2025
UgnineSirdis added a commit that referenced this pull request Aug 5, 2025
molotkov-and pushed a commit to molotkov-and/ydb that referenced this pull request Sep 11, 2025
molotkov-and pushed a commit to molotkov-and/ydb that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants