Skip to content

Add external_data_channels_count create table feature (YDB part). #21151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tony-Romanov merged 19 commits into from
Aug 18, 2025
Merged

Add external_data_channels_count create table feature (YDB part). #21151

Tony-Romanov merged 19 commits into from
Aug 18, 2025

Conversation

@Tony-Romanov
Copy link
Collaborator

@Tony-Romanov Tony-Romanov commented Jul 15, 2025

  • New feature

@Tony-Romanov Tony-Romanov requested review from a team as code owners July 15, 2025 10:54
@Tony-Romanov Tony-Romanov requested a review from va-kuznecov July 15, 2025 10:56
@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

🟢 2025-07-18 05:59:05 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

⚪ 2025-07-15 11:03:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for f9ff5eb has started.
⚪ 2025-07-15 11:04:02 UTC Artifacts will be uploaded here
⚪ 2025-07-15 11:08:00 UTC ya make is running...
⚫ 2025-07-15 12:28:15 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

⚪ 2025-07-15 11:09:57 UTC Pre-commit check linux-x86_64-release-asan for f9ff5eb has started.
⚪ 2025-07-15 11:10:42 UTC Artifacts will be uploaded here
⚪ 2025-07-15 11:15:18 UTC ya make is running...
⚫ 2025-07-15 12:28:14 UTC Check cancelled

Gazizonoki
Gazizonoki reviewed Jul 15, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

⚪ 2025-07-15 12:29:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 02a2b70 has started.
⚪ 2025-07-15 12:29:33 UTC Artifacts will be uploaded here
⚪ 2025-07-15 12:34:10 UTC ya make is running...
🟡 2025-07-15 14:29:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39602 36864 0 3 2698 37

⚪ 2025-07-15 14:33:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-15 14:49:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
344 (only retried tests) 304 0 2 9 29

⚪ 2025-07-15 14:49:26 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-15 14:58:32 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
328 (only retried tests) 298 0 2 3 25

🟡 2025-07-15 15:01:17 UTC ydbd size 2.2 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 580f3ae merge: 02a2b70 diff diff %
ydbd size 2 392 313 352 Bytes 2 393 797 464 Bytes +1.4 MiB +0.062%
ydbd stripped size 500 813 448 Bytes 500 755 464 Bytes -56.6 KiB -0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

⚪ 2025-07-15 12:30:51 UTC Pre-commit check linux-x86_64-release-asan for 02a2b70 has started.
⚪ 2025-07-15 12:31:04 UTC Artifacts will be uploaded here
⚪ 2025-07-15 12:34:51 UTC ya make is running...
🟡 2025-07-15 14:55:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17101 16742 0 106 225 28

@Tony-Romanov Tony-Romanov requested a review from Gazizonoki July 15, 2025 13:36
@Tony-Romanov Tony-Romanov enabled auto-merge (squash) July 15, 2025 13:38
@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

⚪ 2025-07-15 15:15:30 UTC Pre-commit check linux-x86_64-release-asan for 091ee7a has started.
⚪ 2025-07-15 15:15:47 UTC Artifacts will be uploaded here
⚪ 2025-07-15 15:19:48 UTC ya make is running...
🟡 2025-07-15 17:44:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17103 16716 0 139 219 29

🟢 2025-07-15 17:45:32 UTC ydbd size 3.9 GiB changed* by +29.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7ca01aa merge: 091ee7a diff diff %
ydbd size 4 210 071 448 Bytes 4 210 101 856 Bytes +29.7 KiB +0.001%
ydbd stripped size 1 459 314 648 Bytes 1 459 321 816 Bytes +7.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

⚪ 2025-07-15 15:21:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 091ee7a has started.
⚪ 2025-07-15 15:21:57 UTC Artifacts will be uploaded here
⚪ 2025-07-15 15:26:29 UTC ya make is running...
🟡 2025-07-15 17:28:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39604 36855 0 7 2695 47

🟢 2025-07-15 17:29:20 UTC ydbd size 2.2 GiB changed* by +10.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7ca01aa merge: 091ee7a diff diff %
ydbd size 2 394 284 928 Bytes 2 394 296 048 Bytes +10.9 KiB +0.000%
ydbd stripped size 500 825 704 Bytes 500 827 048 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 17, 2025 •
edited
Loading

⚪ 2025-07-17 08:19:48 UTC Pre-commit check linux-x86_64-release-asan for 19d3d43 has started.
⚪ 2025-07-17 08:20:01 UTC Artifacts will be uploaded here
⚪ 2025-07-17 08:23:49 UTC ya make is running...
⚫ 2025-07-17 08:28:10 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 17, 2025 •
edited
Loading

⚪ 2025-07-17 08:20:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 19d3d43 has started.
⚪ 2025-07-17 08:20:45 UTC Artifacts will be uploaded here
⚪ 2025-07-17 08:24:43 UTC ya make is running...
⚫ 2025-07-17 08:28:10 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 17, 2025 •
edited
Loading

⚪ 2025-07-17 08:31:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for e9c781b has started.
⚪ 2025-07-17 08:31:25 UTC Artifacts will be uploaded here
⚪ 2025-07-17 08:35:27 UTC ya make is running...
🟡 2025-07-17 10:41:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39578 36829 0 6 2706 37

⚪ 2025-07-17 10:45:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-07-17 10:58:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
332 (only retried tests) 305 0 3 0 24

⚪ 2025-07-17 10:58:52 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-07-17 11:11:45 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
259 (only retried tests) 234 0 2 0 23

🟢 2025-07-17 11:11:53 UTC Build successful.
🟢 2025-07-17 11:12:16 UTC ydbd size 2.2 GiB changed* by +8.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4ebb0f9 merge: e9c781b diff diff %
ydbd size 2 395 855 416 Bytes 2 395 863 960 Bytes +8.3 KiB +0.000%
ydbd stripped size 501 068 936 Bytes 501 070 184 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov requested a review from SammyVimes July 24, 2025 13:28
@gridnevvvit
Copy link
Member

gridnevvvit commented Jul 24, 2025 •
edited
Loading

Если мы добавляем возможность создавать такие таблицы через запрос, то стоит добавить какой-то базовый юнит тест через ExecuteSchemeQuery / ExecuteQuery

Как то по аналогии с таким юнит тестом
https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp#L8373

Так же стоит поддержать возможность в SHOW CREATE TABLE запросе

@Tony-Romanov
Copy link
Collaborator Author

Tony-Romanov commented Jul 25, 2025

Если мы добавляем возможность создавать такие таблицы через запрос, то стоит добавить какой-то базовый юнит тест через ExecuteSchemeQuery / ExecuteQuery

Как то по аналогии с таким юнит тестом https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp#L8373

Так же стоит поддержать возможность в SHOW CREATE TABLE запросе

Я уже сделал такой тест в KQP, но в этом PR ещё нет SQL части, потому он пока ждёт локально.
Я пока не понял, как лучше сейчас: всё в один PR запихивать или YQL часть отдельно?
Ведь сейчас, как я понял, у YQL аркадия это основной.

@maximyurchuk maximyurchuk removed the request for review from a team July 30, 2025 08:42
@Tony-Romanov Tony-Romanov requested review from Gazizonoki, SammyVimes and snaury and removed request for Gazizonoki, SammyVimes and va-kuznecov July 30, 2025 09:32
@github-actions
Copy link

github-actions bot commented Aug 4, 2025 •
edited
Loading

⚪ 2025-08-04 04:52:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for d83f881 has started.
⚪ 2025-08-04 04:52:21 UTC Artifacts will be uploaded here
⚪ 2025-08-04 04:56:26 UTC ya make is running...
🟡 2025-08-04 06:56:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39898 37123 0 3 2743 29

⚪ 2025-08-04 06:59:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-04 07:11:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
275 (only retried tests) 206 0 0 50 19

🟢 2025-08-04 07:12:06 UTC Build successful.
🟢 2025-08-04 07:12:26 UTC ydbd size 2.2 GiB changed* by +8.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d972f1d merge: d83f881 diff diff %
ydbd size 2 410 714 072 Bytes 2 410 722 808 Bytes +8.5 KiB +0.000%
ydbd stripped size 503 463 592 Bytes 503 464 808 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 4, 2025 •
edited
Loading

⚪ 2025-08-04 04:52:32 UTC Pre-commit check linux-x86_64-release-asan for d83f881 has started.
⚪ 2025-08-04 04:52:47 UTC Artifacts will be uploaded here
⚪ 2025-08-04 04:56:50 UTC ya make is running...
🟡 2025-08-04 07:40:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17345 16911 0 121 286 27

🟢 2025-08-04 07:41:43 UTC Build successful.
🟢 2025-08-04 07:42:17 UTC ydbd size 3.9 GiB changed* by +19.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d972f1d merge: d83f881 diff diff %
ydbd size 4 238 136 248 Bytes 4 238 156 472 Bytes +19.8 KiB +0.000%
ydbd stripped size 1 467 400 216 Bytes 1 467 402 776 Bytes +2.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

⚪ 2025-08-18 02:16:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7324ff4 has started.
⚪ 2025-08-18 02:16:35 UTC Artifacts will be uploaded here
⚪ 2025-08-18 02:20:30 UTC ya make is running...
🟡 2025-08-18 04:25:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40205 37444 0 5 2716 40

⚪ 2025-08-18 04:28:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-18 04:41:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
751 (only retried tests) 700 0 0 25 26

🟢 2025-08-18 04:41:23 UTC Build successful.
🟢 2025-08-18 04:41:45 UTC ydbd size 2.3 GiB changed* by +8.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b480c6a merge: 7324ff4 diff diff %
ydbd size 2 427 854 672 Bytes 2 427 863 328 Bytes +8.5 KiB +0.000%
ydbd stripped size 509 046 216 Bytes 509 047 368 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

⚪ 2025-08-18 02:17:02 UTC Pre-commit check linux-x86_64-release-asan for 7324ff4 has started.
⚪ 2025-08-18 02:17:17 UTC Artifacts will be uploaded here
⚪ 2025-08-18 02:21:19 UTC ya make is running...
🟡 2025-08-18 05:03:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17543 17005 0 191 320 27

🟢 2025-08-18 05:05:17 UTC Build successful.
🟢 2025-08-18 05:05:48 UTC ydbd size 4.0 GiB changed* by +27.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b480c6a merge: 7324ff4 diff diff %
ydbd size 4 268 455 080 Bytes 4 268 483 496 Bytes +27.8 KiB +0.001%
ydbd stripped size 1 481 172 280 Bytes 1 481 182 968 Bytes +10.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

SammyVimes
SammyVimes approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gazizonoki
Gazizonoki approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK - ok

@Tony-Romanov Tony-Romanov merged commit 7b49d48 into ydb-platform:main Aug 18, 2025
14 checks passed
@Tony-Romanov Tony-Romanov deleted the external_data_channels_count branch August 18, 2025 11:45
PavelEfarinov pushed a commit to PavelEfarinov/ydb that referenced this pull request Aug 18, 2025
@Tony-Romanov @PavelEfarinov
Add external_data_channels_count creatte table feature. (ydb-platform…
57adf0f 
…#21151)

Co-authored-by: Anton Romanov <a-romanov@nebius.com>
PavelEfarinov pushed a commit to PavelEfarinov/ydb that referenced this pull request Aug 18, 2025
@Tony-Romanov @PavelEfarinov
Add external_data_channels_count creatte table feature. (ydb-platform…
3b3eaca 
…#21151)

Co-authored-by: Anton Romanov <a-romanov@nebius.com>
@stanislav-shchetinin stanislav-shchetinin mentioned this pull request Aug 21, 2025
Closed
Tony-Romanov added a commit to Tony-Romanov/ydb that referenced this pull request Aug 29, 2025
@Tony-Romanov
Add external_data_channels_count creatte table feature. (ydb-platform…
f4bb09d 
…#21151)

Co-authored-by: Anton Romanov <a-romanov@nebius.com>
@liruoko liruoko added the release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn" label Oct 13, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

@dcherednik dcherednik dcherednik approved these changes

@CyberROFL CyberROFL CyberROFL approved these changes

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@SammyVimes SammyVimes SammyVimes approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees

No one assigned

Labels

changelog/f25-3 PR участвует в списке изменений new-feature release-scope-25-3 Для PR-ов. Означает "этот PR вошел в состав одной из версий 25-3-nnn"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Tony-Romanov @gridnevvvit @snaury @dcherednik @CyberROFL @fomichev3000 @SammyVimes @Gazizonoki @liruoko