Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-2862 Add partition id to log #2251

Merged
merged 2 commits into from
Feb 27, 2024
Merged

YQ-2862 Add partition id to log #2251

merged 2 commits into from
Feb 27, 2024

Conversation

kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kardymonds kardymonds requested review from a team as code owners February 26, 2024 19:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

⚪ 2024-02-26 19:51:29 UTC Pre-commit check for 9a0cec9 has started.
⚪ 2024-02-26 19:51:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-26 19:54:07 UTC Build successful.
⚪ 2024-02-26 19:54:17 UTC Tests are running...
🔴 2024-02-26 21:35:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14863 14716 0 29 96 22

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

⚪ 2024-02-26 19:52:04 UTC Pre-commit check for 9a0cec9 has started.
⚪ 2024-02-26 19:52:06 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-26 19:55:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

⚪ 2024-02-26 20:33:39 UTC Pre-commit check for 9a0cec9 has started.
⚪ 2024-02-26 20:33:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-26 20:36:36 UTC Build successful.
⚪ 2024-02-26 20:36:44 UTC Tests are running...
🔴 2024-02-26 22:08:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67854 56947 0 2 10883 22

kardymonds
kardymonds commented Feb 27, 2024
View reviewed changes
ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h
@@ -1260,6 +1260,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
.InputIndex = inputIndex,
.StatsLevel = collectStatsLevel,
.TxId = TxId,
.TaskId = Task.GetId(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В dq_pq_read_actor всегда передавался нулевой TaskId (ни на что не влияло, только в логах отображалось)

uzhastik
uzhastik previously approved these changes Feb 27, 2024
View reviewed changes
@kardymonds kardymonds enabled auto-merge (squash) February 27, 2024 13:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 13:41:29 UTC Pre-commit check for b8059b7 has started.
⚪ 2024-02-27 13:41:31 UTC Build linux-x86_64-release-cmake14 is running...
🔴 2024-02-27 13:44:27 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 13:44:04 UTC Pre-commit check for b8059b7 has started.
⚪ 2024-02-27 13:44:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-27 13:46:26 UTC Build successful.
⚪ 2024-02-27 13:46:35 UTC Tests are running...
🔴 2024-02-27 15:25:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14867 14734 0 20 91 22

@kardymonds kardymonds merged commit 4c28a8e into ydb-platform:main Feb 27, 2024
3 of 5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 13:59:40 UTC Pre-commit check for b8059b7 has started.
⚪ 2024-02-27 13:59:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-27 14:02:28 UTC Build successful.
⚪ 2024-02-27 14:02:40 UTC Tests are running...
🔴 2024-02-27 15:33:34 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67968 57058 0 4 10887 19

kardymonds added a commit to kardymonds/ydb that referenced this pull request Feb 27, 2024
@kardymonds
YQ-2862 Add partition id to log (ydb-platform#2251)
39883c8
@shnikd shnikd mentioned this pull request Feb 27, 2024
Merged
kardymonds added a commit that referenced this pull request Feb 29, 2024
@kardymonds
YQ-2862 Add partition id to log (#2251) (#2277)
ef92ba3
@serbel324 serbel324 mentioned this pull request Mar 1, 2024
Merged
This was referenced Mar 4, 2024
Closed
Merged
This was referenced Mar 6, 2024
Merged
Open
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 7, 2024
Merged
This was referenced Mar 8, 2024
Merged
Closed
This was referenced Mar 11, 2024
Merged
Merged
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kardymonds @uzhastik @zverevgeny