Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

@UgnineSirdis UgnineSirdis commented Aug 12, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Small refactoring before PR #20133 - to make main PR clearer

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

🟢 2025-08-12 16:58:28 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

2025-08-12 16:51:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 451d260 has started.
2025-08-12 16:51:49 UTC Artifacts will be uploaded here
2025-08-12 16:54:29 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

2025-08-12 16:52:02 UTC Pre-commit check linux-x86_64-release-asan for 451d260 has started.
2025-08-12 16:52:17 UTC Artifacts will be uploaded here
2025-08-12 16:54:29 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

2025-08-12 16:55:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for de7b298 has started.
2025-08-12 16:55:52 UTC Artifacts will be uploaded here
2025-08-12 16:59:16 UTC ya make is running...
🟡 2025-08-12 18:19:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37391 34641 0 3 2708 39

2025-08-12 18:22:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-12 18:37:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
362 (only retried tests) 332 0 0 3 27

🟢 2025-08-12 18:37:38 UTC Build successful.
🟢 2025-08-12 18:37:58 UTC ydbd size 2.3 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 41b470c merge: de7b298 diff diff %
ydbd size 2 425 309 160 Bytes 2 425 309 176 Bytes +16 Bytes +0.000%
ydbd stripped size 506 628 456 Bytes 506 628 456 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

2025-08-12 16:55:55 UTC Pre-commit check linux-x86_64-release-asan for de7b298 has started.
2025-08-12 16:56:10 UTC Artifacts will be uploaded here
2025-08-12 16:59:36 UTC ya make is running...
🟡 2025-08-12 18:56:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14843 14409 0 144 264 26

🟢 2025-08-12 18:58:05 UTC Build successful.
🟢 2025-08-12 18:58:33 UTC ydbd size 4.0 GiB changed* by +968 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f50a24e merge: de7b298 diff diff %
ydbd size 4 267 666 328 Bytes 4 267 667 296 Bytes +968 Bytes +0.000%
ydbd stripped size 1 478 144 632 Bytes 1 478 144 312 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit 7f368ba into ydb-platform:main Aug 13, 2025
13 checks passed
@UgnineSirdis UgnineSirdis deleted the rename-persist-build-index-upload-methods branch August 13, 2025 08:53
PavelEfarinov pushed a commit to PavelEfarinov/ydb that referenced this pull request Aug 18, 2025
PavelEfarinov pushed a commit to PavelEfarinov/ydb that referenced this pull request Aug 18, 2025
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 22, 2025
UgnineSirdis added a commit that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants