Invoke TRope::Compact in OnVGetResult only when occupied memory excee… #23517
Conversation
…ds threshold (ydb-platform#22311) Changelog entry Invoke TRope::Compact in OnVGetResult only when occupied memory exceeds threshold Changelog category Performance improvement Description for reviewers This change prevents unnecessary TRope::Compact call by invoking it only when the occupied memory exceeds a threshold. Current code inside of the if statement is redundant as it is applying the same logic as TRope::Compact.
dcherednik
requested review from
UgnineSirdis,
alexv-smirnov,
mvgorbunov and
va-kuznecov
as code owners
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
3 participants
Changelog entry
Invoke TRope::Compact in OnVGetResult only when occupied memory exceeds threshold
Changelog category
Performance improvement
Description for reviewers
This change prevents unnecessary TRope::Compact call by invoking it only when the occupied memory exceeds a threshold. Current code inside of the if statement is redundant as it is applying the same logic as TRope::Compact.
Changelog entry
...
Changelog category
Description for reviewers
...