Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

@UgnineSirdis UgnineSirdis commented Aug 25, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This PR allows to pass folder_id/cloud_id/resource_id parameters from the actor that performs authentication step to the monitoring subsystem. Then monitoring uses them in audit logging.

I passed audit log parts to monitoring. In the future it should be done in more common way: the same as for request through grpc API: instead of passing audit log parts separately, the request context should be passed. Then this context should be used (as in grpc subsystem) in audit logging directly. It enables to use one audit context filled in one place in both http and grpc.

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

🟢 2025-08-25 16:53:13 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

2025-08-25 16:27:10 UTC Pre-commit check linux-x86_64-release-asan for 1382452 has started.
2025-08-25 16:27:24 UTC Artifacts will be uploaded here
2025-08-25 16:30:57 UTC ya make is running...
🟡 2025-08-25 18:44:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16901 16428 0 89 356 28

🟢 2025-08-25 18:46:09 UTC Build successful.
🟢 2025-08-25 18:46:39 UTC ydbd size 4.0 GiB changed* by +33.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 30b5448 merge: 1382452 diff diff %
ydbd size 4 275 038 160 Bytes 4 275 071 952 Bytes +33.0 KiB +0.001%
ydbd stripped size 1 482 777 144 Bytes 1 482 787 320 Bytes +9.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

2025-08-25 16:28:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1382452 has started.
2025-08-25 16:28:45 UTC Artifacts will be uploaded here
2025-08-25 16:32:17 UTC ya make is running...
🟡 2025-08-25 18:08:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39537 36751 0 2 2737 47

2025-08-25 18:12:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-08-25 18:26:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
752 (only retried tests) 716 0 0 12 24

🟢 2025-08-25 18:26:44 UTC Build successful.
🟢 2025-08-25 18:27:05 UTC ydbd size 2.3 GiB changed* by +21.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 30b5448 merge: 1382452 diff diff %
ydbd size 2 432 665 440 Bytes 2 432 687 464 Bytes +21.5 KiB +0.001%
ydbd stripped size 509 654 280 Bytes 509 657 416 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis enabled auto-merge (squash) August 25, 2025 17:13
@UgnineSirdis UgnineSirdis merged commit c30df31 into ydb-platform:main Aug 25, 2025
16 checks passed
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 25, 2025
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Aug 25, 2025
@UgnineSirdis UgnineSirdis deleted the pass-audit-parts-to-mon branch August 26, 2025 08:42
UgnineSirdis added a commit that referenced this pull request Aug 26, 2025
UgnineSirdis added a commit that referenced this pull request Aug 26, 2025
SloNN pushed a commit to SloNN/ydb that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants