Pass audit log subject, sanitized token, peer name fields for export and import operations and suboperations #23722
Conversation
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| optional string UserToken = 7 [(Ydb.sensitive) = true]; // serialized NACLib::TUserToken | ||
| // Fields for audit logging | ||
| optional string PeerName = 8; | ||
| optional string UserSID = 9; |
There was a problem hiding this comment.
UserSID разве не передается внутри UserToken?
There was a problem hiding this comment.
Всё так, разумеется, он и берётся из UserToken. Но:
- мы уже не имеем токена внутри операции SchemeShard. Его можно было бы сохранить в SchemeShard, но это чувствительные данные, предпочтительнее не сохранять их.
- токен в интерфейсе есть, но он предназначен для проверки, у нас же цель - это не дополнительная проверка, а лишь аудитное логирование
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
…and import operations and suboperations
Co-authored-by: ijon <ivan.chelubeev@gmail.com>
UgnineSirdis
force-pushed
the
pass-audit-log-subject-fields
branch
from
ce62ef6 to
38d4d37
Compare
|
⚪ DetailsTest history | Ya make output | Test bloat
⚪ DetailsTest history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…and import operations and suboperations (ydb-platform#23722) Co-authored-by: ijon <ivan.chelubeev@gmail.com> (cherry picked from commit 444f586)
…and import operations and suboperations (ydb-platform#23722) Co-authored-by: ijon <ivan.chelubeev@gmail.com> (cherry picked from commit 444f586)
4 participants
Changelog entry
...
Changelog category
Description for reviewers
...