Skip to content

New methods to provide IAM-tokens when accessing managed YDB from dqrun. #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitalyisaev2 merged 5 commits into from
Mar 4, 2024
Merged

New methods to provide IAM-tokens when accessing managed YDB from dqrun. #2386

vitalyisaev2 merged 5 commits into from
Mar 4, 2024

Conversation

@vitalyisaev2
Copy link
Contributor

@vitalyisaev2 vitalyisaev2 commented Mar 1, 2024 •
edited
Loading

Changelog entry

Use IAM tokens provided to dqrun via YQL_TOKEN env variable or via TGenericClusterConfig.Token field when accessing managed YDB.

Changelog category

  • Improvement

@vitalyisaev2 vitalyisaev2 requested review from a team as code owners March 1, 2024 14:08
@vitalyisaev2 vitalyisaev2 changed the title YQ 2709.token Use env variable YQL_TOKEN when accessing YDB via Generic provider and dqrun. Mar 1, 2024
@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 14:09:48 UTC Pre-commit check for 9340398 has started.
⚪ 2024-03-01 14:09:51 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-03-01 14:20:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 14:10:56 UTC Pre-commit check for 9340398 has started.
⚪ 2024-03-01 14:10:59 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-03-01 14:20:49 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 14:11:13 UTC Pre-commit check for 9340398 has started.
⚪ 2024-03-01 14:11:15 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-03-01 14:20:46 UTC Check cancelled

@vitalyisaev2 vitalyisaev2 changed the title Use env variable YQL_TOKEN when accessing YDB via Generic provider and dqrun. New methods to provide IAM-tokens when accessing managed YDB from dqrun. Mar 1, 2024
@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 14:21:57 UTC Pre-commit check for acd335b has started.
⚪ 2024-03-01 14:21:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-01 14:46:51 UTC Build successful.
⚪ 2024-03-01 14:47:06 UTC Tests are running...
🔴 2024-03-01 15:45:08 UTC Test run completed, no test results found for commit cd82568. Please check build logs.
⚫ 2024-03-01 15:45:11 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 14:22:50 UTC Pre-commit check for acd335b has started.
⚪ 2024-03-01 14:22:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-01 14:52:07 UTC Build successful.
⚪ 2024-03-01 14:52:21 UTC Tests are running...
🔴 2024-03-01 15:45:08 UTC Test run completed, no test results found for commit cd82568. Please check build logs.
⚫ 2024-03-01 15:45:12 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 14:23:41 UTC Pre-commit check for acd335b has started.
⚪ 2024-03-01 14:23:44 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-01 14:47:32 UTC Build successful.

uzhastik
uzhastik reviewed Mar 1, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 15:46:26 UTC Pre-commit check for 83e2a30 has started.
⚪ 2024-03-01 15:46:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-01 15:49:20 UTC Build successful.
⚪ 2024-03-01 15:49:32 UTC Tests are running...
🔴 2024-03-01 17:36:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68082 57153 0 6 10899 24

@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 15:47:34 UTC Pre-commit check for 83e2a30 has started.
⚪ 2024-03-01 15:47:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-01 15:49:58 UTC Build successful.
⚪ 2024-03-01 15:50:07 UTC Tests are running...
🔴 2024-03-01 17:35:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14891 14762 0 19 83 27

@vitalyisaev2 vitalyisaev2 requested a review from uzhastik March 1, 2024 15:50
@github-actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 16:01:33 UTC Pre-commit check for 83e2a30 has started.
⚪ 2024-03-01 16:01:37 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-01 16:04:46 UTC Build successful.

uzhastik
uzhastik reviewed Mar 3, 2024
View reviewed changes
ydb/library/yql/providers/generic/provider/ut/pushdown/pushdown_ut.cpp
TString sourceType;
dqIntegration->FillSourceSettings(*dqSourceNode, settings, sourceType, 1);
UNIT_ASSERT_STRINGS_EQUAL(sourceType, "PostgreSqlGeneric");
UNIT_ASSERT(settings.Is<NConnector::TSource>());
Copy link
Collaborator

@uzhastik uzhastik Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что с обратной совместимостью? Из any можно будет достаточно и старый и новый протобуф?

Copy link
Contributor Author

@vitalyisaev2 vitalyisaev2 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не уверен, что однозначно понял вопрос, но 100% ответа у меня в любом случае нет. Поэтому вернул название неймспейса к тому виду, который был у нас всегда вплоть до предыдущего PR, вмёрженного в пятницу.

@github-actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 08:37:09 UTC Pre-commit check for 35886e6 has started.
⚪ 2024-03-04 08:37:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 09:12:14 UTC Build successful.
⚪ 2024-03-04 09:12:23 UTC Tests are running...
🔴 2024-03-04 10:56:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14896 14737 0 24 106 29

@github-actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 08:38:15 UTC Pre-commit check for 35886e6 has started.
⚪ 2024-03-04 08:38:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 09:12:45 UTC Build successful.
⚪ 2024-03-04 09:12:54 UTC Tests are running...
🔴 2024-03-04 11:02:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68082 57153 0 7 10900 22

@github-actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 08:51:17 UTC Pre-commit check for 35886e6 has started.
⚪ 2024-03-04 08:51:20 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-04 09:23:20 UTC Build successful.

@vitalyisaev2 vitalyisaev2 merged commit 076c929 into ydb-platform:main Mar 4, 2024
@niksaveliev niksaveliev mentioned this pull request Mar 5, 2024
Merged
This was referenced Mar 6, 2024
Merged
Open
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 7, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Mar 8, 2024
Merged
This was referenced Mar 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 13, 2024
Merged
vitalyisaev2 added a commit to vitalyisaev2/ydb that referenced this pull request Mar 18, 2024
@vitalyisaev2
New methods to provide IAM-tokens when accessing managed YDB from `dq…
8f97d79 
…run`. (ydb-platform#2386)
@vitalyisaev2 vitalyisaev2 mentioned this pull request Mar 18, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 19, 2024
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 5, 2024
@vitalyisaev2 @EgorkaZ
New methods to provide IAM-tokens when accessing managed YDB from `dq…
fe8b15e 
…run`. (ydb-platform#2386)
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 8, 2024
@vitalyisaev2 @EgorkaZ
New methods to provide IAM-tokens when accessing managed YDB from `dq…
33e7429 
…run`. (ydb-platform#2386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik approved these changes

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees

No one assigned

Labels

improvement new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vitalyisaev2 @uzhastik @zverevgeny