Skip to content

Add base fulltext helpers #24589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kungasc merged 2 commits into from
Sep 12, 2025
Merged

Add base fulltext helpers #24589

kungasc merged 2 commits into from
Sep 12, 2025

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented Sep 10, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Tokenizer, ValidateSettings, FillSettings

Validate all unsupported settings for now

@kungasc kungasc self-assigned this Sep 10, 2025
@kungasc kungasc mentioned this pull request Sep 10, 2025
Open
13 tasks
@github-actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading

⚪ 2025-09-10 12:01:48 UTC Pre-commit check linux-x86_64-release-asan for bbd6fda has started.
⚪ 2025-09-10 12:01:51 UTC Artifacts will be uploaded here
⚪ 2025-09-10 12:05:52 UTC ya make is running...
🟡 2025-09-10 14:44:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18099 17687 0 124 264 24

🟢 2025-09-10 14:46:30 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading

⚪ 2025-09-10 12:28:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for bbd6fda has started.
⚪ 2025-09-10 12:29:37 UTC Artifacts will be uploaded here
⚪ 2025-09-10 12:34:14 UTC ya make is running...
🟡 2025-09-10 14:43:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40893 38133 0 3 2724 33

⚪ 2025-09-10 14:46:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-10 15:02:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
367 (only retried tests) 342 0 0 3 22

🟢 2025-09-10 15:02:31 UTC Build successful.

@kungasc kungasc marked this pull request as ready for review September 11, 2025 07:25
@kungasc kungasc requested a review from a team as a code owner September 11, 2025 07:25
ijon
ijon approved these changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@ijon ijon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schemeshard ok

@kungasc kungasc requested a review from vitalif September 11, 2025 09:34
vitalif
vitalif reviewed Sep 11, 2025
View reviewed changes
ydb/core/base/fulltext.cpp
return true;
}

Ydb::Table::FulltextIndexSettings FillSettings(const TString& column, const TVector<std::pair<TString, TString>>& settings, TString& error) {
Copy link
Collaborator

@vitalif vitalif Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FillSettings пока типа нигде не используется?

Copy link
Contributor Author

@kungasc kungasc Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, просто аналогичен тому что в kmeans_clusters

@kungasc kungasc merged commit 4401bf9 into ydb-platform:dev-fulltext Sep 12, 2025
15 checks passed
kungasc added a commit that referenced this pull request Sep 19, 2025
@kungasc
Add base fulltext helpers (#24589)
b899103
kungasc added a commit that referenced this pull request Sep 23, 2025
@kungasc
Add base fulltext helpers (#24589)
ee3cb79
AlexanderShprot pushed a commit to AlexanderShprot/ydb that referenced this pull request Sep 25, 2025
@kungasc
Add base fulltext helpers (ydb-platform#24589)
2b34801
neyrox pushed a commit to neyrox/ydb that referenced this pull request Oct 10, 2025
@kungasc @neyrox
Add base fulltext helpers (ydb-platform#24589)
ab2ed1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijon ijon ijon approved these changes

@vitalif vitalif vitalif approved these changes

Assignees

@kungasc kungasc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kungasc @ijon @vitalif