Skip to content

Conversation

@UgnineSirdis
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

After #24359 we don't need to wrap constants into TString()

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

2025-09-11 05:34:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for d9e7bcd has started.
2025-09-11 05:34:22 UTC Artifacts will be uploaded here

@github-actions
Copy link

🟢 2025-09-11 05:35:18 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

2025-09-11 05:35:51 UTC Pre-commit check linux-x86_64-release-asan for d9e7bcd has started.
2025-09-11 05:36:05 UTC Artifacts will be uploaded here

@UgnineSirdis UgnineSirdis added the rebase-and-check Rebase PR with the current base branch and check label Sep 11, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 11, 2025
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

2025-09-11 07:55:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3623ee7 has started.
2025-09-11 07:55:34 UTC Artifacts will be uploaded here
2025-09-11 07:58:58 UTC ya make is running...
🟡 2025-09-11 09:12:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31198 29794 0 4 1370 30

2025-09-11 09:14:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-11 09:35:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
274 (only retried tests) 251 0 0 0 23

🟢 2025-09-11 09:35:52 UTC Build successful.
🟢 2025-09-11 09:36:09 UTC ydbd size 2.3 GiB changed* by -80.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 58cbbc2 merge: 3623ee7 diff diff %
ydbd size 2 468 963 592 Bytes 2 468 881 104 Bytes -80.6 KiB -0.003%
ydbd stripped size 515 859 528 Bytes 515 851 848 Bytes -7.5 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

2025-09-11 07:55:21 UTC Pre-commit check linux-x86_64-release-asan for 3623ee7 has started.
2025-09-11 07:56:31 UTC Artifacts will be uploaded here
2025-09-11 08:00:10 UTC ya make is running...
🟡 2025-09-11 09:53:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15529 15046 0 199 260 24

🟢 2025-09-11 09:54:55 UTC Build successful.
🟢 2025-09-11 09:55:19 UTC ydbd size 4.0 GiB changed* by -183.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 58cbbc2 merge: 3623ee7 diff diff %
ydbd size 4 318 876 680 Bytes 4 318 689 040 Bytes -183.2 KiB -0.004%
ydbd stripped size 1 493 380 248 Bytes 1 493 343 960 Bytes -35.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit 4fd819c into ydb-platform:main Sep 11, 2025
18 of 20 checks passed
@UgnineSirdis UgnineSirdis deleted the refactor-audit-constants branch September 11, 2025 14:33
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Sep 11, 2025
UgnineSirdis added a commit to UgnineSirdis/ydb that referenced this pull request Sep 11, 2025
UgnineSirdis added a commit that referenced this pull request Sep 15, 2025
UgnineSirdis added a commit that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants