Skip to content

Handle fulltext index type in CREATE / ALTER TABLE #25670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kungasc merged 8 commits into from
Sep 26, 2025
Merged

Handle fulltext index type in CREATE / ALTER TABLE #25670

kungasc merged 8 commits into from
Sep 26, 2025

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented Sep 23, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@kungasc kungasc mentioned this pull request Sep 23, 2025
Open
13 tasks
@kungasc kungasc self-assigned this Sep 23, 2025
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

🟢 2025-09-24 08:59:20 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

⚪ 2025-09-23 14:58:45 UTC Pre-commit check linux-x86_64-release-asan for fa03a6e has started.
⚪ 2025-09-23 14:59:19 UTC Artifacts will be uploaded here
⚪ 2025-09-23 15:04:10 UTC ya make is running...
⚫ 2025-09-23 17:17:02 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

⚪ 2025-09-23 15:03:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa03a6e has started.
⚪ 2025-09-23 15:03:25 UTC Artifacts will be uploaded here
⚪ 2025-09-23 15:07:34 UTC ya make is running...
🟡 2025-09-23 17:12:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40622 37844 0 3 2739 36

⚪ 2025-09-23 17:12:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-09-23 17:19:17 UTC ydbd size 2.3 GiB changed* by +873.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fe4643f merge: fa03a6e diff diff %
ydbd size 2 431 408 696 Bytes 2 432 303 288 Bytes +873.6 KiB +0.037%
ydbd stripped size 520 935 336 Bytes 521 074 216 Bytes +135.6 KiB +0.027%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-09-23 17:19:18 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

⚪ 2025-09-24 08:54:30 UTC Pre-commit check linux-x86_64-release-asan for 274fa0b has started.
⚪ 2025-09-24 08:54:58 UTC Artifacts will be uploaded here
⚪ 2025-09-24 08:59:31 UTC ya make is running...
🟡 2025-09-24 11:38:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17636 17177 0 124 303 32

🟢 2025-09-24 11:38:07 UTC Build successful.
🟢 2025-09-24 11:38:28 UTC ydbd size 3.7 GiB changed* by +51.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 436545d merge: 274fa0b diff diff %
ydbd size 4 008 006 400 Bytes 4 008 059 344 Bytes +51.7 KiB +0.001%
ydbd stripped size 1 490 709 120 Bytes 1 490 732 128 Bytes +22.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 24, 2025 •
edited
Loading

⚪ 2025-09-24 08:55:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 274fa0b has started.
⚪ 2025-09-24 08:55:14 UTC Artifacts will be uploaded here
⚪ 2025-09-24 08:59:16 UTC ya make is running...
🟡 2025-09-24 11:03:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40594 37823 0 5 2729 37

⚪ 2025-09-24 11:03:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-09-24 11:15:52 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
251 (only retried tests) 232 0 0 0 19

🟢 2025-09-24 11:15:54 UTC Build successful.
🟢 2025-09-24 11:16:10 UTC ydbd size 2.2 GiB changed* by +52.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 436545d merge: 274fa0b diff diff %
ydbd size 2 411 561 888 Bytes 2 411 615 496 Bytes +52.4 KiB +0.002%
ydbd stripped size 514 182 664 Bytes 514 192 680 Bytes +9.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc changed the title Handle fulltext index type in KQP Handle fulltext index type in CREATE TABLE / ALTER TABLE Sep 24, 2025
@kungasc kungasc changed the title Handle fulltext index type in CREATE TABLE / ALTER TABLE Handle fulltext index type in CREATE / ALTER TABLE Sep 24, 2025
@kungasc kungasc marked this pull request as ready for review September 25, 2025 08:21
@kungasc kungasc requested a review from a team as a code owner September 25, 2025 08:21
@kungasc kungasc requested a review from gridnevvvit September 25, 2025 08:21
gridnevvvit
gridnevvvit reviewed Sep 26, 2025
View reviewed changes
ydb/core/kqp/ut/scheme/kqp_scheme_fulltext_ut.cpp
PRIMARY KEY (Key)
);
)";
auto result = session.ExecuteSchemeQuery(query).ExtractValueSync();
Copy link
Member

@gridnevvvit gridnevvvit Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а можно такой же тест с QueryService?

@kungasc kungasc merged commit 09f1c8d into ydb-platform:main Sep 26, 2025
16 of 17 checks passed
@kungasc kungasc mentioned this pull request Sep 30, 2025
Merged
neyrox pushed a commit to neyrox/ydb that referenced this pull request Oct 10, 2025
@kungasc @neyrox
Handle fulltext index type in CREATE / ALTER TABLE (ydb-platform#25670)
a932f54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

@kungasc kungasc

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kungasc @gridnevvvit