Skip to content

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented Oct 30, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@kungasc kungasc requested a review from Copilot October 30, 2025 10:51
@kungasc kungasc self-assigned this Oct 30, 2025
@kungasc kungasc mentioned this pull request Oct 30, 2025
13 tasks
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 10:53:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for c25333e has started.
2025-10-30 10:53:24 UTC Artifacts will be uploaded here
2025-10-30 10:55:26 UTC ya make is running...
🟡 2025-10-30 12:30:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39081 36264 0 1 2791 25

2025-10-30 12:31:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-30 12:46:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
447 (only retried tests) 427 0 1 0 19

2025-10-30 12:46:03 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-10-30 13:01:30 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
432 (only retried tests) 416 0 0 0 16

🟢 2025-10-30 13:01:33 UTC Build successful.
🟢 2025-10-30 13:01:51 UTC ydbd size 2.3 GiB changed* by +11.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5229a5 merge: c25333e diff diff %
ydbd size 2 428 185 240 Bytes 2 428 196 752 Bytes +11.2 KiB +0.000%
ydbd stripped size 517 709 800 Bytes 517 715 816 Bytes +5.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

🟢 2025-10-30 10:53:42 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for formatting fulltext index settings in the SHOW CREATE TABLE functionality. The change replaces a "todo not implemented" placeholder with a complete implementation that outputs fulltext index configuration parameters.

  • Adds EnableFulltextIndex feature flag to test environment settings
  • Implements fulltext index settings formatting with support for layout, tokenizer, and various analyzer filters
  • Adds test case to verify fulltext index formatting output

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
ydb/core/sys_view/ut_common.h Adds EnableFulltextIndex boolean flag to test environment settings struct
ydb/core/sys_view/ut_common.cpp Configures the feature flag in the test environment initialization
ydb/core/sys_view/ut_kqp.cpp Enables fulltext index feature in test and adds test case for fulltext index formatting
ydb/core/sys_view/show_create/create_table_formatter.cpp Implements fulltext index settings formatting logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

2025-10-30 10:54:36 UTC Pre-commit check linux-x86_64-release-asan for c25333e has started.
2025-10-30 10:54:54 UTC Artifacts will be uploaded here
2025-10-30 10:56:19 UTC ya make is running...
🟡 2025-10-30 12:59:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15508 15057 0 178 252 21

🟢 2025-10-30 12:59:21 UTC Build successful.
🟢 2025-10-30 12:59:43 UTC ydbd size 3.8 GiB changed* by +11.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a5229a5 merge: c25333e diff diff %
ydbd size 4 064 343 880 Bytes 4 064 355 568 Bytes +11.4 KiB +0.000%
ydbd stripped size 1 510 038 136 Bytes 1 510 043 544 Bytes +5.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc marked this pull request as ready for review October 30, 2025 13:02
@kungasc kungasc requested a review from vitalif October 30, 2025 13:03
@kungasc kungasc merged commit 3d41808 into ydb-platform:main Oct 30, 2025
19 checks passed
qyryq pushed a commit to qyryq/ydb that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants