-
Notifications
You must be signed in to change notification settings - Fork 740
Show create table supports fulltext index #27956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
⚪ ⚪ DetailsYa make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements support for formatting fulltext index settings in the SHOW CREATE TABLE functionality. The change replaces a "todo not implemented" placeholder with a complete implementation that outputs fulltext index configuration parameters.
- Adds
EnableFulltextIndexfeature flag to test environment settings - Implements fulltext index settings formatting with support for layout, tokenizer, and various analyzer filters
- Adds test case to verify fulltext index formatting output
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ydb/core/sys_view/ut_common.h | Adds EnableFulltextIndex boolean flag to test environment settings struct |
| ydb/core/sys_view/ut_common.cpp | Configures the feature flag in the test environment initialization |
| ydb/core/sys_view/ut_kqp.cpp | Enables fulltext index feature in test and adds test case for fulltext index formatting |
| ydb/core/sys_view/show_create/create_table_formatter.cpp | Implements fulltext index settings formatting logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...