Skip to content

Conversation

@dcherednik
Copy link
Member

Changelog category

  • Bugfix

Additional information

...

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 15:29:32 UTC Pre-commit check for 4902ce2 has started.
2024-03-15 15:29:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-15 15:32:43 UTC Build successful.
2024-03-15 15:32:53 UTC Tests are running...
🔴 2024-03-15 17:03:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68383 57424 0 3 10930 26

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 15:35:46 UTC Pre-commit check for 4902ce2 has started.
2024-03-15 15:35:47 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-15 15:38:52 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 15, 2024

2024-03-15 15:37:29 UTC Pre-commit check for 4902ce2 has started.
2024-03-15 15:37:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-15 15:41:01 UTC Build successful.
2024-03-15 15:41:11 UTC Tests are running...
🔴 2024-03-15 17:41:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15077 14480 0 86 480 31

ui64 ResultRowsBytes = 0;

explicit TEvTxResponse(TTxAllocatorState::TPtr allocState)
enum class EExecutionType {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А enum из протобуфа ты решил не использовать?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А там кажется нет прям идеально подходящего по семантике.
в TKqpPhyQuery нет Scheme и он больше про запрос (есть отдельно SCRIPT)
TKqpPhyTx в принципе можно, но TKqpExecuterBase уже принимал enum ExecType вторым аргументом который прям хорошо ложился.

Наверно можно порефакторить чтоб использовать везде один enum (в том числе и в TKqpExecuterBase) но я что то не уверен сходу...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants