Fix read iterator local snapshot consistency. Fixes #2885. #3037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
azevaykin
approved these changes
Mar 21, 2024
snaury
added a commit
to snaury/ydb
that referenced
this pull request
Mar 22, 2024
Merged
This was referenced Mar 29, 2024
Merged
This was referenced Apr 4, 2024
Merged
This was referenced Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Changelog category
Additional information
A very rare failure was detected with Jepsen, where an immediate (but locally upgraded to repeatable) read caused dependency confusion between concurrent writes, making it possible to commit writes to the same key in the reverse mvcc version order. Additional issues have been identified, which made it possible for local snapshot reads to violate repeatable read guarantees, those have also been fixed with corresponding regression tests.
Fixes #2885.