Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pq sdk deadlock has been fixed (between Close and OnReadDone) #3115

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

dorooleg
Copy link
Collaborator

Changelog entry

pq sdk deadlock has been fixed (between Close and OnReadDone)

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Mar 25, 2024

2024-03-25 06:47:40 UTC Pre-commit check for d809883 has started.
2024-03-25 06:47:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-25 06:50:31 UTC Build successful.
2024-03-25 06:50:44 UTC Tests are running...
🔴 2024-03-25 08:18:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14414 14161 0 36 190 27

Copy link

github-actions bot commented Mar 25, 2024

2024-03-25 06:47:52 UTC Pre-commit check for d809883 has started.
2024-03-25 06:47:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-25 06:50:26 UTC Build successful.

Copy link

github-actions bot commented Mar 25, 2024

2024-03-25 06:47:53 UTC Pre-commit check for d809883 has started.
2024-03-25 06:47:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-25 06:50:43 UTC Build successful.
2024-03-25 06:50:56 UTC Tests are running...
🔴 2024-03-25 08:19:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69036 57931 0 5 11031 69

@dorooleg dorooleg marked this pull request as ready for review March 25, 2024 14:54
@dorooleg dorooleg merged commit f1be286 into ydb-platform:main Mar 25, 2024
4 of 6 checks passed
@@ -796,14 +800,16 @@ class TReadSessionEventsQueue: public TBaseSessionEventsQueue<TAReadSessionSetti

bool Close(const TASessionClosedEvent<UseMigrationProtocol>& event, TDeferredActions<UseMigrationProtocol>& deferred) {
TWaiter waiter;
TVector<TRawPartitionStreamEventQueue<UseMigrationProtocol>> defferedDelete;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: deferred

This was referenced Mar 29, 2024
@shnikd shnikd mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants