KIKIMR-20100: Add background cleaning #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridnevvvit
reviewed
Dec 13, 2023
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c2d4184.
🔴 linux-x86_64-release-asan: some tests FAILED for commit c2d4184.
|
ijon
requested changes
Dec 25, 2023
shnikd
force-pushed
the
background-cleaning
branch
from
0ddc246 to
0648e9f
Compare
gridnevvvit
previously approved these changes
Dec 28, 2023
ijon
requested changes
Dec 28, 2023
Collaborator
ijon
left a comment
ijon
left a comment
There was a problem hiding this comment.
Not simplified enough after switching to single actor per node.
Also several problems with internal drop operations execution.
|
|
||
| optional TTableReplicationConfig ReplicationConfig = 40; | ||
|
|
||
| optional bool Temporary = 41; |
Collaborator
There was a problem hiding this comment.
Also there is problem that temporary tables must be ignored by backups. Somehow.
shnikd
force-pushed
the
background-cleaning
branch
from
ce05f61 to
c2d4184
Compare
ijon
requested changes
Jan 25, 2024
ydb/core/tx/schemeshard/ut_background_cleaning/ut_background_cleaning.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/ut_background_cleaning/ut_background_cleaning.cpp
Outdated
Show resolved
Hide resolved
ydb/core/tx/schemeshard/ut_background_cleaning/ut_background_cleaning.cpp
Outdated
Show resolved
Hide resolved
| break; | ||
| default: { | ||
| BackgroundCleaningQueue->OnDone(pathId); | ||
| EnqueueBackgroundCleaning(pathId); |
Collaborator
There was a problem hiding this comment.
Is there a potential for the eternal loop?
shnikd
force-pushed
the
background-cleaning
branch
from
c2d4184 to
0d60bb9
Compare
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.