-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow read table returns and use not null types via public API #5219
Merged
dcherednik
merged 4 commits into
ydb-platform:stable-24-1
from
dcherednik:stable-24-1_fix
Jul 4, 2024
Merged
Allow read table returns and use not null types via public API #5219
dcherednik
merged 4 commits into
ydb-platform:stable-24-1
from
dcherednik:stable-24-1_fix
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog category Bugfix
We already have checks for value tuple element count and do not want to change error messages in case of violation. Changelog category Bugfix
Support for not null response for ReadTable [1/2 commit] - We need to support compatibility with old datashard. In this commit if client ask we send ReadTableTransaction and ask for V2 response format. Old datashard doesn't know about this format and use legasy response instead. We treat this response as error. Support for not null response for ReadTable [2/2 commit] - Datashard support for ReadTable transaction with not null support. Now datashard can handle new flag and returns proper ResultSet
⚪
|
spuchin
approved these changes
Jul 4, 2024
fomichev3000
approved these changes
Jul 4, 2024
dcherednik
added a commit
to dcherednik/ydb
that referenced
this pull request
Jul 5, 2024
dcherednik
added a commit
that referenced
this pull request
Jul 5, 2024
uzhastik
pushed a commit
to uzhastik/ydb
that referenced
this pull request
Jul 5, 2024
uzhastik
pushed a commit
to uzhastik/ydb
that referenced
this pull request
Jul 6, 2024
uzhastik
pushed a commit
to uzhastik/ydb
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.