Skip to content

added GetOpenTelemetryTraceParent() to IRequestCtxBaseMtSafe #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uzhastik merged 1 commit into from
Dec 19, 2023
Merged

added GetOpenTelemetryTraceParent() to IRequestCtxBaseMtSafe #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ydb/core/grpc_services/base/base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,10 @@ class TRefreshTokenImpl
return {};
}

TMaybe<TString> GetOpenTelemetryTraceParent() const override {
return {};
}

TMaybe<TString> GetSdkBuildInfo() const {
return {};
}
Expand Down Expand Up @@ -817,6 +821,10 @@ class TGRpcRequestBiStreamWrapper
return GetPeerMetaValues(NYdb::YDB_TRACE_ID_HEADER);
}

TMaybe<TString> GetOpenTelemetryTraceParent() const override {
return GetPeerMetaValues(NYdb::OTEL_TRACE_HEADER);
}

const TMaybe<TString> GetSdkBuildInfo() const {
return GetPeerMetaValues(NYdb::YDB_SDK_BUILD_INFO_HEADER);
}
Expand Down Expand Up @@ -1139,6 +1147,10 @@ class TGRpcRequestWrapperImpl
return GetPeerMetaValues(NYdb::YDB_TRACE_ID_HEADER);
}

TMaybe<TString> GetOpenTelemetryTraceParent() const override {
return GetPeerMetaValues(NYdb::OTEL_TRACE_HEADER);
}

const TMaybe<TString> GetSdkBuildInfo() const {
return GetPeerMetaValues(NYdb::YDB_SDK_BUILD_INFO_HEADER);
}
Expand Down
1 change: 1 addition & 0 deletions ydb/core/grpc_services/base/iface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ using TAuditLogHook = std::function<void (ui32 status, const TAuditLogParts&)>;
class IRequestCtxBaseMtSafe {
public:
virtual TMaybe<TString> GetTraceId() const = 0;
virtual TMaybe<TString> GetOpenTelemetryTraceParent() const = 0;
// Returns client provided database name
virtual const TMaybe<TString> GetDatabaseName() const = 0;
// Returns "internal" token (result of ticket parser authentication)
Expand Down
4 changes: 4 additions & 0 deletions ydb/core/grpc_services/local_rpc/local_rpc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ class TLocalRpcCtx : public NGRpcService::IRequestOpCtx {
return Nothing();
}

TMaybe<TString> GetOpenTelemetryTraceParent() const override {
return Nothing();
}

TInstant GetDeadline() const override {
return TInstant::Max();
}
Expand Down