Skip to content

Enabled CBO #5780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelvelikhov merged 43 commits into from
Jul 8, 2024
Merged

Enabled CBO #5780

pavelvelikhov merged 43 commits into from
Jul 8, 2024

Conversation

@pavelvelikhov
Copy link
Collaborator

@pavelvelikhov pavelvelikhov commented Jun 20, 2024

Changelog entry

...

Changelog category

  • Improvement
  • Performance improvement

Additional information

...

@pavelvelikhov pavelvelikhov requested a review from a team as a code owner June 20, 2024 11:13
@github-actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 11:56:04 UTC Pre-commit check for 338e78f has started.
⚪ 2024-06-20 11:58:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-20 12:28:44 UTC Build successful.
⚪ 2024-06-20 12:28:58 UTC Tests are running...
🔴 2024-06-20 14:30:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11699 11463 0 162 61 13

🟢 2024-06-20 14:30:54 UTC ydbd size 5.7 GiB changed by -400 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f95d5a6 merge: 338e78f diff diff %
ydbd size 6 149 690 728 Bytes 6 149 690 328 Bytes -400 Bytes -0.000%
ydbd stripped size 1 527 556 160 Bytes 1 527 556 096 Bytes -64 Bytes -0.000%

@github-actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 12:13:02 UTC Pre-commit check for 338e78f has started.
⚪ 2024-06-20 12:15:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-20 12:53:09 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 12:13:54 UTC Pre-commit check for 338e78f has started.
⚪ 2024-06-20 12:16:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-20 12:43:49 UTC Build successful.
⚪ 2024-06-20 12:44:01 UTC Tests are running...
🔴 2024-06-20 15:06:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72353 58875 0 175 13293 10

🟢 2024-06-20 15:07:44 UTC ydbd size 8.6 GiB changed by -19.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 58f6122 merge: 338e78f diff diff %
ydbd size 9 215 474 408 Bytes 9 215 454 944 Bytes -19.0 KiB -0.000%
ydbd stripped size 711 326 448 Bytes 711 325 936 Bytes -512 Bytes -0.000%

@github-actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 14:24:40 UTC Pre-commit check for 5b75fdf has started.
⚪ 2024-07-03 14:27:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-03 15:13:55 UTC Build successful.
⚪ 2024-07-03 15:14:07 UTC Tests are running...
🔴 2024-07-03 17:21:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15182 14536 0 130 346 170

🟢 2024-07-03 17:22:50 UTC ydbd size 5.3 GiB changed* by -98.2 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: 5b75fdf diff diff %
ydbd size 5 814 908 560 Bytes 5 711 962 192 Bytes -98.2 MiB -1.770%
ydbd stripped size 1 247 931 016 Bytes 1 235 232 968 Bytes -12.1 MiB -1.018%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 14:31:19 UTC Pre-commit check for 5b75fdf has started.
⚪ 2024-07-03 14:34:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 15:15:57 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

⚪ 2024-07-03 14:42:09 UTC Pre-commit check for 5b75fdf has started.
⚪ 2024-07-03 14:45:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 15:45:24 UTC Build successful.
⚪ 2024-07-03 15:45:43 UTC Tests are running...
🔴 2024-07-03 18:03:17 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76155 62671 0 87 13385 12

🟢 2024-07-03 18:03:57 UTC ydbd size 8.2 GiB changed* by -145.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd87563 merge: 5b75fdf diff diff %
ydbd size 8 926 807 928 Bytes 8 774 655 200 Bytes -145.1 MiB -1.704%
ydbd stripped size 486 814 568 Bytes 482 662 376 Bytes -4.0 MiB -0.853%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 12:04:18 UTC Pre-commit check for a5db69e has started.
⚪ 2024-07-04 12:07:36 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-04 12:49:43 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 12:04:27 UTC Pre-commit check for a5db69e has started.
⚪ 2024-07-04 12:07:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 12:47:03 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 12:06:45 UTC Pre-commit check for a5db69e has started.
⚪ 2024-07-04 12:09:35 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-04 12:50:11 UTC Check cancelled

@pavelvelikhov pavelvelikhov requested a review from a team as a code owner July 4, 2024 12:48
@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:01:06 UTC Pre-commit check for 12dc40a has started.
⚪ 2024-07-04 13:03:59 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-04 13:10:37 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:02:52 UTC Pre-commit check for 12dc40a has started.
⚪ 2024-07-04 13:06:19 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-07-04 13:10:30 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:06:52 UTC Pre-commit check for 12dc40a has started.
⚪ 2024-07-04 13:09:45 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-04 13:10:26 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:13:32 UTC Pre-commit check for 5226346 has started.
⚪ 2024-07-04 13:16:33 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-07-04 13:20:19 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:13:47 UTC Pre-commit check for 5226346 has started.
⚪ 2024-07-04 13:16:39 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-04 13:21:07 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:14:22 UTC Pre-commit check for 5226346 has started.
⚪ 2024-07-04 13:17:13 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-04 13:20:16 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:25:08 UTC Pre-commit check for 57615c8 has started.
⚪ 2024-07-04 13:28:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-04 14:11:41 UTC Build successful.
⚪ 2024-07-04 14:11:56 UTC Tests are running...
🔴 2024-07-04 16:28:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76235 62705 0 84 13427 19

🟢 2024-07-04 16:29:16 UTC ydbd size 8.2 GiB changed* by +65.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: caa19d5 merge: 57615c8 diff diff %
ydbd size 8 775 753 992 Bytes 8 775 820 672 Bytes +65.1 KiB +0.001%
ydbd stripped size 482 728 232 Bytes 482 732 264 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 13:30:59 UTC Pre-commit check for 57615c8 has started.
⚪ 2024-07-04 13:34:19 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 13:46:33 UTC Build successful.

spuchin
spuchin reviewed Jul 6, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 13:40:25 UTC Pre-commit check for 901ef1d has started.
⚪ 2024-07-07 13:43:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-07 14:13:07 UTC Build successful.
⚪ 2024-07-07 14:13:24 UTC Tests are running...
🔴 2024-07-07 14:42:32 UTC Test run completed, no test results found for commit fe80426. Please check test log.
🟡 2024-07-07 14:43:20 UTC ydbd size 5.2 GiB changed* by +111.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: bc77d99 merge: 901ef1d diff diff %
ydbd size 5 614 059 552 Bytes 5 614 174 184 Bytes +111.9 KiB +0.002%
ydbd stripped size 1 209 973 912 Bytes 1 209 995 512 Bytes +21.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-07 14:43:22 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 13:40:29 UTC Pre-commit check for 901ef1d has started.
⚪ 2024-07-07 13:43:21 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-07 13:55:44 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 13:41:07 UTC Pre-commit check for 901ef1d has started.
⚪ 2024-07-07 13:44:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-07 14:29:26 UTC Build successful.
⚪ 2024-07-07 14:29:43 UTC Tests are running...
🔴 2024-07-07 14:42:31 UTC Test run completed, no test results found for commit fe80426. Please check test log.
🟢 2024-07-07 14:43:22 UTC ydbd size 8.1 GiB changed* by +79.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bc77d99 merge: 901ef1d diff diff %
ydbd size 8 721 670 280 Bytes 8 721 751 296 Bytes +79.1 KiB +0.001%
ydbd stripped size 476 619 640 Bytes 476 625 016 Bytes +5.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-07 14:43:24 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 14:45:21 UTC Pre-commit check for 6dc9ee0 has started.
⚪ 2024-07-07 14:48:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-07 15:34:13 UTC Build successful.
⚪ 2024-07-07 15:34:26 UTC Tests are running...
🔴 2024-07-07 17:52:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76257 62815 0 3 13429 10

🟢 2024-07-07 17:52:52 UTC ydbd size 8.1 GiB changed* by +77.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77685b3 merge: 6dc9ee0 diff diff %
ydbd size 8 721 673 992 Bytes 8 721 752 872 Bytes +77.0 KiB +0.001%
ydbd stripped size 476 619 640 Bytes 476 624 888 Bytes +5.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 14:46:40 UTC Pre-commit check for 6dc9ee0 has started.
⚪ 2024-07-07 14:50:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-07 15:18:50 UTC Build successful.
⚪ 2024-07-07 15:19:04 UTC Tests are running...
🔴 2024-07-07 17:22:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15194 14579 0 97 342 176

🟡 2024-07-07 17:22:52 UTC ydbd size 5.2 GiB changed* by +106.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77685b3 merge: 6dc9ee0 diff diff %
ydbd size 5 614 060 320 Bytes 5 614 169 080 Bytes +106.2 KiB +0.002%
ydbd stripped size 1 209 974 104 Bytes 1 209 995 064 Bytes +20.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 14:47:15 UTC Pre-commit check for 6dc9ee0 has started.
⚪ 2024-07-07 14:50:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-07 15:01:48 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 20:30:00 UTC Pre-commit check for 7644bc4 has started.
⚪ 2024-07-07 20:32:52 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-07-07 20:34:44 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 20:30:11 UTC Pre-commit check for 7644bc4 has started.
⚪ 2024-07-07 20:33:11 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-07 20:34:50 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 20:31:07 UTC Pre-commit check for 7644bc4 has started.
⚪ 2024-07-07 20:33:58 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-07 20:34:43 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 20:36:34 UTC Pre-commit check for 4885143 has started.
⚪ 2024-07-07 20:39:25 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-07 20:44:56 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 20:36:38 UTC Pre-commit check for 4885143 has started.
⚪ 2024-07-07 20:39:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-07 21:04:18 UTC Build successful.
⚪ 2024-07-07 21:04:37 UTC Tests are running...
🔴 2024-07-07 23:11:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15196 14584 0 94 347 171

🟡 2024-07-07 23:12:42 UTC ydbd size 5.2 GiB changed* by +143.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77685b3 merge: 4885143 diff diff %
ydbd size 5 614 060 320 Bytes 5 614 207 128 Bytes +143.4 KiB +0.003%
ydbd stripped size 1 209 974 104 Bytes 1 210 001 656 Bytes +26.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 7, 2024 •
edited
Loading

⚪ 2024-07-07 20:38:37 UTC Pre-commit check for 4885143 has started.
⚪ 2024-07-07 20:41:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-07 21:20:31 UTC Build successful.
⚪ 2024-07-07 21:20:46 UTC Tests are running...
🔴 2024-07-07 23:24:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76257 62818 0 1 13428 10

🟢 2024-07-07 23:25:07 UTC ydbd size 8.1 GiB changed* by +95.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77685b3 merge: 4885143 diff diff %
ydbd size 8 721 673 992 Bytes 8 721 772 000 Bytes +95.7 KiB +0.001%
ydbd stripped size 476 619 640 Bytes 476 625 976 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pavelvelikhov pavelvelikhov merged commit 57741e4 into ydb-platform:main Jul 8, 2024
This was referenced Jul 9, 2024
Merged
Merged
Merged
This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 24, 2024
Merged
pavelvelikhov added a commit to pavelvelikhov/ydb that referenced this pull request Sep 5, 2024
@pavelvelikhov @pashandor789
Enabled CBO (ydb-platform#5780)
bd7d66a 
Co-authored-by: Pavel Ivanov <pudge1000-7@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spuchin spuchin spuchin approved these changes

+1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelvelikhov @resetius @spuchin @pashandor789