Skip to content

Replace Y_ABORT_UNLESS #2 #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nshestakov merged 1 commit into from
Dec 21, 2023
Merged

Replace Y_ABORT_UNLESS #2 #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ydb/core/persqueue/partition_read.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,8 @@ void TPartition::DoRead(TEvPQ::TEvRead::TPtr ev, TDuration waitQuotaTime, const
const TString& user = read->ClientId;
auto userInfo = UsersInfoStorage->GetIfExists(user);
if(!userInfo) {
ReplyError(ctx, read->Cookie, NPersQueue::NErrorCode::BAD_REQUEST, TStringBuilder() << "cannot finish read request. Consumer " << read->ClientId << " is gone from partition");
ReplyError(ctx, read->Cookie, NPersQueue::NErrorCode::BAD_REQUEST,
TStringBuilder() << "cannot finish read request. Consumer " << read->ClientId << " is gone from partition");
Send(ReadQuotaTrackerActor, new TEvPQ::TEvConsumerRemoved(user));
OnReadRequestFinished(read->Cookie, 0, user, ctx);
return;
Expand Down Expand Up @@ -757,7 +758,11 @@ void TPartition::DoRead(TEvPQ::TEvRead::TPtr ev, TDuration waitQuotaTime, const
return;
}

Y_ABORT_UNLESS(offset < EndOffset);
if (offset > EndOffset) {
ReplyError(ctx, read->Cookie, NPersQueue::NErrorCode::BAD_REQUEST,
TStringBuilder() << "Offset more than EndOffset. Offset=" << offset << ", EndOffset=" << EndOffset);
return;
}

ProcessRead(ctx, std::move(info), cookie, false);
}
Expand Down