Skip to content

logging(ydb): add data integrity logs to grpc and session actor #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ulya-sidorina merged 1 commit into from
Aug 29, 2024
Merged

logging(ydb): add data integrity logs to grpc and session actor #6049

ulya-sidorina merged 1 commit into from
Aug 29, 2024

Conversation

@ulya-sidorina
Copy link
Collaborator

@ulya-sidorina ulya-sidorina commented Jun 27, 2024

No description provided.

@ulya-sidorina ulya-sidorina linked an issue Jun 27, 2024 that may be closed by this pull request
[[data integrity trails]] log additional tx info in grpc/session actor #6048
Closed
@github-actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

⚪ 2024-06-27 18:17:25 UTC Pre-commit check for 1e759a9 has started.
⚪ 2024-06-27 18:20:22 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-27 18:25:45 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

⚪ 2024-06-27 18:17:31 UTC Pre-commit check for 1e759a9 has started.
⚪ 2024-06-27 18:20:25 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-27 18:25:31 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

⚪ 2024-06-27 18:18:16 UTC Pre-commit check for 1e759a9 has started.
⚪ 2024-06-27 18:21:20 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-27 18:27:06 UTC Build failed. see the build logs.

@ulya-sidorina ulya-sidorina force-pushed the logging/ydb-6048 branch 3 times, most recently from a57c28f to 53d2e50 Compare July 10, 2024 08:36
@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 08:38:56 UTC Pre-commit check for 8e6213e has started.
⚪ 2024-07-10 08:41:54 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-10 08:42:07 UTC Build failed. see the build logs.
🔴 2024-07-10 08:42:08 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 08:41:27 UTC Pre-commit check for 8e6213e has started.
⚪ 2024-07-10 08:44:26 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-10 08:44:40 UTC Build failed. see the build logs.
🔴 2024-07-10 08:44:41 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 08:43:27 UTC Pre-commit check for 8e6213e has started.
⚪ 2024-07-10 08:46:27 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-10 08:46:41 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:12:46 UTC Pre-commit check for 3fc8b28 has started.
⚪ 2024-07-10 09:15:39 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-10 09:15:53 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:12:56 UTC Pre-commit check for 3fc8b28 has started.
⚪ 2024-07-10 09:16:00 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-10 09:16:14 UTC Build failed. see the build logs.
🔴 2024-07-10 09:16:16 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:15:19 UTC Pre-commit check for 3fc8b28 has started.
⚫ 2024-07-10 09:17:59 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:24:05 UTC Pre-commit check for e3005b5 has started.
⚪ 2024-07-10 09:26:59 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-10 09:27:12 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:30:56 UTC Pre-commit check for e3005b5 has started.
⚪ 2024-07-10 09:33:48 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-10 09:34:02 UTC Build failed. see the build logs.
🔴 2024-07-10 09:34:03 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 09:32:32 UTC Pre-commit check for e3005b5 has started.
⚪ 2024-07-10 09:35:34 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-10 09:35:48 UTC Build failed. see the build logs.
🔴 2024-07-10 09:35:50 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 14:04:18 UTC Pre-commit check for 1d562b0 has started.
⚪ 2024-07-10 14:07:12 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-10 14:07:26 UTC Build failed. see the build logs.
🔴 2024-07-10 14:07:28 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 14:58:06 UTC Pre-commit check for 9323bd6 has started.
⚪ 2024-07-10 15:01:31 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-10 15:01:46 UTC Build failed. see the build logs.
🔴 2024-07-10 15:01:47 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 15:17:33 UTC Pre-commit check for 9323bd6 has started.
⚪ 2024-07-10 15:21:05 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-10 15:21:19 UTC Build failed. see the build logs.
🔴 2024-07-10 15:21:20 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 15:18:59 UTC Pre-commit check for 9323bd6 has started.
⚪ 2024-07-10 15:21:53 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-10 15:22:08 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 08:51:51 UTC Pre-commit check for 1f48e64 has started.
⚪ 2024-07-11 08:54:48 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-11 08:55:02 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 08:52:17 UTC Pre-commit check for 1f48e64 has started.
⚪ 2024-07-11 08:55:20 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-11 08:55:35 UTC Build failed. see the build logs.
🔴 2024-07-11 08:55:37 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 08:54:13 UTC Pre-commit check for 1f48e64 has started.
⚪ 2024-07-11 08:57:21 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-11 08:57:36 UTC Build failed. see the build logs.
🔴 2024-07-11 08:57:37 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 13:54:51 UTC Pre-commit check for 1e2a4a3 has started.
⚫ 2024-07-11 13:55:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 09:15:57 UTC Pre-commit check for eaf3123 has started.
⚪ 2024-08-28 09:20:08 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-28 11:17:57 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13992 13922 0 13 34 23

🟢 2024-08-28 11:19:07 UTC Build successful.
🟡 2024-08-28 11:19:39 UTC ydbd size 5.5 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 10af6ea merge: eaf3123 diff diff %
ydbd size 5 929 603 080 Bytes 5 930 963 000 Bytes +1.3 MiB +0.023%
ydbd stripped size 1 489 249 072 Bytes 1 489 454 000 Bytes +200.1 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 09:16:59 UTC Pre-commit check for eaf3123 has started.
⚪ 2024-08-28 09:22:32 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-28 10:56:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76170 62463 0 5 13683 19

⚪ 2024-08-28 11:03:37 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-28 11:13:37 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23 (only retried tests) 12 0 0 0 11

🟢 2024-08-28 11:13:46 UTC Build successful.
🟡 2024-08-28 11:14:26 UTC ydbd size 8.2 GiB changed* by +836.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 10af6ea merge: eaf3123 diff diff %
ydbd size 8 801 146 168 Bytes 8 802 002 616 Bytes +836.4 KiB +0.010%
ydbd stripped size 479 898 888 Bytes 479 944 712 Bytes +44.8 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

dcherednik
dcherednik previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@dcherednik dcherednik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

va-kuznecov
va-kuznecov previously approved these changes Aug 28, 2024
View reviewed changes
@ulya-sidorina ulya-sidorina dismissed stale reviews from va-kuznecov and dcherednik via ef1945c August 28, 2024 14:09
@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-29 11:27:42 UTC Pre-commit check linux-x86_64-release-asan for 688d87a has started.
⚪ 2024-08-29 11:31:54 UTC ya make is running...
🔴 2024-08-29 13:03:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13989 13922 0 15 32 20

🟢 2024-08-29 13:04:17 UTC Build successful.
🟡 2024-08-29 13:04:48 UTC ydbd size 5.5 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1500574 merge: 688d87a diff diff %
ydbd size 5 935 056 784 Bytes 5 936 416 984 Bytes +1.3 MiB +0.023%
ydbd stripped size 1 490 633 264 Bytes 1 490 835 120 Bytes +197.1 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-29 11:27:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 688d87a has started.
⚪ 2024-08-29 11:31:04 UTC ya make is running...
🟡 2024-08-29 12:38:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76168 62465 0 4 13684 15

⚪ 2024-08-29 12:46:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-08-29 12:54:20 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 13 0 0 0 11

🟢 2024-08-29 12:54:29 UTC Build successful.
🟡 2024-08-29 12:55:04 UTC ydbd size 8.2 GiB changed* by +841.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1500574 merge: 688d87a diff diff %
ydbd size 8 807 792 336 Bytes 8 808 654 416 Bytes +841.9 KiB +0.010%
ydbd stripped size 480 297 448 Bytes 480 347 560 Bytes +48.9 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

⚪ 2024-08-28 14:24:25 UTC Pre-commit check linux-x86_64-release-clang14 for 688d87a has started.
⚪ 2024-08-28 14:29:16 UTC ya make is running...
🟢 2024-08-28 15:14:46 UTC Build successful.

SammyVimes
SammyVimes approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulya-sidorina ulya-sidorina enabled auto-merge (squash) August 29, 2024 11:12
@ulya-sidorina ulya-sidorina merged commit 9c8c951 into ydb-platform:main Aug 29, 2024
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 30, 2024
Closed
@siarheivesialou siarheivesialou mentioned this pull request Aug 30, 2024
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@ulya-sidorina @stanislav-shchetinin
logging(ydb): add data integrity logs to grpc and session actor (ydb-…
2889f9d 
…platform#6049)
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 4, 2024
Merged
Merged
Merged
SammyVimes pushed a commit to SammyVimes/ydb that referenced this pull request Sep 6, 2024
@ulya-sidorina @SammyVimes
logging(ydb): add data integrity logs to grpc and session actor (ydb-…
3593728 
…platform#6049)

(cherry picked from commit 9c8c951)
This was referenced Sep 9, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SammyVimes SammyVimes SammyVimes approved these changes

@va-kuznecov va-kuznecov va-kuznecov approved these changes

@dcherednik dcherednik dcherednik left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[[data integrity trails]] log additional tx info in grpc/session actor

4 participants

@ulya-sidorina @dcherednik @SammyVimes @va-kuznecov